Code Review Administrators

You are viewing a wiki page. You are welcome to join the group and then edit it. Be bold!

Posted by zzolo on April 14, 2011 at 11:30pm
Last updated by Michelle on Sat, 2013-03-09 18:12

The following is a list of code review administrators. This means they have, and use, access to grant full project release (i.e. vetted git status). This is technically called a "Git administrator" on Drupal.org.

If you have completely reviewed an application, and need it to be "fixed", please consider finding these people. BUT be nice about it, they are busy people as well.

What is Git Admin access

Please read the documentation to find out what it means to be an administrator and how to get it. But keep in mind that ANYONE CAN REVIEW APPLICATIONS; please see the how to to get started.

Comments

There are currently 12 issues

Posted by greggles on April 24, 2011 at 10:55pm

There are currently 12 issues in RTBC including 1 that is 6 days old:

http://drupal.org/project/issues/projectapplications?status=14&

certifiedtorock.com/u/36762/ | Druplicon debit card

.

Posted by Michelle on April 2, 2012 at 3:11am

I have access as well. While I don't review applications anymore, I am around frequently and have no problem checking the box on RTBC applications. Just ping me on IRC.

_{My blog, mostly about Drupal: Shell Multimedia}

There are 30 projects in RTBC

Posted by dSero on October 24, 2012 at 8:57am

Dear git admins!

I just looked at my project status (http://drupal.org/node/1804878), and found out there are 30 projects in RTBC, including one that is in this status for 6 weeks...
I'm aware of the load that you have and I would like to thank klausi for his hard work reviewing my module and other community peers for doing the same.

Is there anyway that you release this bottleneck?
In the new method of review your peers, I reviewed 12 projects and more than 5 peers reviewed mine. Maybe you can change the approval process so only a single git admin review and approval will be needed to push a project to production?

If not, can you make an effort and push the projects to production? I believe it will push innovation forward among the community,

Best Regards,
Moshe

He has a good point

Posted by Diogenes on October 24, 2012 at 10:51am

RTBC means the module works, right? At least in the context of the reviewer.

So what is the problem here?

RTBC, with no serious PAReview errors (whatever that means) should be an automatic promotion after 2 weeks with an a prominent Pending Sandbox Promotions> notice board so in case anybody wants to file an objection.

Automatic promotion

Posted by cubeinspire on October 24, 2012 at 11:22am

RTBC projects are automatically promoted after 6 weeks.
If you want to speed up the process you can help with the review process by earning a PAReview bonus.

PS: PAReview means Project Application Review.

Why wait so long?

Posted by dSero on October 24, 2012 at 11:40am

As I wrote in my post, I've made 12 reviews, and my project is eligible for that as well now.
What the community earns from such a long wait? Probably nothing, as the code was reviewed over and over using the new methodology.
6 weeks in internet time is like 7 years in a dog time :-)

Review process

Posted by cubeinspire on October 24, 2012 at 8:12pm

If you have a review bonus you have priority and an administrator will pass ASAP to give you the final validation.
The review process is there to ensure a good quality to the contributed modules released at Drupal.org and had a quite positive feedback on last DrupalCon from the survey made by patrickd.
So lucky dogs don't build modules :°)

Not enough reviewers

Posted by sreynen on October 24, 2012 at 1:30pm

6 weeks is the maximum, not the goal. It's taking that long because we don't have enough people doing reviews. Only a few people have permission to grant Git permissions and move applications from RTBC to fixed, and those people are either not doing reviews, or spending their time doing initial reviews and not looking at the RTBC queue much.

There's a lot of discussion about ways to improve this, but discussion is slow. There's a simple way you can help speed up the process right now: do more reviews. Doing reviews frees up other reviewers to focus on the RTBC queue, and gives you experience that could lead to you doing the final RTBC-to-fixed check yourself.

If you don't have time to do more reviews, that's understandable. But that's the only available fix we have for this problem right now.

There are projects in the

Posted by fuzzy76 on March 6, 2013 at 10:15am

There are projects in the queue right now that have been RTBC for 8 weeks. Has this guideline changed? The PAReview bonus is not a bonus anymore, it seems to be a mandatory requirement.

Modules with an RTBC status

Posted by jthorson on October 24, 2012 at 1:34pm

Modules with an RTBC status still undergo a full review by the git admin before promoting the project, as a second set of eyes looking for any potential security issues and other missed items, so they still take some time to review. The six week auto-promotion step was added to ensure that this final gate could not become a show-stopping bottleneck, as we have less git admins than we have reviewers ... and I think you can appreciate that if we're short on the latter, that is indeed an issue.

I do like the 'pending promotion' idea, and am interested in delving into it a little deeper as part of my attempts to automate as much of the review process as possible.

Another review?

Posted by Michelle on October 25, 2012 at 2:42pm

I have access to promote and was actually planning on going thru the RTBC queue soon until I read this. If I have to review the RTBC apps before promoting, then I'm not going to. I assumed that something marked as ready was actually ready. Is there a queue where all that is needed is to click the buttons to promote?

Michelle

_{My blog, mostly about Drupal: Shell Multimedia}

Skip for admins?

Posted by sreynen on October 25, 2012 at 10:16pm

We're encouraging anyone and everyone to do reviews in the interest of getting more people involved. And because there's a lot of new reviewers doing reviews, we need someone more experienced to double-check those reviews when they're marked RTBC. The actual granting of permissions is pretty quick, so it's probably not worth breaking that out into a separate step.

Maybe we should have a defined process of skipping the post-RTBC double-check if the person who did the original review is someone on the admin list?

This seems like a legitimate

Posted by carwin on October 25, 2012 at 10:31pm

This seems like a legitimate way to expedite the process. I think the double-check is an important safety net for new reviewers. I don't think I've come across many instances of gaping security holes being missed, but it's always possible.

A code review admin has a certain level of clout that I think qualifies for the skipping of the double-check.

I'm not sure exactly what sort of "defined process of skipping the post-RTBC double-check" could be implemented since this seems pretty straightforward:

on admin list? approve.

First, we would have to

Posted by klausi on October 25, 2012 at 11:56pm

First, we would have to update the documentation: http://drupal.org/node/1125818

I also think this is quite a theoretical problem. As I already said I'm ignoring the rule, because I approve applications that I reviewed myself after one week in RTBC with no objections. Most other admins deal with applications that they did not RTBC themselves, so that is not a problem.

We need more admins right now - logicdesign and carwin are in the process of becoming admins. Keep those reviews coming and thanks for your work!

This is a judgement call for

Posted by jthorson on October 26, 2012 at 3:25am

This is a judgement call for the individual git admins ... some preliminary due diligence is still required; essentially to ensure that the application's RTBC status is legit. How deep an individual chooses to go with this due diligence is up to that individual, and will likely vary from project to project.

While I have not taken on the git admin role, I suspect that how deep I would look before promoting a project would depend largely on who provided the RTBC status - much like any other Drupal issue queue, there are individuals whose judgement I implicitly trust (based on past history and experiences); while I might take a closer look if I don't recognize the names of the parties involved in the review or RTBC status ... not only to ensure that the review is complete, but also to seek out potential mentoring opportunities for new reviewers as well.

I already approve

Posted by klausi on October 25, 2012 at 11:41pm

I already approve applications that I RTBC'ed myself after one week when there are no objections. So be patient - the end is near.