18:00 < GaborHojtsy> MEETING TIME :)
18:01 -!- rteijeiro [~rteijeiro@192.165.183.201] has quit [Remote host closed the connection]
18:01 < GaborHojtsy> my local internet connection is flaky for some reason, so would love if someone else does a log too in case I loose some parts
18:01 < GaborHojtsy> penyaskito: can you do that?
18:01 < YesCT> Who tweet pinged?
18:01 < penyaskito> GaborHojtsy: ok
18:02 < GaborHojtsy> who is here for the meeting? attrib, David_Hernandez, jcisio|aw, jsbalsera, likin, robertdbailey, Sutharsan, Sweetchuck, tstoeckler, vijaycs85, weal, YesCT?
18:02 < GaborHojtsy> YesCT: https://twitter.com/gaborhojtsy/status/456454241511411713
18:03 < David_Hernandez> can't working :(
18:03 < tstoeckler> positive
18:03 < penyaskito> o/
18:03 -!- Sutharsan [~sutharsan@46.145.215.206] has quit [Remote host closed the connection]
18:04 < GaborHojtsy> ok, quick announcements and then we do a round of who is working on what and where do you need help :)
18:05 < likin> I am working on  https://drupal.org/node/1987882
18:05 < Druplicon> https://drupal.org/node/1987882 => Convert content_translation routes to a new style controller [#1987882] => 134 comments, 27 IRC mentions
18:05 < likin> It needs review
18:05 < GaborHojtsy> 1. The meetings are now 4pm UTC (not 5pm) as we used to adjust times prior summers, instead of moving 1h later in the summer it stays in the same hour
18:05 < likin> also comments. It contains few @todo items.
18:05 -!- webflo [~Adium@gateway.ueberbit.de] has joined #drupal-i18n
18:05 < GaborHojtsy> 2. The meetings are now every week, attend as you can/want
18:06 < tstoeckler> Re 1. That's starting next week, then? I.e. one hour earlier than now
18:06 < vijaycs85> tstoeckler: :)
18:07 < GaborHojtsy> 3. Some updates happened on http://www.drupal8multilingual.org/, beta blockers got a tab, current sprint issues is the new name for “focus issues”, new favicon to make it easier to find in browser (also applied to twitter, etc);; will keep updating the site with fixes and improvements
18:07 < GaborHojtsy> tstoeckler: no, it will be the same time as this week
18:07 < GaborHojtsy> tstoeckler: the meetings are 5pm UTC in winter time and 4pm UTC in summer time :)
18:07 < tstoeckler> GaborHojtsy: Ahh OK. Right, sorry, DST has got me so confused... sorry for the noise
18:07 < GaborHojtsy> tstoeckler: UTC itself does not do any time adjustment
18:08 < tstoeckler> yeah..., I get it now :-)
18:08 < GaborHojtsy> ok, likin posted a report, who can review https://drupal.org/node/1987882? :)
18:08 < vijaycs85> tstoeckler: come on join me to maintain date module. you can be master on this man!
18:08 < Druplicon> https://drupal.org/node/1987882 => Convert content_translation routes to a new style controller [#1987882] => 134 comments, 28 IRC mentions
18:08 -!- candela [~futuro@22.Red-83-35-137.dynamicIP.rima-tde.net] has joined #drupal-i18n
18:09 < penyaskito> likin: Im not sure if https://drupal.org/node/2224607 (already RTBC) is a duplicated
18:09 < Druplicon> https://drupal.org/node/2224607 => Move all functions from content_translation.pages.inc file to  Drupal\content_translation\Controller\ContentTranslationController class [#2224607] => 34 comments, 15 IRC mentions
18:09 < GaborHojtsy> penyaskito: can you take a closer look then? :)
18:09 -!- pcambra_afk [~pcambra@cpc64804-dals15-2-0-cust215.20-2.cable.virginm.net] has quit [Remote host closed the connection]
18:10 < penyaskito> GaborHojtsy: probably later today, yes
18:10 < GaborHojtsy> penyaskito++
18:10 -!- YesCT|car [~yesct@172.56.12.64] has joined #drupal-i18n
18:10 < GaborHojtsy> penyaskito: ok, you want to go next on what are you working on then?
18:11 < likin> penyaskito: I agree with you. Make comments on an issue.
18:11 < penyaskito> This week I've worked on https://drupal.org/node/2240555, small UX improvement
18:11 < Druplicon> https://drupal.org/node/2240555 => Preselect language when importing translations previously exported [#2240555] => 2 comments, 1 IRC mention
18:11 < penyaskito> (needs review)
18:11 -!- YesCT|car is now known as YesCT_
18:12 -!- YesCT [~YesCT@172.56.12.64] has quit [Quit: Timed out from phone]
18:12 < penyaskito> and also in https://drupal.org/node/2234623, that GaborHojtsy already reviewed and I have to look at it again
18:12 < Druplicon> https://drupal.org/node/2234623 => Move language add logic out of language_save()  [#2234623] => 19 comments, 9 IRC mentions
18:12 -!- YesCT_ is now known as YesCT
18:12 -!- mzgadzaj_ [~mzgadzaj@92.103.57.251] has joined #drupal-i18n
18:12 < tstoeckler> penyaskito: does that need more reviews?
18:13 < penyaskito> tstoeckler: dont think so for the moment
18:13 < GaborHojtsy> penyaskito: the langauge add one seems to be getting there, I think once my concerns are fixed :)
18:13 -!- Sutharsan [~sutharsan@46.145.215.206] has joined #drupal-i18n
18:13 < tstoeckler> awesome
18:14 < GaborHojtsy> penyaskito: the preselect one also looks good except the comment needs updating
18:14 < GaborHojtsy> penyaskito: will post a quick review
18:14 < GaborHojtsy> tstoeckler: want to go next? :)
18:15 < tstoeckler> sure. so there's three issues I worked on at nyccamp:
18:15 < likin> also https://drupal.org/node/1978918
18:15 < Druplicon> https://drupal.org/node/1978918 => Convert locale_translate_import_form to a Controller [#1978918] => 51 comments, 6 IRC mentions
18:15 < tstoeckler> 1. https://drupal.org/node/2183231 that one is nearing completion.
18:15 < Druplicon> https://drupal.org/node/2183231 => Make ContentEntityDatabaseStorage generate static database schemas for content entities [#2183231] => 146  comments, 18 IRC mentions
18:15 -!- mzgadzaj [~mzgadzaj@92.103.57.251] has quit [Ping timeout: 240 seconds]
18:15 < penyaskito> likin: ok
18:15 < GaborHojtsy> tstoeckler: in saying what are you working on that is
18:16 < tstoeckler> there's a bunch of refactoring that we still have to to and add test coverage.
18:16 < tstoeckler> but it could still use some architectural review
18:16 < likin> https://drupal.org/node/1978926 also YesCT has not finished yet.
18:16 < Druplicon> https://drupal.org/node/1978926 => Convert locale_translation_status_form to a Controller [#1978926] => 34 comments, 7 IRC mentions
18:16 < tstoeckler> I worked on https://drupal.org/comment/8682005 with jsbalsera
18:16 < YesCT> ah, yes. then I got tired.
18:17 < tstoeckler> that one needs another fix as well, but seems very close
18:17 < YesCT> likin: I saw a few nits in that.
18:17 -!- mzgadzaj_ [~mzgadzaj@92.103.57.251] has quit [Ping timeout: 276 seconds]
18:17 < jsbalsera> tstoeckler and we will have to work on that again :(
18:17 < tstoeckler> yeah, it seems...
18:18 < tstoeckler> but still, shouldn't be hard
18:18 < jsbalsera> yep
18:18 < YesCT> I had some question on if classes in comments needed complete namespaces everywhere or just in @params and @returns (even if they are mentioned in the  use)
18:18 < YesCT> and there was at least one comment over 80 chars.
18:18 < tstoeckler> and i worked with robertdbailey on https://drupal.org/node/2144413
18:18 < Druplicon> https://drupal.org/node/2144413 => Add config translation support for Text elements with a filter format [#2144413] => 53 comments, 21 IRC mentions
18:19 < tstoeckler> we found a cool solution but still needs a proper patch
18:19 < likin> Are tasks these are need work there?
18:19 < YesCT> you know what might help with those convert to controller issues, is to post a special kind of diff, which takes the hunks removed, and where they are  moved to, takes out any indentation differences and does a git diff color words on them.
18:19 < YesCT> I have to go in with the kid.
18:20 < robertdbailey> tstoeckler: yes, the patch failed in part because some of the tests use the form-field names we changed; so I'm changing those tests and will   resubmit
18:20 < tstoeckler> robertdbailey: awesome!
18:20 < tstoeckler> robertdbailey++
18:21 < GaborHojtsy> robertdbailey++
18:21 < GaborHojtsy> great!
18:21 < Druplicon> A round of applause … *clap* *clap* *clap*
18:21 < robertdbailey> lol thanks
18:21 < GaborHojtsy> tstoeckler: for the first one, can you get plach or someone from the entity team?
18:21 < GaborHojtsy> tstoeckler: sounds like they would be best to review
18:22 < tstoeckler> GaborHojtsy: plach has already reviewed (and also wrote a lot of the code :-)), and @fago reviewed so far. and @sun
18:22 < likin> YesCT++
18:22 < likin> penyaskito++
18:22 < GaborHojtsy> tstoeckler: so berdir is missing from that list then :D
18:22 < GaborHojtsy> tstoeckler: if you want to get competent architecture reviews
18:22 < tstoeckler> Yes, and you perhaps
18:23 < tstoeckler> So maybe after we fix all the stuff from the current round of reviews, berdir can review and then you can RTBC :-P
18:23 < GaborHojtsy> tstoeckler: it flattens me that I keep maintaining this image that I may be able to do architecture reviews on that level >D
18:24 < GaborHojtsy> I’m definitely good for an RTBC :D
18:24 < tstoeckler> Oh come on, don't be so humble. we all know what you're capable of :-)
18:24 < tstoeckler> anyway, yeah will ping berdir
18:25 < GaborHojtsy> tstoeckler: best plan IMHO
18:25 -!- YesCT [~yesct@172.56.12.64] has quit [Ping timeout: 258 seconds]
18:26 < GaborHojtsy> likin: do you have other issues on your list?
18:26 < likin> GaborHojtsy: Not. 
18:26 -!- David_Hernandez [~david@84.127.238.10.static.user.ono.com] has quit [Quit: Leaving]
18:26 < likin> GaborHojtsy: They are almost ready. I am looking for anothers.
18:27 < GaborHojtsy> vijaycs85: can you help with reviews on likin’s conversion patches too?
18:27 < vijaycs85> GaborHojtsy: sure will do
18:27 < vijaycs85> likin: https://drupal.org/node/1978926 ?
18:27 < Druplicon> https://drupal.org/node/1978926 => Convert locale_translation_status_form to a Controller [#1978926] => 34 comments, 8 IRC mentions
18:28 < likin> vijaycs85: I rerolled it and fixed it to pass tests.
18:29 < likin> vijaycs85: Tests are passed.
18:29 < vijaycs85> likin: sure thing. I will give it a go.
18:29 < vijaycs85> likin++
18:29 -!- alexpott [~alexpott@host86-176-255-224.range86-176.btcentralplus.com] has quit [Quit: Leaving...]
18:29 < likin> vijaycs85: Ok. Thank you.
18:29 < likin> vijaycs85++
18:31 < GaborHojtsy> vijaycs85: any other issues you are working on?
18:31 < likin> vijaycs85: the same https://drupal.org/node/1978918
18:31 < Druplicon> https://drupal.org/node/1978918 => Convert locale_translate_import_form to a Controller [#1978918] => 51 comments, 7 IRC mentions
18:31 < vijaycs85> GaborHojtsy: yeah, https://drupal.org/comment/8685961#comment-8685961 got a reroll and needs review.
18:31 -!- jerbob92 is now known as jerbob92-away
18:32 < vijaycs85> Trying to fix the 2 fails at https://drupal.org/comment/8678563#comment-8678563 and been a week now(spending an hour a day :)). 
18:33 < vijaycs85> very close now. but would be great to get GaborHojtsy and anyone interested on it :)
18:33 -!- Sutharsan [~sutharsan@46.145.215.206] has quit [Remote host closed the connection]
18:34 < vijaycs85> once done, will do review of likin issues (https://drupal.org/node/1978926  and https://drupal.org/node/1978918)
18:34 < Druplicon> https://drupal.org/node/1978926 => Convert locale_translation_status_form to a Controller [#1978926] => 34 comments, 9 IRC mentions
18:34 < Druplicon> https://drupal.org/node/1978918 => Convert locale_translate_import_form to a Controller [#1978918] => 51 comments, 8 IRC mentions
18:34 < tstoeckler> robertdbailey: I totally did not see that you already posted that patch. AWESOME. But didn't want to insult you by saying we need a "proper patch",   I really hadn't seen you had posted one already
18:34 < tstoeckler> robertdbailey++
18:34 < robertdbailey> tstoeckler: :) no, it needs repatching
18:34 < robertdbailey> tstoeckler++
18:34 < tstoeckler> robertdbailey: yeah, but still :-)
18:35 < tstoeckler> in case anyone is wondering, vijaycs85 is talking about https://drupal.org/node/2144377 above
18:35 < robertdbailey> I could also use someone to RTBC https://drupal.org/node/1832870 before it doesn't apply again
18:35 < Druplicon> https://drupal.org/node/2144377 => Entity reference always searches node titles in default language only [#2144377] => 122 comments, 16 IRC mentions
18:35 < Druplicon> https://drupal.org/node/1832870 => Only show source translation column if there are 2 or more source languages (more than n/a and the original  language). [#1832870] => 103 comments, 16 IRC mentions
18:35 < tstoeckler> d7-comment-links--
18:35 < GaborHojtsy> vijaycs85: I’ll review your first issue
18:35 < vijaycs85> GaborHojtsy++
18:35 < GaborHojtsy> vijaycs85: after the meeting
18:36 < tstoeckler> robertdbailey: will look at that
18:37 < robertdbailey> tstoeckler: thanks!
18:37 < GaborHojtsy> yay!
18:37  * Druplicon throws confetti
18:38 < GaborHojtsy> penyaskito: I posted a quick review of https://drupal.org/node/2240555 in the meantime
18:38 < Druplicon> https://drupal.org/node/2240555 => Preselect language when importing translations previously exported [#2240555] => 3 comments, 2 IRC mentions
18:38 < GaborHojtsy> attrib: you around?
18:38 < penyaskito> process question: 1832870 has not the sprint tag, should it?
18:38 < penyaskito> does every issue with someone *actually* working on anything be on the sprint?
18:38 < GaborHojtsy> penyaskito: yeah where people are working on things should have sprint
18:39 < GaborHojtsy> penyaskito: we have been relaxed on keeping the sprint tag on issues though where we’ve seen value in trying to pick up issues that had people invested but not actively worked on
18:39 < GaborHojtsy> penyaskito: vijaycs85 pointed out we should not do that and that is true :D
18:41 < GaborHojtsy> penyaskito: so I think we should try to push the sprint issues to completion faster which should help on all fronts :)
18:42 < likin> vijaycs85: Could you set the status -  duplicated for 1987882
18:42 < penyaskito> ok, agreed
18:42 < GaborHojtsy> who was not called to talk about what they worked on?
18:43 < likin>  https://drupal.org/node/1987882
18:43 < Druplicon> https://drupal.org/node/1987882 => Convert content_translation routes to a new style controller [#1987882] => 134 comments, 29 IRC mentions
18:43 < vijaycs85> GaborHojtsy: penyaskito also clean sprint board gives the idea of where to push (i.e. we may have all issues in 'needs review', so we all do review  instead staring fresh one)
18:45 -!- fago [~fago@chello084112182213.1.11.vie.surfer.at] has quit [Ping timeout: 250 seconds]
18:46 < GaborHojtsy> did I miss someone when calling out names? Sweetchuck, webflo, jsbalsera, marthinal, andypost, attrib?
18:47 < tstoeckler> roderik?
18:47 < tstoeckler> Schnitzel?
18:47 < Druplicon> gets shit done
18:47 < tstoeckler> nice... :-D
18:47 < GaborHojtsy> lol >D
18:47 < Sweetchuck> GaborHojtsy: Sorry: Iam busy
18:47 < jsbalsera> GaborHojtsy I was only working in the issue that tstoeckler talked about :-)
18:47 < GaborHojtsy> Sweetchuck: np!
18:48 < attrib> i'm reading, but not really here :P
18:48 < jsbalsera> I hope to finish it soon!
18:48 < tstoeckler> jsbalsera++
18:50 < GaborHojtsy> jsbalsera++
18:51 < GaborHojtsy> ok, if nobody missed, who needs more reviews on their work or more issues to look at in general?
18:53 -!- jlbellido [~lakatos@85.136.216.251.dyn.user.ono.com] has joined #drupal-i18n
18:53 < jlbellido> Hi everyone!
18:53 < GaborHojtsy> jlbellido: hi, you are just coming to the end of the D8MI meeting :)
18:53 < GaborHojtsy> jlbellido: are you working on issues? :)
18:54 < jlbellido> no, sorry GaborHojtsy
18:54 < jlbellido> :(
18:54 < penyaskito> jlbellido: but you want one ;)
18:55 < roderik> GaborHojtsy tstoeckler: hi. Just read through here. Will resume work on self-assigned issue before the weekend.
18:55 < jlbellido> if you have work for me, i'm novice
18:55 < roderik> Nothing much else is gonna come out of me
18:55 < jsbalsera> jlbellido++
18:55 < tstoeckler> roderik: awesome. can you post the issue link?
18:56 < roderik> https://drupal.org/node/2068331
18:56 < Druplicon> https://drupal.org/node/2068331 => Convert comment SQL queries to the Entity Query API [#2068331] => 65 comments, 3 IRC mentions
18:56 < tstoeckler> roderik: nice one!!!
18:56 < roderik> the last needs-work one from https://drupal.org/node/2068325
18:56 < Druplicon> https://drupal.org/node/2068325 => [META] Convert entity SQL queries to the Entity Query API [#2068325] => 32 comments, 11 IRC mentions
18:56 < tstoeckler> roderik++
18:57 < tstoeckler> need any reviews, help, etc?
18:57 < roderik> tstoeckler: The Node one from that Meta still needs review: https://drupal.org/node/2068333
18:57 < Druplicon> https://drupal.org/node/2068333 => Convert node SQL queries to the Entity Query API [#2068333] => 54 comments, 2 IRC mentions
18:57 < tstoeckler> roderik: yes, saw that one. wanted to look into that anyway...
18:58 < roderik> further: nah, will just finish what I have here since DDD (take a detour around tracker and then come back to comment). Needs review then.
18:58 < tstoeckler> nice
18:58 < GaborHojtsy> jlbellido: I think you’ll be able to help review https://drupal.org/node/2240463 one balagan posts updated fixes
18:58 < Druplicon> https://drupal.org/node/2240463 => Text says languages enabled, whereas they are not enabled but added [#2240463] => 6 comments, 2 IRC mentions
18:59 < GaborHojtsy> jlbellido: that one involved text fixes which should be easier to review :)
18:59 < jlbellido> Ok GaborHojtsy tanks! I'll review it as soon as i can
18:59 < jlbellido> :D
18:59 < jlbellido> GaborHojtsy++
19:01 < jsbalsera> Sorry guys, have to leave! Bye!
19:01 < GaborHojtsy> jsbalsera++
19:02 -!- jsbalsera [~jsanchez@cocolnx06.cocomore.com] has quit [Quit: Leaving]
19:02 < GaborHojtsy> for the end of the meeting, wanted to plug in http://2014.drupalcamp.es/sprints :)
19:02 < penyaskito> GaborHojtsy++
19:02 < GaborHojtsy> join the D8MI sprint in Valencia mid-May even if you are new and need to get mentored :)
19:03 < GaborHojtsy> and that’s it for the meeting, thanks all for coming
19:03 < GaborHojtsy> penyaskito++
19:03 < GaborHojtsy> jlbellido++
19:03 < GaborHojtsy> tstoeckler++
19:03 < tstoeckler> wait, i want to add one thing, too
19:03 < GaborHojtsy> roderik++
19:03 < GaborHojtsy> tstoeckler: sure!
19:03 < tstoeckler> rodrigoaguilera++
19:03 < tstoeckler> Outi++
19:03 < tstoeckler> balagan++
19:03 < tstoeckler> https://drupal.org/node/2017475
19:03 < Druplicon> https://drupal.org/node/2017475 => Multilingual tour for interface translation section [#2017475] => 36 comments, 7 IRC mentions
19:03 < robertdbailey> GaborHojtsy++
19:03 < tstoeckler> that's it :-)
19:03 < robertdbailey> tstoeckler++
19:04 < GaborHojtsy> rodrigoaguilera++
19:04 < GaborHojtsy> Outi++
19:04 < GaborHojtsy> balagan++
19:04 < GaborHojtsy> robertdbailey++
19:04 < tstoeckler> GaborHojtsy++
19:04 -!- Sweetchuck [~quassel@5400AFBA.dsl.pool.telekom.hu] has quit [Ping timeout: 265 seconds]
19:04 < GaborHojtsy> attrib++
19:04 < GaborHojtsy> likin++
19:04 < penyaskito> andreimarius++
19:04 < penyaskito> likin++
19:04 < penyaskito> karma rain!
19:04 < Druplicon> Druplicon++
19:05 < GaborHojtsy> YesCT++
19:05 < GaborHojtsy> vijaycs85++
19:05 < GaborHojtsy> weal++
19:05 < vijaycs85> GaborHojtsy++
19:05 < vijaycs85> YesCT++
19:05 < vijaycs85> tstoeckler++
19:05 < GaborHojtsy> I think I got all :)
19:05 < vijaycs85> likin++
19:05 < vijaycs85> robertdbailey++
19:05 < tstoeckler> vijaycs85++
19:05 < vijaycs85> jlbellido++
19:05 < GaborHojtsy> so next meeting is next week Wed same time (6pm CEST, 4pm UTC)
19:05 < tstoeckler> roderik++
19:05 < GaborHojtsy> and then every week same time :)
19:05 < vijaycs85> roderik++
19:05 < tstoeckler> consistency++
19:05 < vijaycs85> penyaskito++
19:06 < tstoeckler> dst--
19:06  * penyaskito stops logging here, karma rain can continue anyway