[6:01pm] penyaskito: Hi all :)
[6:01pm] vijaycs85: penyaskito: hey
[6:01pm] GaborHojtsy: HEY!
[6:01pm] Druplicon: privet
[6:01pm] GaborHojtsy: meeting time!
[6:02pm] GaborHojtsy: who is here? attrib David_Hernandez, jsbalsera, ksenzee, pcambra, reyero (hey!), robertdbailey, Schnitzel, tstoeckler, weal, YesCT?
[6:02pm] GaborHojtsy: also who did I forget from those who did not say hi yet? :D
[6:02pm] robertdbailey: hi everybody
[6:04pm] penyaskito: webflo: :)
[6:05pm] YesCT: me
[6:06pm] GaborHojtsy: hey!
[6:06pm] roderik joined the chat room.
[6:06pm] GaborHojtsy: all righto, some short news
[6:07pm] GaborHojtsy: one of our WSCII conversion issues got in!
[6:07pm] GaborHojtsy: https://drupal.org/node/2224607
[6:07pm] Druplicon: https://drupal.org/node/2224607 => Move all functions from content_translation.pages.inc file to Drupal\content_translation\Controller\ContentTranslationController class [#2224607] => 37 comments, 19 IRC mentions
[6:07pm] GaborHojtsy: wait, it was marked duplicate :P
[6:07pm] GaborHojtsy: at least we can focus on https://drupal.org/node/1987882
[6:07pm] YesCT: Javisr: marthinal: ricardoamaro: d8mi meeting. :)
[6:07pm] Druplicon: https://drupal.org/node/1987882 => Convert content_translation routes to a new style controller [#1987882] => 150 comments, 39 IRC mentions
[6:07pm] GaborHojtsy: however https://drupal.org/node/2017475 was committed, yay!
[6:07pm] Druplicon: https://drupal.org/node/2017475 => Multilingual tour for interface translation section [#2017475] => 36 comments, 8 IRC mentions
[6:08pm] GaborHojtsy: also a beta blocker at https://drupal.org/node/2234623
[6:08pm] Druplicon: https://drupal.org/node/2234623 => Move language add logic out of language_save()  [#2234623] => 40 comments, 21 IRC mentions
[6:08pm] GaborHojtsy: which was a blocker for CMI language deployment and migrate as well
[6:08pm] dasrecht is now known as dasrecht_off.
[6:08pm] GaborHojtsy: alexpott++
[6:08pm] GaborHojtsy: penyaskito++
[6:08pm] GaborHojtsy: tstoeckler++
[6:09pm] GaborHojtsy: I’ve added more of the sprints in the sidebar and calendar at http://www.drupal8multilingual.org/events
[6:10pm] GaborHojtsy: also started tweeting with concrete people attending, to get more attention for the events
[6:10pm] GaborHojtsy: eg. the sprint on the weekend
[6:10pm] GaborHojtsy: please keep these coming! any sprints not included there?
[6:10pm] vijaycs85: GaborHojtsy++
[6:10pm] vijaycs85: GaborHojtsy++
[6:10pm] vijaycs85: GaborHojtsy++
[6:11pm] YesCT: oh, I forgot to make an event for my little local one. http://www.meetup.com/vopdug/events/162917952/
[6:11pm] • YesCT makes a g.d.o event now.
[6:12pm] vijaycs85: GaborHojtsy: we got one in London this weekend... not sure how much D8MI will be involved
[6:12pm] GaborHojtsy: vijaycs85: yeah we’d need at lease one person from D8MI fame there to credibly be able to say its a D8MI sprint :D
[6:12pm] GaborHojtsy: penyaskito suggested we make more noise about the sprints which is IMHO a great idea
[6:13pm] tstoeckler: yes
[6:13pm] tstoeckler: penyaskito++
[6:14pm] mzgadzaj left the chat room. (Ping timeout: 252 seconds)
[6:15pm] GaborHojtsy: YesCT: added event in calendar and the site at http://www.drupal8multilingual.org/events
[6:16pm] GaborHojtsy: YesCT: I hope I got the timezones right >D
[6:16pm] vijaycs85: penyaskito++
[6:16pm] YesCT: https://groups.drupal.org/node/419708
[6:16pm] Druplicon: https://groups.drupal.org/node/419708 => Mini-Sprint in Oak Park at Maze library => 0 comments, 1 IRC mention
[6:16pm] gloob joined the chat room.
[6:16pm] GaborHojtsy: in other news I fixed http://www.drupal8multilingual.org/team by fixing rocketship so now all 1029 contributors including Holly Ros are now listed again :)
[6:17pm] GaborHojtsy: Holly Ross that is
[6:17pm] YesCT: GaborHojtsy: yes. timezone is correct.
[6:18pm] GaborHojtsy: finally, Amsterdam started their con promotion and session submissions
[6:18pm] GaborHojtsy: https://amsterdam2014.drupal.org/sprints is also published
[6:18pm] GaborHojtsy: mark your calendars :)
[6:18pm] GaborHojtsy: thats it for announcement, now your turn, what did you work on? what do you need help with?
[6:18pm] GaborHojtsy: YesCT wanna start?
[6:19pm] YesCT: I'm just going through my gmail list of issues, trying to catch up on status of issues.
[6:19pm] YesCT: alpha 11 is out.
[6:19pm] YesCT: so we are out of our critical/major only restriction
[6:19pm] YesCT: and into "disruptive" patch window.
[6:20pm] tstoeckler: oohh awesome, didn't realize that
[6:20pm] tstoeckler: nice
[6:20pm] tstoeckler: alpha++
[6:20pm] YesCT: so. if anyone has anything that is not critical or major, and will effect many things, the next 2 or 3 days is your chance.
[6:20pm] GaborHojtsy: yeah http://drupalcode.org/project/drupal.git/shortlog/refs/tags/8.0-alpha11 7 hours ago
[6:20pm] YesCT: if anyone has anything like that that needs rerolled or reviewed, please post a link.
[6:20pm] webflo left the chat room. (Quit: Leaving.)
[6:20pm] YesCT: I want to focus on anything people worked on at dev days that is needing review.
[6:21pm] YesCT: so we can actually sprint on issues on our sprint board and get those issue off of there.
[6:21pm] YesCT: focus?
[6:21pm] Druplicon: No interrupting the developer: http://themetapicture.com/this-is-why-you-shouldnt-interrupt-a-programmer/ Also: d8mi focus: http://www.drupal8multilingual.org/issues/focus See also: d8mi?, entity and fieldapi focus: http://entity.worldempire.ch/, CMI focus: http://drupal8cmi.org/, Doc priorities https://drupal.org/node/1005304, Twig focus: http://drupaltwig.org/issues/focus
[6:22pm] YesCT: I have a pet project https://drupal.org/node/2239497
[6:22pm] Druplicon: https://drupal.org/node/2239497 => [Meta] Fix ConfigurableLanguageManager getLanguages() [#2239497] => 16 comments, 8 IRC mentions
[6:22pm] YesCT: especially https://drupal.org/node/2246679
[6:22pm] Druplicon: https://drupal.org/node/2246679 => Rename Language module's LanguageInterface to ConfigurableLanguageInterface and make it extend Core's LanguageInterface [#2246679] => 17 comments, 4 IRC mentions
[6:23pm] YesCT: which is born out of trying to get https://drupal.org/node/2107427 to pass.
[6:23pm] Druplicon: https://drupal.org/node/2107427 => Regression: Language names should display in their native names in the language switcher block [#2107427] => 94 comments, 39 IRC mentions
[6:23pm] Javisr_ joined the chat room.
[6:23pm] YesCT: it had a work around, adding a new core component sort, .. but that's not really the right way to get that working.
[6:24pm] tstoeckler: YesCT: yeah, I wanted to RTBC that but it needs a reroll.
[6:24pm] YesCT: needs https://drupal.org/node/2239399 I think
[6:24pm] Druplicon: https://drupal.org/node/2239399 => Languages should be sorted by label instead of title [#2239399] => 9 comments, 8 IRC mentions
[6:25pm] webflo joined the chat room.
[6:25pm] YesCT: so that one needs tests.
[6:25pm] YesCT: needs tests?
[6:25pm] Druplicon: Find issues needing automated tests with http://goo.gl/yJvxx. And instructions on how to write tests are at https://drupal.org/contributor-tasks/write-tests
[6:26pm] penyaskito: I will work on #2239399
[6:26pm] GaborHojtsy: YesCT: those are good and http://www.drupal8multilingual.org/issues/focus has some good ones, eg. the label one indeed, the langauges enabled/disabled novice text review you can bring to the weekend, etc.
[6:26pm] GaborHojtsy: penyaskito: yay!
[6:26pm] YesCT: penyaskito: super. be aware also https://drupal.org/node/2151223
[6:26pm] Druplicon: https://drupal.org/node/2151223 =>  Add a method to SortArray to sort by weight and title [#2151223] => 14 comments, 5 IRC mentions
[6:26pm] GaborHojtsy: penyaskito: wanna go next, I’ve seen the migrate patch just landed minutes ago :D big accomplishment :)
[6:27pm] YesCT: might need similar tests.
[6:27pm] vijaycs85: penyaskito++
[6:27pm] GaborHojtsy: penyaskito++
[6:27pm] GaborHojtsy: penyaskito: wanna go next?
[6:28pm] penyaskito: last week I worked on https://drupal.org/node/2234623
[6:28pm] Druplicon: https://drupal.org/node/2234623 => Move language add logic out of language_save()  [#2234623] => 40 comments, 22 IRC mentions
[6:29pm] penyaskito: and now I should focus on migrate multilingual D6 sites again, but will try to help on the language switcher issue childs too
[6:29pm] penyaskito: that one is standing on the board longer than I expected
[6:30pm] penyaskito: next :)
[6:30pm] David_Hernandez left the chat room. (Quit: Leaving)
[6:31pm] vijaycs85: tstoeckler: you next boss?
[6:31pm] tstoeckler: sure :-)
[6:31pm] GaborHojtsy: tstoeckler: !
[6:31pm] tstoeckler: so I worked primarily on https://drupal.org/node/2183231
[6:32pm] Druplicon: https://drupal.org/node/2183231 => Make ContentEntityDatabaseStorage generate static database schemas for content entities [#2183231] => 189 comments, 23 IRC mentions
[6:32pm] tstoeckler: didn't get as far as I wanted, but will spend some time now to get that into shape.
[6:32pm] tstoeckler: https://drupal.org/node/2209981 could use review, it's a soft blocker of that one
[6:32pm] Druplicon: https://drupal.org/node/2209981 => ConfigurableEntityReferenceItem should not mess with the field schema [#2209981] => 30 comments, 2 IRC mentions
[6:33pm] tstoeckler: and should be easy to review, because alexpott only complained about missing test coverage and now I added tests :-)
[6:33pm] • vijaycs85 seeing the word schema there
[6:33pm] tstoeckler: other than that worked with jsbalsera on https://drupal.org/node/2143729
[6:33pm] Druplicon: https://drupal.org/node/2143729 => Regression: Entity definitions miss a language entity key [#2143729] => 91 comments, 11 IRC mentions
[6:33pm] tstoeckler: vijaycs85: not your type of schema, sorry
[6:33pm] tstoeckler: :-)
[6:33pm] GaborHojtsy: vijaycs85: that would be SQL schema :)
[6:33pm] vijaycs85: tstoeckler: :d
[6:33pm] tstoeckler: vijaycs85: but do feel free to review :-)
[6:33pm] alexpott left the chat room. (Quit: Leaving...)
[6:34pm] tstoeckler: got 2143729 down to 3 fails, sadly not green yet.
[6:34pm] GaborHojtsy: tstoeckler: thats a good one though, sounds like you are getting close?
[6:34pm] tstoeckler: yeah, it was green. and then i adressed some architectural concerns and apparently broke something
[6:35pm] tstoeckler: shouldn't be too hard fixing those tests but I have a hard time allocating time atm
[6:35pm] tstoeckler: didn't really get to https://drupal.org/node/2144413 but that's nr 3 on my list
[6:35pm] Druplicon: https://drupal.org/node/2144413 => Add config translation support for Text elements with a filter format [#2144413] => 55 comments, 22 IRC mentions
[6:35pm] tstoeckler: really want to make progress on that this week
[6:35pm] tstoeckler: that's about it
[6:36pm] robertdbailey: tstoeckler: yes, help on that.  I'm a bit stuck there because the tests aren't failing locally for me
[6:36pm] tstoeckler: robertdbailey: yeah, saw that. didn't get to trying it myself yet. sry
[6:37pm] GaborHojtsy: robertdbailey: that would be a great one to get moving though :)
[6:37pm] GaborHojtsy: robertdbailey: wanna go next?
[6:37pm] robertdbailey: sure
[6:38pm] robertdbailey: the other issue I was working on was https://drupal.org/node/1832870 (coding up @tstoeckler's suggested changes)
[6:38pm] Druplicon: https://drupal.org/node/1832870 => Only show source translation column if there are 2 or more source languages (more than n/a and the original language). [#1832870] => 105 comments, 23 IRC mentions
[6:38pm] GaborHojtsy: robertdbailey: that needs reviews now?
[6:38pm] franSeva joined the chat room.
[6:39pm] robertdbailey: GaborHojtsy: not yet, I've just been trying to consolidate down to one for-loop, to see what that would look like
[6:39pm] GaborHojtsy: robertdbailey: ok, I hope YesCT can help with reviews as needed :)
[6:39pm] robertdbailey: tstoeckler: not sure that is worth it, but I thought I'd give it a try
[6:39pm] robertdbailey: wrt reviews, I also read all the docs on reviewing that @YesCT sent over and then looked through a bunch of reviews to get a feel for them.
[6:40pm] tstoeckler: robertdbailey: yeah, that would be cool. but don't spend too much time on that, it's nice to have but not really a blocker in any sense of the word
[6:40pm] YesCT: robertdbailey: yes, I'm familiar with that issue and can help.
[6:40pm] Druplicon: YesCT: 2 min 10 sec ago <filijonka|afk> tell YesCT I’ll be back soon. need some food
[6:40pm] robertdbailey: tstoeckler: ok cool, I'll try to get it tested and submitted today
[6:41pm] robertdbailey: cool
[6:41pm] YesCT: tstoeckler: robertdbailey: yeah, it's not critical... it's just one of those things we have had so many people work on, that would be good to just get it in.
[6:41pm] YesCT: and be done.
[6:41pm] tstoeckler: YesCT: yes, the issue is definitely important!! I just meant one of my review points, which is sort of "optional" to fix
[6:41pm] tstoeckler: sry for the confusion
[6:42pm] YesCT: completely optional. :) except for my sanity.
[6:43pm] • vijaycs85 added sprint tag for 1832870 to make to sprint board
[6:43pm] robertdbailey: I think that's all for me
[6:43pm] GaborHojtsy: cool
[6:43pm] GaborHojtsy: thanks!
[6:43pm] GaborHojtsy: vijaycs85: wanna go next?
[6:43pm] • tstoeckler tags YesCT's sanity as "revisit before release"
[6:44pm] vijaycs85: GaborHojtsy: sure
[6:44pm] GaborHojtsy: :D
[6:44pm] vijaycs85: I got 4 items in my list:
[6:44pm] vijaycs85: 1. we got a new meta for missing schema - https://drupal.org/node/2231059  and added sub-tasks.
[6:44pm] Druplicon: https://drupal.org/node/2231059 => [meta] Find out what config schemas are still missing and add them [#2231059] => 17 comments, 10 IRC mentions
[6:44pm] YesCT: (it's really that I dont want so many new people to feel like their work was not appreciated)
[6:45pm] YesCT: vijaycs85: I had questions about reviewing that and posted a new patch on the meta just a bit ago.
[6:45pm] vijaycs85: YesCT: yeah, I was about to reply back yesterday.. but missed in the middle of views area plugin... I will update today.
[6:45pm] vijaycs85: YesCT: hope your questions are in language sub-task
[6:46pm] YesCT: I'm going to post the error producing patch on the language one, and a combined patch.
[6:46pm] vijaycs85: YesCT: I was thinking to add some tests specific to language and content_translation as the condition in meta can't make it to any patch
[6:46pm] vijaycs85: YesCT:but for testing, sure, we can add it
[6:47pm] YesCT: vijaycs85: and we have those good review instructions from the old meta. we should copy those over and improve them on this one (if you think it would be appropriate)
[6:47pm] vijaycs85: YesCT: yeah surely it helps..
[6:48pm] vijaycs85: 2. Reviewed views area plugin issue - https://drupal.org/node/2246557
[6:48pm] Druplicon: https://drupal.org/node/2246557 => Missing schema for entity area plugin [#2246557] => 11 comments, 7 IRC mentions
[6:48pm] GaborHojtsy: YesCT: vijaycs85: yeah the config inspector may need some updates to make it work with D8 head
[6:49pm] GaborHojtsy: I think reyero wanted to work on that but not immediately, so we may still need to figure that out now
[6:49pm] vijaycs85: GaborHojtsy: yep, it's been a while since we used...
[6:49pm] • vijaycs85 expects to open few more issues on inspector
[6:50pm] vijaycs85: 3. First-subtask needs review - https://drupal.org/node/2245721 - We discussed this as part of #1.
[6:50pm] Druplicon: https://drupal.org/node/2245721 => Add missing configuration schema in language component [#2245721] => 2 comments, 3 IRC mentions
[6:51pm] vijaycs85: 4. Spend some time on few VDC issues (https://drupal.org/node/1857256 and https://drupal.org/node/1986606)
[6:51pm] Druplicon: https://drupal.org/node/1857256 => Convert the taxonomy listing and feed at /taxonomy/term/%term to Views [#1857256] => 112 comments, 13 IRC mentions
[6:51pm] Druplicon: https://drupal.org/node/1986606 => Convert the comments administration screen to a view [#1986606] => 108 comments, 17 IRC mentions
[6:51pm] YesCT: vijaycs85: what was that issue we did a hangout about? with the crazy errors due to the weird tests?
[6:52pm] vijaycs85: YesCT: ahh that one... I give up
[6:52pm] • vijaycs85 looking for the nid
[6:53pm] vijaycs85: YesCT: https://drupal.org/node/2144377
[6:53pm] Druplicon: https://drupal.org/node/2144377 => Entity reference always searches node titles in default language only [#2144377] => 127 comments, 22 IRC mentions
[6:53pm] GaborHojtsy: vijaycs85: yay, those VDC issues will be a boon for D8MI too to customize and languageify those pages :)
[6:53pm] YesCT: so.
[6:53pm] • GaborHojtsy loves mutual benefits
[6:54pm] GaborHojtsy: omg the entity refeence issue :D
[6:54pm] YesCT: I looked deep into 2144377 also with vijaycs85, so if anyone can pick that up, I can ... uh, be a rubberduck for it since I'm familiar with it.
[6:54pm] vijaycs85: GaborHojtsy: :D
[6:54pm] YesCT: we need someone with super skills for weird errors and debugging and stuffs.
[6:54pm] YesCT: maybe .. tstoeckler when he wants to take time off of other priority stuff and play with something difficult.
[6:55pm] GaborHojtsy: yeah York and the two folks from Vienna (ti2m and k4v) all gave up on it… and this is even the simpler version where we skip considering some real world scenarios
[6:55pm] • tstoeckler is afraid of the implications of people thinking he has "super skills for weird errors and debugging and stuffs"
[6:55pm] vijaycs85: tstoeckler: if you agree, I can help with any of your issue.. may be review or reroll etc...
[6:55pm] GaborHojtsy: tstoeckler does have those :D
[6:55pm] tstoeckler: yeah, I'll have a look.
[6:56pm] tstoeckler: well, I also have dawehner on my company chat, so... :-)
[6:56pm] YesCT: tstoeckler: wait till you see the tests there, talk about crazy arrays.
[6:56pm] tstoeckler: vijaycs85: OK, you fix the tests from https://drupal.org/node/2143729 then i'll look at the ER one
[6:56pm] Druplicon: https://drupal.org/node/2143729 => Regression: Entity definitions miss a language entity key [#2143729] => 91 comments, 12 IRC mentions
[6:56pm] vijaycs85: tstoeckler++
[6:56pm] YesCT: oh, if only we could meet for an evening and just look at it with the 4 of us! fun!
[6:57pm] tstoeckler: vijaycs85++
[6:57pm] • vijaycs85 loves mutual benefits too
[6:57pm] vijaycs85: tstoeckler++
[6:57pm] tstoeckler: drupal-tests--
[6:58pm] webflo left the chat room. (Ping timeout: 252 seconds)
[6:59pm] tstoeckler: YesCT: yes, that's true :-)
[6:59pm] vijaycs85: finally, would like to give some special credits to GaborHojtsy and penyaskito for making weekly meeting interesting and alarmed
[7:00pm] YesCT: GaborHojtsy++
[7:00pm] YesCT: penyaskito++
[7:00pm] webflo joined the chat room.
[7:00pm] GaborHojtsy: YesCT: yeah not very soon
[7:00pm] YesCT: yeah we should all watch as penyaskito is rocketing on so many good notable fronts.
[7:00pm] tstoeckler: Yes!!! absolutely!
[7:00pm] tstoeckler: GaborHojtsy++
[7:00pm] GaborHojtsy: :)
[7:00pm] vijaycs85: GaborHojtsy++
[7:01pm] tstoeckler: GaborHojtsy++
[7:01pm] tstoeckler: penyaskito++
[7:01pm] tstoeckler: penyaskito++
[7:01pm] vijaycs85: penyaskito++
[7:01pm] GaborHojtsy: ok, did we miss someone to say what they are working on?
[7:01pm] GaborHojtsy: I see you are int he mood to close the meeting? :D
[7:01pm] vijaycs85: :d
[7:01pm] tstoeckler: meeting-closing++
[7:01pm] jsbalsera: GaborHojtsy franSeva is working in one issue
[7:01pm] jsbalsera: but he is a little bit shy :P
[7:01pm] franSeva: I'm novice :(
[7:01pm] GaborHojtsy: YesCT++
[7:01pm] tstoeckler: is franSeva *the* fran?
[7:01pm] YesCT: franSeva++
[7:02pm] GaborHojtsy: penyaskito++
[7:02pm] GaborHojtsy: tstoeckler++
[7:02pm] robertdbailey: penyaskito++
[7:02pm] jsbalsera: 1533250?
[7:02pm] GaborHojtsy: robertdbailey++
[7:02pm] GaborHojtsy: vijaycs85++
[7:02pm] franSeva: I was waiting to talk
[7:02pm] Sutharsan joined the chat room.
[7:02pm] robertdbailey: tstoeckler++
[7:02pm] tstoeckler: franSeva: go for it! :-)
[7:02pm] robertdbailey: YesCT++
[7:02pm] vijaycs85: GaborHojtsy++
[7:02pm] GaborHojtsy: franSeva: hey, sure what are you working on?
[7:02pm] vijaycs85: YesCT++
[7:02pm] robertdbailey: GaborHojtsy++
[7:02pm] vijaycs85: jsbalsera++
[7:02pm] YesCT: 1533250
[7:02pm] vijaycs85: robertdbailey++
[7:02pm] Druplicon: https://drupal.org/node/1533250 => Make locale module pass Coder Review [#1533250] => 23 comments, 1 IRC mention
[7:02pm] vijaycs85: franSeva++
[7:02pm] franSeva: I'm working in coder review
[7:02pm] franSeva: but I have some question related with the tests for locale
[7:02pm] vijaycs85: D8MI++
[7:02pm] robertdbailey: vijaycs85++
[7:03pm] jsbalsera: franSeva++
[7:03pm] franSeva: I'm not sure if I need to have a configured enviroment to run the test
[7:03pm] vijaycs85 left the chat room.
[7:03pm] franSeva: I commented it in the issue few days ago
[7:04pm] tstoeckler: franSeva: can you be more specific about what you mean with configuration of the locale module in your environment?
[7:04pm] franSeva: yep
[7:05pm] franSeva: I made a patch with all the changes reported by phpcs
[7:05pm] Sutharsan left the chat room. (Remote host closed the connection)
[7:05pm] franSeva: but the patchs fails..
[7:05pm] YesCT: (other fran might have been grisendo https://drupal.org/user/848238)
[7:05pm] tstoeckler: and can you reprodice thode fails?
[7:05pm] franSeva: To try to fix it I review the tests logs
[7:06pm] tstoeckler: YesCT: yes, I just realized that as well. franSeva != grisendo :-)
[7:06pm] tstoeckler: franSeva: ok, so far so good
[7:06pm] GaborHojtsy: franSeva: you don’t need anything special setup locally to run the tests
[7:06pm] franSeva: ok
[7:06pm] GaborHojtsy: franSeva: the test framework is included with Drupal
[7:07pm] franSeva: I know it
[7:07pm] franSeva: but reviewing the code
[7:07pm] GaborHojtsy: franSeva: just enable the testing module, go to Configure > Devel > Testing and pick a test that fails on the issue and run only that one
[7:07pm] pcambra left the chat room. (Remote host closed the connection)
[7:07pm] GaborHojtsy: franSeva: running ALL of them would be way too long
[7:07pm] franSeva: I see that one test fails because one button it's not being rendered
[7:07pm] GaborHojtsy: franSeva: then you’ll see more debug info locally as to what is going on
[7:07pm] YesCT: well franSeva might be talking about running coder review...
[7:07pm] pcambra joined the chat room.
[7:08pm] GaborHojtsy: franSeva: looking at your patch you may have renamed something somewhere but not all uses for example
[7:08pm] • YesCT looks at the issue
[7:08pm] tstoeckler: franSeva: so what happened is that you switched the order of arguments in the locale_translation_batch_status_check() function, but I think you didn't update all of the usages of that function
[7:08pm] franSeva: GarborHojtsy: ok, I'll check it
[7:09pm] tstoeckler: franSeva: i.e. you need to search for locale_translation_batch_status_check( in the codebase and then wherever that function is called switch the arguments as well.
[7:09pm] YesCT: (oh I see)
[7:09pm] tstoeckler: i.e. locale_translation_batch_status_check($project, $langcode, $options, $context); to locale_translation_batch_status_check($project, $langcode, $context, $options);
[7:09pm] franSeva: tsloeckler: ok, I'm go to check it againg
[7:10pm] franSeva: yes
[7:10pm] franSeva: I did this
[7:10pm] tstoeckler: awesome!
[7:10pm] GaborHojtsy: franSeva++
[7:10pm] GaborHojtsy: superb!
[7:10pm] franSeva: tstoeckler: I see the error
[7:10pm] GaborHojtsy: anybody else we missed? :) jsbalsera yourself? :)
[7:10pm] tstoeckler: franSeva: hmm because I don't see the usages being updated in the patch
[7:10pm] franSeva: I change the order becauser the not mandatory param must be at the end
[7:10pm] jsbalsera: Nothing to say today, GaborHojtsy :( Last week wasn't productive at all.
[7:10pm] tstoeckler: franSeva: right
[7:11pm] tstoeckler: franSeva: let's let them close the meeting and we can chat in a minute
[7:11pm] franSeva: tstoeckler: ok
[7:11pm] GaborHojtsy: jsbalsera: maybe the language entity key issue should not be assigned to you then or are you getting back to that?
[7:12pm] pcambra left the chat room. (Ping timeout: 240 seconds)
[7:13pm] jsbalsera: GaborHojtsy yep, I hope so.
[7:13pm] jsbalsera: I was working on it this week but I got stucked, and I had to dig into https://drupal.org/node/2182239 to understand what Berdir was asking to do.
[7:13pm] Druplicon: https://drupal.org/node/2182239 => Improve ContentEntityBase::id() for better DX [#2182239] => 86 comments, 15 IRC mentions
[7:14pm] tstoeckler: jsbalsera: I just told vijaycs85 to take a look at that issue, perhaps you should coordinate with him so as not to duplicate work
[7:14pm] jsbalsera: ok, tstoeckler. Perhaps I step back for now, but I'll follow it :)
[7:14pm] tstoeckler: jsbalsera: awesome, i'm not 100% sure I implemented Berdir's suggestion correctly, so if you have insights on that please share them
[7:15pm] tstoeckler: jsbalsera: well, maybe you can look at whether my interdiff makes sense?!
[7:15pm] jsbalsera: sure
[7:16pm] GaborHojtsy: jsbalsera: tstoeckler yay!
[7:17pm] GaborHojtsy: cool
[7:17pm] GaborHojtsy: all right then, thats it for the meeting
[7:17pm] GaborHojtsy: next one next week same time
[7:17pm] penyaskito: I would like to add something :)
[7:17pm] GaborHojtsy: if you need issues, http://www.drupal8multilingual.org/issues/betablockers has some and http://www.drupal8multilingual.org/issues/focus always needs reviews :D
[7:17pm] GaborHojtsy: penyaskito: sure!
[7:18pm] penyaskito: Remember http://www.drupal8multilingual.org/events, would be great to see D8MI everywhere... and if not, would be awesome if we try to be online for helping remotely :)
[7:18pm] GaborHojtsy: yupyup!
[7:19pm] penyaskito: EOM
[7:19pm] GaborHojtsy: thanks all for coming to the meeting again
[7:19pm] GaborHojtsy: jsbalsera++
[7:19pm] penyaskito: reyero: welcome back :)
[7:19pm] GaborHojtsy: (the only one I missed above I think :))
[7:19pm] GaborHojtsy: reyero: even if lurking for a start :D
[7:19pm] YesCT: GaborHojtsy++
[7:19pm] YesCT: penyaskito++
[7:20pm] GaborHojtsy: reyero++
[7:20pm] YesCT: tstoeckler++
[7:20pm] YesCT: reyero++
[7:20pm] tstoeckler: reyero++
[7:20pm] tstoeckler: reyero++
[7:20pm] tstoeckler: GaborHojtsy++
[7:20pm] YesCT: vijaycs85++
[7:20pm] YesCT: jsbalsera++
[7:20pm] jsbalsera: YesCT++
[7:20pm] jsbalsera: tstoeckler
[7:20pm] YesCT: franSeva++
[7:20pm] jsbalsera: tstoeckler++
[7:20pm] jsbalsera: GaborHojtsy++
[7:20pm] jsbalsera: penyaskito++
[7:20pm] tstoeckler: YesCT++
[7:20pm] YesCT: robertdbailey++
[7:21pm] jsbalsera: reyero++
[7:21pm] jsbalsera: robertdbailey
[7:21pm] tstoeckler: robertdbailey++
[7:21pm] jsbalsera: robertdbailey++
[7:21pm] tstoeckler: franSeva++
[7:21pm] franSeva: GaborHojtsy++
[7:21pm] tstoeckler: jsbalsera++
[7:21pm] tstoeckler: jsbalsera++
[7:21pm] franSeva: tstoeckler++
[7:21pm] franSeva: YesCT++
[7:21pm] tstoeckler: vijaycs85++
[7:21pm] franSeva: jsbalsera++
[7:21pm] franSeva: penyaskito++
[7:21pm] jsbalsera: vijaycs85++
[7:21pm] robertdbailey: jsbalsera++
[7:21pm] penyaskito: karma rain!
[7:21pm] Druplicon: Druplicon++
[7:22pm] penyaskito: franSeva++
[7:22pm] penyaskito: tstoeckler++
[7:22pm] penyaskito: GaborHojtsy++
[7:22pm] penyaskito: YesCT++
[7:22pm] penyaskito: vijaycs85++
[7:22pm] penyaskito: jsbalsera++
[7:22pm] asrob left the chat room. (Ping timeout: 264 seconds)
[7:22pm] penyaskito: reyero++
[7:22pm] penyaskito: tstoeckler++
[7:22pm] penyaskito: debugging-skills-of-tstoeckler++
[7:23pm] penyaskito: plach++
[7:23pm] penyaskito: even when not here...
[7:23pm] penyaskito: robertdbailey++
[7:23pm] penyaskito: weal++
[7:24pm] penyaskito: Druplicon++
[7:24pm] penyaskito: d8mi++
[7:24pm] tstoeckler: d8mi++
[7:24pm] GaborHojtsy: karma d8mi?
[7:25pm] penyaskito: Druplicon: karma d8mi
[7:25pm] Druplicon: d8mi has karma of 7.
[7:25pm] penyaskito: underrated
[7:25pm] robertdbailey: d8mi++
[7:25pm] robertdbailey: d8mi++