[6:00pm] GaborHojtsy: heyhey! [6:00pm] GaborHojtsy: I’m tethered so I will VERY LIKELY not be able to stay on consistently [6:00pm] GaborHojtsy: penyaskito is making the log [6:00pm] GaborHojtsy: I may disappear anytime [6:00pm] GaborHojtsy: who is here? [6:01pm] roderik1 is now known as roderik. [6:01pm] roderik: roderik listening in [6:01pm] GaborHojtsy: alexpott, attrib, das-peter, David_Hernandez, jsbalsera, ksenzee, penyaskito, weal, webflo, YesCT? [6:02pm] GaborHojtsy: hum? [6:03pm] GaborHojtsy: lets fire off some news then :) [6:03pm] GaborHojtsy: some conversions landed :) [6:04pm] GaborHojtsy: https://drupal.org/node/1978918 at least [6:04pm] Javisr left the chat room. (Remote host closed the connection) [6:04pm] GaborHojtsy: also coonfig overrides are now less appearing on forms :) https://drupal.org/node/2251915 and https://drupal.org/node/2239065 [6:04pm] GaborHojtsy: the former which was a generalization of a language loader :) [6:04pm] weal: hi everyone! i'm busy with my last on-site day with a client, have a good meeting! [6:05pm] GaborHojtsy: we also have a whole bunch of great RTBC stuff at http://www.drupal8multilingual.org/issues/focus [6:06pm] GaborHojtsy: and vijaycs85 updated the config inspector and it now works again with D8 head: https://drupal.org/project/config_inspector [6:06pm] GaborHojtsy: he also made an alpha1 available [6:06pm] GaborHojtsy: all good stuff :) [6:06pm] GaborHojtsy: anyone else around? :) [6:06pm] GaborHojtsy: penyaskito: ? [6:08pm] franSeva|away joined the chat room. [6:08pm] roderik: awesome. [6:09pm] roderik: Me still moving like a glacier, on a slightly related meta. Will update https://drupal.org/node/2068331 today, https://drupal.org/node/2068333 Needs Review again ( assigned to alexpott, since RTBC, didn't change that...) [6:09pm] penyaskito: GaborHojtsy: Im here :) [6:09pm] nonsie joined the chat room. [6:09pm] alexpott: roderik: you mean catch :) [6:10pm] roderik: alexpott: man. Sorry :) [6:11pm] vijaycs85 joined the chat room. [6:11pm] franSeva_ left the chat room. (Ping timeout: 250 seconds) [6:12pm] YesCT: meeting! I'm here. sorry. [6:13pm] GaborHojtsy: penyaskito: what are you working on? [6:13pm] GaborHojtsy: need help, reviews? [6:13pm] alexpott: roderik: revisionIds vs userRevisions - both return a list of vids [6:14pm] alexpott: roderik: deleteRevisionsLanguage is not deleting anything [6:14pm] penyaskito: this week I didnt put much time into issues, just https://drupal.org/node/2239399 and https://drupal.org/node/2240555, both RTBC [6:14pm] Druplicon joined the chat room. [6:14pm] webflo left the chat room. (Quit: Leaving.) [6:15pm] roderik: alexpott: thanks. [6:15pm] penyaskito: I reviewed others work, dont have the concrete issues ATM [6:15pm] webflo joined the chat room. [6:15pm] GaborHojtsy: penyaskito: I got https://drupal.org/node/2239399 RTBC [6:15pm] Druplicon: https://drupal.org/node/2239399 => Languages should be sorted by label instead of title [#2239399] => 26 comments, 15 IRC mentions [6:16pm] GaborHojtsy: penyaskito: so that should help unblock the language switcher one for you :) [6:16pm] GaborHojtsy: alexpott: if you want to look at https://drupal.org/node/2239399 is a simple one :) [6:16pm] Druplicon: https://drupal.org/node/2239399 => Languages should be sorted by label instead of title [#2239399] => 26 comments, 16 IRC mentions [6:16pm] penyaskito: and hopefully back to the language-switcher and migrate+multilingual ASAP [6:16pm] GaborHojtsy: RTBC [6:16pm] GaborHojtsy: penyaskito: trying to help get you there yeah :) [6:16pm] penyaskito: that's it on my side [6:16pm] GaborHojtsy: hope no more other blocker [6:16pm] GaborHojtsy: penyaskito++ [6:16pm] GaborHojtsy: YesCT: what about you? [6:17pm] penyaskito: roderik++ [6:17pm] YesCT: GaborHojtsy: well I pushed back on the add a little js issue. to do it in js. haven't check it's status in a couple days. [6:17pm] YesCT: I'm pretty available to review stuff. [6:19pm] GaborHojtsy: YesCT: little js issue? [6:19pm] GaborHojtsy: YesCT: btw I pinged the enabled/disabled issue to Holly :) [6:19pm] GaborHojtsy: she queued it up for the weekend [6:19pm] YesCT: https://drupal.org/node/1920876 [6:19pm] Druplicon: https://drupal.org/node/1920876 => Add a tiny bit of state magic in the image.module and hide the Title and Alt groups when the related form items are disabled [#1920876] => 74 comments, 30 IRC mentions [6:19pm] GaborHojtsy: YesCT: https://drupal.org/node/2240463 [6:19pm] Druplicon: https://drupal.org/node/2240463 => Fix text: languages are not "enabled/disabled" anymore, they are added/removed [#2240463] => 23 comments, 4 IRC mentions [6:19pm] YesCT: ah super! [6:20pm] franSeva_ joined the chat room. [6:20pm] YesCT: she pinged me a few hours ago, to "check her thinking" but I wasn't sure what on. :) [6:20pm] webflo left the chat room. (Ping timeout: 252 seconds) [6:20pm] GaborHojtsy: YesCT: its a bit more complicated than what she did before [6:20pm] GaborHojtsy: YesCT: but still novice [6:20pm] alexpott: roderik: left a review on the issue [6:21pm] rteijeiro left the chat room. (Remote host closed the connection) [6:22pm] YesCT: GaborHojtsy: (email tagged that holly issue) [6:22pm] robertdbailey: Hi everybody, coming in late from a meeting [6:22pm] GaborHojtsy: :) [6:22pm] YesCT: robertdbailey: hi! [6:22pm] roderik: alexpott: on https://drupal.org/node/2068333 ? added your comments, assigned to myself. [6:22pm] Druplicon: https://drupal.org/node/2068333 => Convert node SQL queries to the Entity Query API [#2068333] => 64 comments, 3 IRC mentions [6:22pm] GaborHojtsy: robertdbailey: hey, your stuff is RTBC :) fingers crossed [6:22pm] GaborHojtsy: YesCT++ [6:22pm] GaborHojtsy: roderik++ [6:22pm] GaborHojtsy: good stuff :) [6:22pm] penyaskito: YesCT++ [6:22pm] penyaskito: robertdbailey++ [6:22pm] robertdbailey: Yes, thanks to tstoeckler :) [6:23pm] alexpott: roderik: lol we xposted :D [6:23pm] franSeva|away left the chat room. (Ping timeout: 246 seconds) [6:23pm] robertdbailey: tstoeckler++ [6:23pm] GaborHojtsy: tstoeckler++ [6:23pm] YesCT: robertdbailey++ [6:23pm] GaborHojtsy: I also dropped some isues from the sprint board [6:23pm] YesCT: tstoeckler++ [6:23pm] roderik: alexpott: hah thanks :) [6:24pm] YesCT: GaborHojtsy: when you did that... what comment did you make on them? [6:24pm] YesCT: GaborHojtsy: can you link a sample? [6:24pm] penyaskito: tstoeckler++ [6:24pm] penyaskito: birthdays++ [6:24pm] roderik: alexpott++ [6:24pm] GaborHojtsy: also talked to York about https://drupal.org/node/2144377 and https://drupal.org/node/1966436 he is going to work on both [6:24pm] roderik: GaborHojtsy++ [6:24pm] Druplicon: https://drupal.org/node/2144377 => Entity reference always searches node titles in default language only [#2144377] => 127 comments, 23 IRC mentions [6:24pm] Druplicon: https://drupal.org/node/1966436 => Default *content* entity languages are not set for entities created with the API [#1966436] => 168 comments, 56 IRC mentions [6:24pm] roderik: penyaskito++ [6:24pm] GaborHojtsy: I know vijaycs85 got stuck on tests for the entity reference stuff [6:25pm] GaborHojtsy: which is our voodoo issue for quite a while [6:25pm] vijaycs85: GaborHojtsy: :) [6:26pm] YesCT: oh, that is the one vijaycs85 took me on a tour of. [6:26pm] YesCT: that needs mad debugging skills. [6:26pm] GaborHojtsy: yeah hope York brings some fresh perspective [6:26pm] GaborHojtsy: although he did attempt to do it in Szeged [6:28pm] penyaskito: who is York? [6:29pm] GaborHojtsy: penyaskito: http://szeged2014.drupaldays.org/sites/default/files/styles/medium/public/york-10.jpg?itok=4XboIgZ4 he was in Szeged [6:30pm] jsbalsera left the chat room. (Quit: Leaving) [6:30pm] penyaskito: GaborHojtsy: tracked, Tamás Pintér [6:30pm] GaborHojtsy: penyaskito: he is on d.o as mr.york [6:30pm] GaborHojtsy: yup [6:30pm] penyaskito: york++ [6:30pm] GaborHojtsy: he did work on prior incarnations of https://drupal.org/node/2144377 [6:30pm] GaborHojtsy: so he would be coming back to it :) [6:30pm] GaborHojtsy: who else is here who I forgot to ask? :) [6:30pm] Druplicon: https://drupal.org/node/2144377 => Entity reference always searches node titles in default language only [#2144377] => 127 comments, 24 IRC mentions [6:32pm] vijaycs85: GaborHojtsy: me? [6:32pm] GaborHojtsy: vijaycs85: hehe, yeah [6:32pm] GaborHojtsy: vijaycs85: what about you what are you working on, do you need help? [6:32pm] vijaycs85: GaborHojtsy: I was trying to fix the issue tstoeckler swapped with me, but no luck [6:33pm] vijaycs85: https://drupal.org/node/2143729 [6:33pm] Druplicon: https://drupal.org/node/2143729 => Regression: Entity definitions miss a language entity key [#2143729] => 95 comments, 13 IRC mentions [6:34pm] vijaycs85: one test case fail in https://drupal.org/node/2152217 [6:34pm] Druplicon: https://drupal.org/node/2152217 => Remove theme_form_required_marker() from the theme system - use CSS instead [#2152217] => 60 comments, 7 IRC mentions [6:34pm] penyaskito: that's not D8MI :-P [6:34pm] GaborHojtsy: :D [6:34pm] vijaycs85: penyaskito: :) [6:35pm] vijaycs85: penyaskito: checking whether you are paying attention... [6:35pm] vijaycs85: and some config inspector love [6:35pm] vijaycs85: that's it [6:35pm] YesCT: heh. [6:35pm] GaborHojtsy: vijaycs85++ [6:35pm] penyaskito: vijaycs85++ [6:35pm] vijaycs85: GaborHojtsy++ [6:35pm] vijaycs85: YesCT++ [6:35pm] vijaycs85: penyaskito++ [6:35pm] farse left the chat room. (Ping timeout: 240 seconds) [6:36pm] dasrecht_off is now known as dasrecht. [6:36pm] penyaskito: vijaycs85: anyway, for the required marker, I cannot think of any testing unless checking that the class is there [6:36pm] vijaycs85: penyaskito: yeah, sun has posted some option.. will give a go today and let you know [6:37pm] GaborHojtsy: what’s the problem on https://drupal.org/node/2143729 [6:37pm] Druplicon: https://drupal.org/node/2143729 => Regression: Entity definitions miss a language entity key [#2143729] => 95 comments, 14 IRC mentions [6:37pm] vijaycs85: penyaskito: sun suggestion was check for ::after of the element which is not in view-source and not sure how that works... lets see [6:37pm] GaborHojtsy: in theory (famoust last words?) it sounds so simple? :) [6:37pm] vijaycs85: GaborHojtsy: :D [6:37pm] dasrecht is now known as dasrecht_off. [6:38pm] vijaycs85: GaborHojtsy: for some reason, we don't have the profile pic in the comment [6:38pm] David_Hernandez left the chat room. (Quit: Leaving) [6:38pm] vijaycs85: GaborHojtsy: 1. when I try to manually do same stuff (except theme part), it works fine.. 2. When I remove the patch, the test is passing. [6:39pm] vijaycs85: GaborHojtsy: thats the status about one of the 3failures ... [6:42pm] GaborHojtsy: yeah I don’t think I could help with that without looking deeper [6:43pm] GaborHojtsy: I am unfortunately busy with CMI-D8MI related stuff [6:43pm] GaborHojtsy: vijaycs85: did you have time to look at the schema issues? [6:43pm] vijaycs85: GaborHojtsy: I thought we are still discussing about whether we need schema for tests or not [6:43pm] vijaycs85: GaborHojtsy: no? [6:44pm] GaborHojtsy: vijaycs85: yeah [6:44pm] GaborHojtsy: vijaycs85: I don’t think we have a clear answer to that [6:44pm] GaborHojtsy: vijaycs85: we don’t really need them :) [6:44pm] GaborHojtsy: vijaycs85: we would only do them for educational purposes [6:44pm] GaborHojtsy: alexpott: any strong feelings about this? [6:46pm] mzgadzaj joined the chat room. [6:47pm] alexpott: GaborHojtsy: not really [6:47pm] alexpott: GaborHojtsy: we have decided ages ago to not mandate them [6:49pm] GaborHojtsy: alexpott: yeah, we can skip them for tests, in which case this becomes much simpler [6:49pm] GaborHojtsy: alexpott: I think this is just a “setting an examples” question maybe brought too far :D [6:49pm] alexpott: GaborHojtsy: fine by me [6:50pm] YesCT: GaborHojtsy: alexpott: maybe we postpone those? [6:50pm] GaborHojtsy: YesCT: no, won’t fix [6:51pm] YesCT: whoa. k. [6:51pm] vijaycs85: GaborHojtsy: and another issue that has patch is kinda blocked by https://drupal.org/node/2248709#comment-8724805 (unless we want to introduce a mapper at top level like alexpott did in https://drupal.org/node/2224761) [6:51pm] Druplicon: https://drupal.org/node/2248709 => The root type of a configuration object can not be a sequence [#2248709] => 17 comments, 7 IRC mentions [6:51pm] Druplicon: https://drupal.org/node/2224761 => Field instances should support pluggable extra configuration for use cases like translation sync [#2224761] => 59 comments, 16 IRC mentions [6:52pm] GaborHojtsy: vijaycs85: which one is blocked on that? [6:52pm] alexpott: YesCT: well we need to go through https://drupal.org/node/2231059 and probably close the test issues but do the others. [6:52pm] Druplicon: https://drupal.org/node/2231059 => [meta] Find out what config schemas are still missing and add them [#2231059] => 26 comments, 13 IRC mentions [6:52pm] GaborHojtsy: vijaycs85: https://drupal.org/node/2224761 definitely not anymore [6:52pm] Druplicon: https://drupal.org/node/2224761 => Field instances should support pluggable extra configuration for use cases like translation sync [#2224761] => 59 comments, 17 IRC mentions [6:52pm] GaborHojtsy: YesCT: what alexpott said :) [6:53pm] GaborHojtsy: vijaycs85: I think the top level sequence would be nice but not mandatory ATM, [6:53pm] vijaycs85: GaborHojtsy: https://drupal.org/node/2245721 [6:53pm] YesCT: ah. :) [6:53pm] Druplicon: https://drupal.org/node/2245721 => Add missing configuration schema in language component [#2245721] => 7 comments, 5 IRC mentions [6:53pm] GaborHojtsy: vijaycs85: seems to be contention [6:53pm] GaborHojtsy: vijaycs85: ah that one [6:53pm] GaborHojtsy: vijaycs85: well, then argue more for that in the seuqnce issue :D [6:53pm] GaborHojtsy: sequence issue that is [6:54pm] vijaycs85: GaborHojtsy: :D [6:54pm] vijaycs85: GaborHojtsy: already sun and alexpott on it :) [6:55pm] alexpott: vijaycs85, GaborHojtsy, YesCT: https://drupal.org/node/2245721 will become unnecessary if fields support plugins. Whatever way we go I think https://drupal.org/node/2224761 should handle the schemas for this config data since it will change them. [6:55pm] Druplicon: https://drupal.org/node/2245721 => Add missing configuration schema in language component [#2245721] => 7 comments, 6 IRC mentions [6:55pm] Druplicon: https://drupal.org/node/2224761 => Field instances should support pluggable extra configuration for use cases like translation sync [#2224761] => 59 comments, 18 IRC mentions [6:55pm] GaborHojtsy: alexpott: yeah btu they don’t agree, so need more feedback :D [6:55pm] alexpott: GaborHojtsy: I think you meant that for vijaycs85 ^^ [6:56pm] GaborHojtsy: vijaycs85: yup :D [6:56pm] GaborHojtsy: vijaycs85: ˆˆˆˆ [6:56pm] • vijaycs85 reading ^^^ [6:58pm] alexpott: vijaycs85, GaborHojtsy: one issue is that if schema are not required and someone makes a config file with a sequence as the root type with the current code they can never have a schema [6:59pm] alexpott: vijaycs85, GaborHojtsy: to me, if schema are not going to be mandatory then this makes https://drupal.org/node/2248709 a have to have in my opinion. [6:59pm] Druplicon: https://drupal.org/node/2248709 => The root type of a configuration object can not be a sequence [#2248709] => 17 comments, 8 IRC mentions [7:00pm] YesCT: so that title should be: Allow root type of a configuration object to be a sequence [7:01pm] alexpott: YesCT: indeed [7:03pm] GaborHojtsy: alexpott: yeah if schemas are optional than this would be optional too [7:03pm] mzgadzaj left the chat room. (Remote host closed the connection) [7:03pm] GaborHojtsy: alexpott: there are so many other constructs that schemas cannot describe [7:03pm] GaborHojtsy: alexpott: eg. the translation sync issue is so big because schemas cannot describe that [7:03pm] GaborHojtsy: alexpott: well, also config entities don’t have a “misc” container in them [7:03pm] mzgadzaj joined the chat room. [7:03pm] GaborHojtsy: alexpott: btu also schemas :D [7:04pm] GaborHojtsy: alexpott: and several other data structures were “informed by schemas” so we can describe them [7:04pm] GaborHojtsy: alexpott: eg. to have plugin IDs in them even when they thought they would not need them and such [7:04pm] GaborHojtsy: so this would not be a precedent in itself [7:06pm] GaborHojtsy: so I don’t have strong feelings for schema mandating certain types [7:06pm] GaborHojtsy: sure the other examples are obscurer :D [7:06pm] GaborHojtsy: this is easier to run into [7:06pm] GaborHojtsy: anyway as I’ve said on the issue I’m fine either way, but I did not see this one as required [7:06pm] GaborHojtsy: maybe it is for the language schema stuff, heh [7:06pm] GaborHojtsy: anyway, sorry but need to go now :D [7:07pm] GaborHojtsy: thanks everone for coming! [7:07pm] GaborHojtsy: alexpott++ [7:07pm] GaborHojtsy: YesCT++ [7:07pm] GaborHojtsy: vijaycs85++ [7:07pm] YesCT: me too. [7:07pm] GaborHojtsy: penyaskito++ [7:07pm] YesCT: alexpott++ [7:07pm] GaborHojtsy: roderik++ [7:07pm] YesCT: GaborHojtsy++ [7:07pm] penyaskito: GaborHojtsy++ [7:07pm] YesCT: vijaycs85++ [7:07pm] GaborHojtsy: robertdbailey++ [7:07pm] YesCT: roderik++ [7:07pm] penyaskito: d8mi++ [7:07pm] alexpott: everyone++ :D [7:07pm] YesCT: robertdbailey++ [7:07pm] GaborHojtsy: d8mi++ [7:07pm] YesCT: penyaskito++ [7:07pm] penyaskito: alexpott++ [7:07pm] robertdbailey: penyaskito++ [7:07pm] alexpott: Druplicon: karma everyone? [7:07pm] Druplicon: everyone has karma of 59. [7:07pm] robertdbailey: GaborHojtjsy++ [7:07pm] robertdbailey: YesCT++ [7:07pm] penyaskito: Druplicon: karma d8mi? [7:07pm] Druplicon: d8mi has karma of 11. [7:07pm] YesCT: d8mi++ [7:08pm] GaborHojtsy: getting there :P [7:08pm] alexpott: that's way not enough for d8mi and everyone! [7:08pm] robertdbailey: vijaycs85++ [7:08pm] mzgadzaj left the chat room. (Ping timeout: 252 seconds) [7:08pm] alexpott: YesCT++ [7:08pm] alexpott: GaborHojtsy++ [7:08pm] alexpott: penyaskito++ [7:08pm] alexpott: vijaycs85++ [7:08pm] robertdbailey: alexpott++