17:59 GaborHojtsy: Im missing the meeting too, have to run :/ 17:59 GaborHojtsy: I couldnt work on the migrate nodes translations issue 17:59 GaborHojtsy: hope to do that in summer.drupal.cat if still needed 18:00 GaborHojtsy: and proposed https://events.drupal.org/dublin2016/sessions/drupal-8s-multilingual-apis-building-entire-world before the deadline :) 18:00 GaborHojtsy: that's all I had to say 18:00 → kristen_pol joined (~Adium@c-98-234-142-229.hsd1.ca.comcast.net) 18:01 I can't make meeting today 18:01 my son's mouth hurts (braces got adjusted) 18:01 I don't think any of the tickets I worked on recently have gotten anywhere but I'll be able to look this weekend 18:01 all for me 18:02 oh, I did change the D7+D8 multilingual talk for Dublin to be me and GaborHojtsy 18:02 bye 18:03 kristen_pol++ 18:05 heyhey 18:05 penyaskito: kristen_pol no problem :) 18:06 penyaskito: thanks for the update, congrats on the session 18:06 kristen_pol: thanks for the update too :) 18:06 penyaskito++ 18:06 kristen_pol++ 18:06 anyone else here? 18:06 maybe hchonov, vasi, vijaycs85? :) 18:16 hm, no 18:17 → tstoeckler joined (~tobias@x4db6cacb.dyn.telefonica.de) 18:17 hola 18:17 sup 18:18 GaborHojtsy: hi 18:22 GaborHojtsy: sorry missed your message. I don't have any updates this week. 18:22 ↔ UTAN_dev nipped out 18:25 I have a couple of tickets for which I am waiting for a review from berdir. https://www.drupal.org/node/2675010 has been reverted because after it fixed a problem it showed that there is a problem in the paragraphs module. That is why I've created another issue for the other problem - https://www.drupal.org/node/2757003 . And the other one I am waiting for a review - https://www.drupal.org/node/2755525 18:25 https://www.drupal.org/node/2675010 => Cloned entity will point to the same field objects if the clone was created after an entity translation has been initialized [#2675010] => 30 comments, 7 IRC mentions 18:25 https://www.drupal.org/node/2757003 => entity builder ContentEntityForm::updateFormLangcode changes the form language code during ajax calls [#2757003] => 18 comments, 7 IRC mentions 18:25 https://www.drupal.org/node/2755525 => Invoke field methods first on the current entity translation [#2755525] => 15 comments, 7 IRC mentions 18:30 ⇐ rteijeiro quit (~rteijeiro@c83-250-140-38.bredband.comhem.se) Read error: Connection reset by peer 18:35 hchonov: yeah since they did not raise concerns, we should not block it on them, I RTBC-ed https://www.drupal.org/node/2755525 18:35 https://www.drupal.org/node/2755525 => Invoke field methods first on the current entity translation [#2755525] => 16 comments, 8 IRC mentions 18:35 (I reviewed it before) 18:35 https://www.drupal.org/node/2757003 is also RTBC for a while 18:35 https://www.drupal.org/node/2757003 => entity builder ContentEntityForm::updateFormLangcode changes the form language code during ajax calls [#2757003] => 18 comments, 8 IRC mentions 18:35 and postponed https://www.drupal.org/node/2675010 18:35 https://www.drupal.org/node/2675010 => Cloned entity will point to the same field objects if the clone was created after an entity translation has been initialized [#2675010] => 30 comments, 8 IRC mentions 18:35 so we now need committer action to move those 18:36 hchonov++ 18:36 vijaycs85: no problem :) 18:36 tstoeckler: hi :) 18:36 tstoeckler: you amde it :) 18:36 GaborHojtsy++ 18:36 :-) 18:37 ⇐ alexpott quit (~alexpott@drupal.org/user/157725/view) Remote host closed the connection 18:38 GaborHojtsy++ 18:38 → alexpott joined (~alexpott@drupal.org/user/157725/view) 18:38 tstoeckler: so wanna discuss https://www.drupal.org/node/2595535? 18:39 https://www.drupal.org/node/2595535 => Show helpful message (do not fatal!) when configuration files have different source language codes and cannot be translated [#2595535] => 74 comments, 21 IRC mentions 18:39 Sure! 18:40 → rteijeiro and alexpott_ joined 18:40 So the problem that lead to the recent discussion was that we have an access check for the overview in config_translation and one for the translation form. And the latter needs to somewhat inherit the access checks from the former but also do some additional things and do some things differently 18:40 yup 18:40 So alexpott rightly was unhappy with the last iteration where I just stored stateful things like $this->mapper and $this->sourceLangcode in the object to be able to re-use them at arbitrary points. 18:41 I've know refactored it to avoid that and the code IMO is much nicer to read. 18:41 GaborHojtsy: have you looked at the latest patch? 18:41 ⇐ Greg-Boggs quit (~greg_bogg@173.240.241.83) Remote host closed the connection 18:42 tstoeckler: just looked at the interdiff just now 18:42 ⇐ alexpott quit (~alexpott@drupal.org/user/157725/view) Ping timeout: 260 seconds 18:42 ahh cool 18:43 tstoeckler: that makes sense to me, the new methods are protected so no new backwards incompatible things :) 18:43 tstoeckler: and the functionality is indeed nicely inherited 18:43 yay :) 18:44 ⇐ alexpott_ quit (~alexpott@drupal.org/user/157725/view) Ping timeout: 264 seconds 18:45 tstoeckler: OTOH not all of catch's concerns were taken care of or commented on? 18:46 GaborHojtsy: I didn't comment on it explicitly, but I did fix them. I.e. I updated the comment, removed !empty() and added strict comparison 18:46 GaborHojtsy: It's probably just not visible because the interdiff is a bit messy. 18:47 tstoeckler: hm, did you? 18:47 oh, I see, the strict comparison one somehow I missed in my search 18:47 that looks covered yes, also the exception 18:47 GaborHojtsy: Oh right, I'm sorry 18:47 no, my bad 18:48 GaborHojtsy: I actually removed the comment altogether because we now actually use a proper variable assignment, so it's no longer needed IMO 18:48 before we were doing "$mapper->getLangcode();" without assigning it to anything, just to throw the exception (possibly) 18:48 → Greg-Boggs joined (~greg_bogg@173.240.241.83) 18:49 tstoeckler: makes sense, I posted a comment and RTBC-ed :) 18:49 tstoeckler: thanks for walking me through it 18:49 GaborHojtsy: yay!!! awesome 18:51 ⇐ jonhattan quit (~jonhattan@188.85.20.99) Quit: Ex-Chat 18:51 tstoeckler: thanks for working on this :) 18:51 I discussed a potential reroll with vasi and penyaskito for https://www.drupal.org/node/2225775 because that is also on the verge of RTBC (it was there before but now does not apply) 18:52 https://www.drupal.org/node/2225775 => Migrate Drupal 6 core node translation to Drupal 8 [#2225775] => 221 comments, 71 IRC mentions 18:52 and there is also a renewed discussion on https://www.drupal.org/node/2135829 which is a key issue for the API first initative 18:52 https://www.drupal.org/node/2135829 => EntityResource: translations support [#2135829] => 40 comments, 4 IRC mentions 18:52 ⇐ mon_franco quit (~mon_franc@147.67.4.98) Ping timeout: 260 seconds 18:55 that's it for me I guess 19:04 (lurking) 19:05 YesCT: :) 19:05 I think that was everyone, thanks all for making it even int he middle of the summer :) 19:05 YesCT++ 19:05 tstoeckler++ 19:05 hchonov++ 19:05 vijaycs85++ 19:05 penyaskito++ 19:06 kristen_pol++ 19:06 ha 19:06 :) 19:08 GaborHojtsy++ 19:08 YesCT++ 19:08 hchonov++ 19:09 alexpott++ 19:09 penyaskito++ 19:09 vijaycs85++ 19:09 Berdir++ 19:09 kristen_pol++ 19:10 → jonhattan joined ⇐ Greg-Boggs quit 19:12 tstoeckler++ 19:12 GaborHojtsy++