[5:00pm] GaborHojtsy: Welcome everyone to the D8MI meeting! [5:00pm] GaborHojtsy: anybody from the European sprints? [5:01pm] Sutharsan: yea, the @home sprint [5:01pm] GaborHojtsy: Sutharsan: [5:03pm] GaborHojtsy: penyaskito: around? [5:03pm] carstenmueller: yes [5:03pm] penyaskito: GaborHojtsy, yup [5:03pm] GaborHojtsy: Sutharsan: how is it going? I've seen you are actively updating stuff [5:03pm] GaborHojtsy: penyaskito: success with the user entity translation UI patch? [5:03pm] penyaskito: GaborHojtsy, not too much [5:04pm] Sutharsan: GaborHojtsy: I have a working download and import patch with tests. [5:04pm] penyaskito: just getting familiar with that part, first focusing on why the rest of the user forms are not there [5:05pm] Schnitzel: Half from the europe sprints [5:05pm] Sutharsan: GaborHojtsy: now continuing with the the all-inclusive (status check + download + import) batch followed by processing all the issue comments. [5:05pm] GaborHojtsy: penyaskito: ha [5:05pm] GaborHojtsy: penyaskito: no success with reproducing, or sad because it can be reproduced? [5:05pm] GaborHojtsy: Sutharsan: woot [5:05pm] GaborHojtsy: webflo: hi, can you help review Sutharsan's progress? [5:05pm] penyaskito: GaborHojtsy, can reproduce [5:05pm] GaborHojtsy: penyaskito: ah, ok, that would be good to post on the issue [5:06pm] penyaskito: every issue [5:06pm] GaborHojtsy: penyaskito: maybe try with an older version and see if this was there (probably not) [5:06pm] GaborHojtsy: penyaskito: I think plach is somewhere between bed and/or the core summit and/or the coder lounge [5:07pm] GaborHojtsy: penyaskito: he would be able to help later, but not at the moment [5:07pm] GaborHojtsy: Schnitzel: can help with an issue? [5:08pm] • Schnitzel is waving for something to work on! [5:08pm] GaborHojtsy: Schnitzel: I think Sutharsan's patch to be reviewed is probably the best place ATM [5:08pm] GaborHojtsy: webflo: Schnitzel: http://drupal.org/node/1804688 [5:08pm] Druplicon: http://drupal.org/node/1804688 => Download and import interface translations => Drupal core, locale.module, major, needs review, 17 comments, 7 IRC mentions [5:09pm] Schnitzel: +1 [5:11pm] reyero joined the chat room. [5:11pm] GaborHojtsy: balintk: how is the l10n download UI going? [5:11pm] GaborHojtsy: reyero: hey! [5:11pm] • YesCT read the backscroll to catch up [5:12pm] YesCT: penyaskito: good to know you can reproduce [5:13pm] balintk: GaborHojtsy: I've just tried out Jose's patch -- wanted to see if I can use that as a starting point [5:14pm] webflo: it think the architecture is a bit confusing. there are a lot of notices and warings in the test. i could fix this but i dont know whats the right approach. locale_translation_update_file_history() confuses me. or mockImportedPoFile LocaleFileImportStatus::mockImportedPoFile should populate the project property. [5:15pm] GaborHojtsy: reyero: so we've been discussing the metadata patch process with heyrocker (NOT the actual patch) and it would probably be good to figure out time to review it here with fago and heyrocker [5:16pm] webflo: Sutharsan: but we use mockImportedPoFile for all po files. and we have also po files without a project ... [5:16pm] GaborHojtsy: reyero: I'm wondering if we can figure out a time to do a Skype call, but no heyrocker or fago here yet [5:16pm] Sutharsan: webflo: I did not know about mockImportedPoFile [5:20pm] GaborHojtsy: reyero: ? [5:20pm] GaborHojtsy: balintk: sounds like a plan [5:20pm] Sutharsan: webflo: one thing to know is that the test needs to download a po file as if it comes from an external server. (i.e using http://testdomain) and .htaccess blocks po extensions. therefore I had to switch to _po (previous txt) extension. I don't know if mockImportedPoFile works for this case. [5:21pm] YesCT left the chat room. (Ping timeout: 256 seconds) [5:21pm] webflo: Sutharsan: yes i know i get that [5:23pm] GaborHojtsy: reyero: in the meantime an architecture diagram / drawing would be great to accelerate the review process, if you can do one [5:24pm] GaborHojtsy: reyero: it did help a lot for the gettext API patch for example [5:25pm] webflo: Sutharsan: but function locale_translate_batch_build() will fail for this files. or you wont get the langcode ... [5:27pm] iSampo joined the chat room. [5:28pm] Sutharsan: webflo: I know I changed the parameter of locale_translate_batch_build() but did not fix other places where it is called. [5:28pm] YesCT joined the chat room. [5:28pm] Sutharsan: webflo: I don't think locale_translate_batch_build() is the right place to find out the language of the file it receives. [5:31pm] balintk: GaborHojtsy: sorry, I had a phone call [5:32pm] GaborHojtsy: balintk: I can maybe get Bojhan to IRC if you have questions [5:32pm] GaborHojtsy: balintk: he just arrived at the table I'm sitting at [5:32pm] Jibran_ joined the chat room. [5:32pm] balintk: GaborHojtsy: so, my problem right now is that I don't know whether Jose's patch is already suppose to work [5:33pm] balintk: GaborHojtsy: because it can't download translations for me [5:33pm] GaborHojtsy: balintk: well, he had a patch with Sutharsan's download stuff integrated, no? [5:33pm] GaborHojtsy: balintk: also Sutharsan just updated his download patch earlier today [5:33pm] Jibran left the chat room. (Ping timeout: 256 seconds) [5:33pm] Jibran_ is now known as Jibran. [5:34pm] Sutharsan: GaborHojtsy: balintk: yes, Jose's patch was build upon mine. And I uploaded a new patch changed in the mean time [5:34pm] Sutharsan: balintk: but jose also attached an interdiff [5:35pm] balintk: Sutharsan: okay, I will make Jose's implementation work first based on the interdiff and using your patch, then we can iterate and get Bojhan's UI in [5:35pm] balintk: does it make sense? [5:36pm] hairqles left the chat room. (Quit: hairqles) [5:36pm] Sutharsan: balintk: that's ok [5:36pm] YesCT: penyaskito: I suspect we need to write a test. Is writing tests easy for you? [5:36pm] penyaskito: YesCT, yeah [5:37pm] webflo: Sutharsan: i think it should be in locale_translate_import_form_submit() and pass a array of file and langcode to locale_translate_batch_build [5:37pm] Bojhan joined the chat room. [5:37pm] • Bojhan is here [5:38pm] rteijeiro left the chat room. (Remote host closed the connection) [5:38pm] GaborHojtsy: balintk: ^^^ [5:39pm] hairqles joined the chat room. [5:39pm] GaborHojtsy: Bojhan: balintk: marked the UI discussion issue duplicate and copy-pasted over the latest screens from http://drupal.org/node/1804702#comment-6682394 to the implementation issue [5:39pm] Druplicon: http://drupal.org/node/1804702 => Display translation status => Drupal core, locale.module, normal, needs work, 11 comments, 5 IRC mentions [5:39pm] • Bojhan waves to balintk [5:39pm] GaborHojtsy: balintk: Bojhan from/to [5:40pm] Bojhan: You can probally just reuse the pattern from the module page [5:40pm] balintk: hi Bojhan, I will try to implement your UI plans [5:41pm] Bojhan: balintk: cool [5:42pm] dvanactka joined the chat room. [5:42pm] Sutharsan: balintk: if you paste this code http://pastebin.com/ReeF4GpN in a mode (test) the site you will be able to work with real D7 translations being downloaded from l.d.o [5:42pm] balintk: GaborHojtsy: oh, thanks for the copy-pasting, I was thinking about the same [5:44pm] scor joined the chat room. [5:45pm] GaborHojtsy: penyaskito: place is coming up online to work with you [5:46pm] vasi1186 joined the chat room. [5:46pm] GaborHojtsy: anybody around at the EU sprints looking for work? [5:46pm] GaborHojtsy: vasi1186: ? [5:47pm] vasi1186: GaborHojtsy: yes, but not right now. Maybe a bit later or in the weekend. [5:48pm] vasi1186: GaborHojtsy: on Sunday I will work for sure for the spint. [5:48pm] vasi1186: GaborHojtsy: so if you have something, you can give it to me, otherwise I will check the tickets list later. [5:48pm] GaborHojtsy: vasi1186: ok, I don't know yet what will be available then [5:48pm] GaborHojtsy: vasi1186: watch the D8MI focus queue [5:49pm] vasi1186: GaborHojtsy: yes [5:52pm] drupol left the chat room. (Ping timeout: 260 seconds) [5:52pm] jcisio is now known as jcisio|aw. [5:53pm] GaborHojtsy: vasi1186: thanks! [5:53pm] GaborHojtsy: so our official meeting time is nearing an end [5:53pm] carstenmueller left the chat room. (Ping timeout: 260 seconds) [5:53pm] GaborHojtsy: we will be online for the day as much as possible though [5:55pm] penyaskito left the chat room. (Ping timeout: 260 seconds) [5:55pm] GaborHojtsy: just as a reminder, our next meeting will be on next Wed in the regular meeting time [5:55pm] GaborHojtsy: I'll try to attend from Berkeley for that as well [5:55pm] GaborHojtsy: thanks everyone for working so hard [5:56pm] GaborHojtsy: it is highly appreciated