[6:01pm] GaborHojtsy: hey!
[6:01pm] GaborHojtsy: D8MI meeting time!
[6:01pm] GaborHojtsy: anybody here for the meeting?
[6:02pm] YesCT: heh. I'm here to pick the mind of reyero.
[6:02pm] GaborHojtsy: YesCT:
[6:02pm] YesCT: attending the meeting is an extra bonus.
[6:04pm] GaborHojtsy: YesCT: don't be bothered by the meeting logging
[6:04pm] reyero: GaborHojtsy: hi
[6:04pm] GaborHojtsy: reyero: hey!
[6:05pm] YesCT: plach might be here for the meeting. I saw he just came on.
[6:05pm] plach: yessir!
[6:05pm] Druplicon: plach: 1 day 9 hours ago <GaborHojtsy> tell plach fantastic work on http://drupal.org/node/1810386, in Bojhan's words (from IRC): "wow, that looks pretty good already! :)"
[6:06pm] plach:
[6:07pm] plach: GaborHojtsy: I couldn't work on tests yesterday, I fell asleep on the keyboard
[6:07pm] GaborHojtsy: plach: ha! np!
[6:07pm] plach: Hope to finish tonight
[6:07pm] YesCT: fago, penyaskito, attiks|away . here for the d8mi meeting?
[6:07pm] • GaborHojtsy does a happy dance for both reyero and plach being in attendance *at the same time*
[6:07pm] YesCT: I wonder who else I can pester..
[6:07pm] jessehs left the chat room. (Remote host closed the connection)
[6:07pm] YesCT: where is michael?
[6:08pm] penyaskito: YesCT, not really, but I should
[6:08pm] reyero: GaborHojtsy:
[6:08pm] plach: GaborHojtsy: were you starting to think we are actually the same person?
[6:08pm] GaborHojtsy: penyaskito:
[6:09pm] GaborHojtsy: plach: no, not that
[6:09pm] penyaskito: whats next?
[6:09pm] plach: GaborHojtsy: couldn't follow closely the latest progress but it seems the config langauge issues are in a pretty good shape!
[6:09pm] plach: reyero++
[6:09pm] plach: GaborHojtsy++
[6:09pm] plach: YesCT++
[6:10pm] plach: if anyone wishes to talk about those I'd be happy to learn more about the current situation
[6:11pm] reyero: plach: sure, your review on any of them would be great, I think maybe https://drupal.org/node/1763640
[6:11pm] Druplicon: https://drupal.org/node/1763640 => Introduce config context to make config consistent and accessible in different languages => Drupal core, configuration system, major, needs review, 30 comments, 9 IRC mentions
[6:12pm] YesCT: plach: you mean the beast http://drupal.org/node/1648930 and http://drupal.org/node/1763640 ?
[6:12pm] Druplicon: http://drupal.org/node/1648930 => Introduce configuration metadata and use for translation => Drupal core, configuration system, critical, needs work, 224 comments, 105 IRC mentions
[6:12pm] Druplicon: http://drupal.org/node/1763640 => Introduce config context to make config consistent and accessible in different languages => Drupal core, configuration system, major, needs review, 30 comments, 15 IRC mentions
[6:13pm] YesCT: yeah I would say hold off on 930. but 640 could use some eyes.
[6:13pm] plach: reyero: I will try, this weekend I should have some more free time so I should be able to post the patches for the feture freeze issues I have on my list. Probably I'll be able to have a serious look to it
[6:13pm] Sutharsan left the chat room. (Quit: Sutharsan)
[6:13pm] plach: YesCT: those!
[6:13pm] Sutharsan joined the chat room.
[6:14pm] plach: GaborHojtsy: do we have any agenda?
[6:14pm] GaborHojtsy: plach: nope, not for today
[6:14pm] GaborHojtsy: I imagine people have pet issues they want to discuss, so we can get going discussion on the CMI stuff from above first if anybody has stuff to say
[6:15pm] YesCT: maybe before we get in too deep there,
[6:15pm] plach: GaborHojtsy: I'd be interested in reading your pov about the current D8Mi status in general in there's nothing else more urgent
[6:15pm] plach: * s/in/if
[6:15pm] YesCT: I'd like to point out there is a new patch for http://drupal.org/node/1804688
[6:15pm] Druplicon: http://drupal.org/node/1804688 => Download and import interface translations => Drupal core, locale.module, major, needs review, 51 comments, 23 IRC mentions
[6:16pm] YesCT: and that seems like a place people could jump into.
[6:16pm] GaborHojtsy: penyaskito: your review on http://drupal.org/node/1804688 would be great
[6:16pm] Druplicon: http://drupal.org/node/1804688 => Download and import interface translations => Drupal core, locale.module, major, needs review, 51 comments, 24 IRC mentions
[6:16pm] GaborHojtsy: attiks|away: too ^^^^:)
[6:17pm] penyaskito: GaborHojtsy, I'll do
[6:18pm] YesCT: GaborHojtsy: does that thing you said Sutharsan was working on, but didn't have an issue for yet.. does it fall under feature freeze?
[6:18pm] GaborHojtsy: Sutharsan: hi!
[6:18pm] GaborHojtsy: YesCT: not sure
[6:19pm] YesCT: "installer integrated with the update UI"
[6:19pm] GaborHojtsy: YesCT: it would apply the file download to a new part of the system
[6:19pm] GaborHojtsy: penyaskito: thanks!
[6:19pm] plach: GaborHojtsy: do you think you'll be able to perform a complete code review of the wizrd issue or should I look for someone else?
[6:19pm] tanarurkerem left the chat room. (Quit: tanarurkerem)
[6:21pm] plach: GaborHojtsy: same question about the other issues in http://drupal.org/project/issues/search/drupal?component[]=translation_entity.module&issue_tags=feature+freeze
[6:21pm] plach: I hope to be able to post patches for all of those
[6:22pm] YesCT: 4!
[6:22pm] DesireJM left the chat room. (Read error: Operation timed out)
[6:23pm] YesCT: only 1 of those is on: http://hojtsy.hu/d8mi/focus
[6:23pm] GaborHojtsy: plach: someone else would be great  I'm presenting D8MI over the weekend and trying to do some preliminary usability testing (both Sat and Sun is taken with Drupalcamp Budapest), then my wife has her birthday next week, so things collide a bit
[6:24pm] GaborHojtsy: YesCT: well, we are trying to keep the board clean with the top issues only
[6:24pm] GaborHojtsy: YesCT: not that it worked to draw in new people in any way
[6:24pm] YesCT: hmm.
[6:24pm] GaborHojtsy: YesCT: I think post Dec 1st, we need to figure out some better visualisations, eg. for new people, things that need different kind of feedback, etc.
[6:24pm] YesCT: it can be kind of scary because they are challenging issues.
[6:24pm] plach: GaborHojtsy: I'll try to stalk Berdir or micheal
[6:24pm] GaborHojtsy: it IS scary
[6:25pm] YesCT: maybe putting some of those on the board with a "welcome new people" banner.
[6:25pm] YesCT: and the others without that flag would be implied: this can be overwelming or is not ready for someone new to jump into.
[6:26pm] YesCT: not "novice" but just "jump-in-able"
[6:27pm] plach: also bforchhammer could be a good candidate
[6:28pm] YesCT: plach: maybe highlight the http://drupal.org/project/issues/search/drupal?component%5B%5D=translation_entity.module&issue_tags=feature+freeze ones on the et-ui meta follow up.
[6:28pm] GaborHojtsy: YesCT: yeah I think we need to rethink the board
[6:29pm] GaborHojtsy: YesCT: but we'll have a lot more diverse things after Dec 1st I think, also should hopefully be able to onboard all kinds of new people with new tasks
[6:29pm] • GaborHojtsy dreaming
[6:29pm] YesCT: right.
[6:30pm] wundo joined the chat room.
[6:30pm] plach: YesCT: I think bforchhammer could be a good candidate, he's the main ET co-maintainer. For now he's focused on D7, but I could try to involve hime in those issues. He's definetely one of the persons that know that stuff netter
[6:30pm] • reyero posted the updated patch in the config metadata issue
[6:30pm] plach: * better
[6:30pm] • plach mailing hime right now
[6:30pm] • plach cannot write "him"
[6:31pm] devincarlson joined the chat room.
[6:31pm] GaborHojtsy: reyero: woot
[6:31pm] YesCT: for now, for 9 days.. maybe we can .. make a list of non-scarey ones and put them … on the core initiatives page?
[6:31pm] reyero: GaborHojtsy: We should have a big countdown panel somewhere
[6:31pm] YesCT: feature freeze?
[6:31pm] Druplicon: Time to feature freeze: http://countingdownto.com/countdown-page/show/Drupal%208%20Feature%20Freeze%7C50b98ed0%7C4 | See http://buytaert.net/updated-drupal-8-release-schedule .
[6:32pm] YesCT: plach: I thought for a moment his name was Hime.
[6:32pm] reyero: wow  !!
[6:33pm] YesCT: so, in terms of d8mi overview, plach's feature freeze items could use some looks.
[6:34pm] GaborHojtsy: reyero: yeah, if you have a second monitor and lack stress
[6:34pm] Schnitzel joined the chat room.
[6:34pm] plach: Schnitzel!
[6:34pm] GaborHojtsy: reyero: just pop up a window
[6:34pm] YesCT: penyaskito and maybe attiks is going to look at http://drupal.org/node/1804688
[6:34pm] Schnitzel: ueeee
[6:34pm] Druplicon: http://drupal.org/node/1804688 => Download and import interface translations => Drupal core, locale.module, major, needs work, 52 comments, 25 IRC mentions
[6:35pm] YesCT: plach is going to look at http://drupal.org/node/1763640
[6:35pm] Druplicon: http://drupal.org/node/1763640 => Introduce config context to make config consistent and accessible in different languages => Drupal core, configuration system, major, needs review, 30 comments, 16 IRC mentions
[6:35pm] GaborHojtsy: Schnitzel: hey, how is the node access stuff going?
[6:35pm] YesCT: (I pestered Schnitzel on twitter)
[6:35pm] plach: Schnitzel: how is the ml node access issue going?
[6:35pm] plach: lol
[6:35pm] GaborHojtsy: YesCT: seen that
[6:35pm] Schnitzel: lol
[6:35pm] Schnitzel: I will work on it today
[6:36pm] dclavain left the chat room. (Quit: Saliendo)
[6:36pm] plach: Schnitzel: do you need reviews or is xjm's help enough?
[6:36pm] YesCT: Schnitzel: but over all, it's looking in good shape for feature freeze, right?
[6:36pm] Schnitzel: and I also have a new patch for http://drupal.org/node/1832778
[6:36pm] Druplicon: http://drupal.org/node/1832778 => Include translation operation in overviews for translatable entities => Drupal core, translation_entity.module, normal, needs work, 53 comments, 21 IRC mentions
[6:38pm] Schnitzel: plach: YesCT: looks good, I guess I don't need something right now
[6:38pm] Schnitzel: definitely after I finished the changes from xjm
[6:38pm] GaborHojtsy: Schnitzel: ok, cool on 1832778
[6:38pm] GaborHojtsy: Schnitzel: it was RTBC and green and then a removed ; from an innocent place made it fail
[6:38pm] GaborHojtsy: Schnitzel: interesting...
[6:38pm] GaborHojtsy: ú
[6:38pm] kalmanhosszu joined the chat room.
[6:39pm] YesCT: Schnitzel: when you post your changes. Give a todo list and we can parse out the list to people.
[6:39pm] YesCT: about: 1832778. we didn't see an interdiff… so we are not sure that was the only change.
[6:40pm] YesCT: and it's possible that if we resubmitted #42 http://drupal.org/node/1832778#comment-6715750 that it might fail, if the ; was really the only thing to change.
[6:40pm] Druplicon: http://drupal.org/node/1832778 => Include translation operation in overviews for translatable entities => Drupal core, translation_entity.module, normal, needs work, 53 comments, 22 IRC mentions
[6:41pm] GaborHojtsy: I did resubmit for testing
[6:41pm] GaborHojtsy: failed again
[6:41pm] YesCT: GaborHojtsy: you resubmitted #47 the one without the ;
[6:42pm] GaborHojtsy: YesCT: yup
[6:42pm] YesCT: I'll futz with that one.
[6:42pm] YesCT: oh, wait, Schnitzel said he has a new patch for it.
[6:43pm] Schnitzel: nono I realize just now that rvilar already did what I wanted to do
[6:43pm] GaborHojtsy: Schnitzel: well, he removed a ; not the whitespace
[6:43pm] YesCT: Schnitzel: I think you should post yours.
[6:44pm] GaborHojtsy: YesCT: so feel free to take it, it should be a  quick one and back to RTBC right after
[6:44pm] Schnitzel: okay
[6:44pm] GaborHojtsy: whatever
[6:44pm] YesCT: heh.
[6:44pm] YesCT: race.
[6:45pm] Sutharsan left the chat room. (Quit: Sutharsan)
[6:45pm] YesCT: Schnitzel: if you post yours, post also an interdiff to the passing one from #42
[6:45pm] Schnitzel: YesCT: yes will do
[6:46pm] YesCT: what else is on http://hojtsy.hu/d8mi/focus that we have not talked about?
[6:46pm] vasi1186 joined the chat room.
[6:47pm] vasi1186: .
[6:47pm] YesCT: vasi!
[6:47pm] vasi1186: yes!
[6:47pm] Schnitzel: Hey vasi1186
[6:47pm] GaborHojtsy: YesCT: I guess balintk's UI work
[6:47pm] YesCT:  we were just in d8mi meeting. talking about general status of stuff.
[6:48pm] vasi1186: ok
[6:48pm] YesCT: http://drupal.org/node/1804702
[6:48pm] Druplicon: http://drupal.org/node/1804702 => Display interface translation status => Drupal core, locale.module, normal, needs work, 32 comments, 14 IRC mentions
[6:48pm] GaborHojtsy: yup!
[6:48pm] mzgadzaj left the chat room. (Ping timeout: 260 seconds)
[6:49pm] YesCT: that one looks jump-in-able
[6:49pm] YesCT: vasi1186: are you following any particular feature freeze issue?
[6:50pm] vasi1186: not really at the moment...
[6:50pm] vasi1186: YesCT: if you have something specific, I can check, otherwise I can search for some.
[6:51pm] GaborHojtsy: vasi1186: I think you reviewed the CMI context patch
[6:51pm] GaborHojtsy: vasi1186: if you can keep reviewing it and look at the update, that would be good
[6:51pm] GaborHojtsy: vasi1186: http://drupal.org/node/1763640
[6:51pm] Druplicon: http://drupal.org/node/1763640 => Introduce config context to make config consistent and accessible in different languages => Drupal core, configuration system, major, needs review, 30 comments, 17 IRC mentions
[6:51pm] vasi1186: GaborHojtsy: yes, I reviewed some time ago that patch.
[6:51pm] vasi1186: GaborHojtsy: ok, then I'll continue that
[6:51pm] reyero: GaborHojtsy: about that 'interface translation status' one, I think we should postpone the big one and add a minimalistic one in 'download translations' patch
[6:52pm] balintk: YesCT: I'm planning to continue working on #1804702 on Sunday. We are going to have a DrupalCamp in Budapest this weekend with code sprints on the second day, and GaborHojtsy is holding a D8MI sprint
[6:52pm] reyero: vasi1186: yes, I think latest update addresses the issues you pointed out
[6:52pm] vasi1186: reyero: ok, I'll have a look at that.
[6:52pm] reyero: vasi1186: cool, thanks
[6:53pm] YesCT: balintk: ah, yeah. 4702 would be good for people at the sprint to jump into.
[6:53pm] YesCT: vasi1186: hang around if you can to talk about that one.
[6:54pm] YesCT: I think that just leaves http://drupal.org/node/1498674 that we didn't touch on.
[6:54pm] Druplicon: http://drupal.org/node/1498674 => Refactor node properties to multilingual => Drupal core, node system, critical, needs work, 131 comments, 41 IRC mentions
[6:54pm] GaborHojtsy: YesCT: I was planning to get kalmanhosszu to pair with him on that
[6:54pm] GaborHojtsy: oh, poor 1498674
[6:54pm] GaborHojtsy: so I was lobbying webchick for a few days now to commit http://drupal.org/node/1831444  which is an entryway to fixing other things
[6:54pm] Druplicon: http://drupal.org/node/1831444 => EntityNG: Support for revisions for entity save and delete operations => Drupal core, entity system, normal, reviewed & tested by the community, 21 comments, 8 IRC mentions
[6:55pm] GaborHojtsy: https://docs.google.com/document/d/1Kxj20nJ_MLGm5Cxdm6sQI8gM_299_PODKs69l1bCbis/edit
[6:55pm] GaborHojtsy: ^^^^^^^^
[6:55pm] YesCT: nice. pick.
[6:55pm] YesCT: pic.
[6:56pm] GaborHojtsy: so the revisions patch leads to the dynamic property patch which leads to converting nodes which leads to node properties
[6:56pm] webchick: wooof!
[6:56pm] YesCT: GaborHojtsy: is that something you can post onto 1498674 ?
[6:56pm] Schnitzel: what is? EntityBCDecorator
[6:56pm] webchick: So I got tuck on this:
[6:56pm] penyaskito left the chat room. (Quit: Leaving)
[6:57pm] GaborHojtsy: webchick: so https://docs.google.com/document/d/1Kxj20nJ_MLGm5Cxdm6sQI8gM_299_PODKs69l1bCbis/edit should provide some background info on why http://drupal.org/node/1831444 is key to move on
[6:57pm] Druplicon: http://drupal.org/node/1831444 => EntityNG: Support for revisions for entity save and delete operations => Drupal core, entity system, normal, reviewed & tested by the community, 21 comments, 9 IRC mentions
[6:57pm] webchick: +    // Cast to object as preSaveRevision() expects one to be compatible with the
[6:57pm] webchick: +    // upcoming NG storage controller.
[6:57pm] webchick: +    $record = (object) $record;
[6:57pm] webchick:     $this->preSaveRevision($record, $entity);
[6:57pm] webchick: +    $record = (array) $record;
[6:57pm] webchick: I'm guessing this is just a temporary kludge?
[6:57pm] webchick: Cos that is UUUUGGGLLLYYYY
[6:58pm] GaborHojtsy: webchick: yeah, it would look better with a @todo indeed, there is a host of patches working on introducing similar APIs and unifying them
[6:58pm] webflo left the chat room. (Quit: Leaving.)
[6:59pm] GaborHojtsy: webchick: in light of https://docs.google.com/document/d/1Kxj20nJ_MLGm5Cxdm6sQI8gM_299_PODKs69l1bCbis/edit I'd love to not push it back for a missing @todo  or you can add "@todo Remove this with NG storage controller conversion"
[7:00pm] webchick: Yeah, I'll need to review that in more depth but… I am also needing to hop ona  call now.
[7:01pm] GaborHojtsy: webchick: all right, thanks!
[7:02pm] YesCT: GaborHojtsy: can you post wise things on http://drupal.org/node/1498674 so people know what's up?
[7:02pm] Druplicon: http://drupal.org/node/1498674 => Refactor node properties to multilingual => Drupal core, node system, critical, needs work, 131 comments, 42 IRC mentions
[7:03pm] GaborHojtsy: woooo, wise things
[7:04pm] YesCT:  wise things like. current next steps. or dependencies.. strategy stuff, your picture… whatever.
[7:06pm] YesCT: seems like… 1498674 is waiting on 1818556 which is waiting on… Well I guess that's what the comment from Nov 6 says.
[7:06pm] YesCT: Maybe it just needs someone to post there and say that that is still accurate, if it's still accurate.
[7:08pm] GaborHojtsy: DOING
[7:08pm] GaborHojtsy: http://drupal.org/node/1498674#comment-6759864
[7:08pm] Druplicon: http://drupal.org/node/1498674 => Refactor node properties to multilingual => Drupal core, node system, critical, needs work, 131 comments, 43 IRC mentions
[7:08pm] DesireJM joined the chat room.
[7:08pm] GaborHojtsy: AND removed from sprint and marked postponed
[7:09pm] plach: lol @ wise things
[7:10pm] YesCT:
[7:11pm] YesCT: sweet.
[7:11pm] GaborHojtsy: http://drupal.org/node/1832778 should be RTBC if it comes back green
[7:11pm] Druplicon: http://drupal.org/node/1832778 => Include translation operation in overviews for translatable entities => Drupal core, translation_entity.module, normal, needs review, 55 comments, 23 IRC mentions
[7:12pm] plach: I think wise things has the potential to become Wise Things (tm)
[7:12pm] YesCT: Schnitzel: nice.
[7:13pm] YesCT: plach: ha.
[7:13pm] • YesCT is antsy to talk about details of http://drupal.org/node/1648930
[7:13pm] plach: got to go, guys
[7:13pm] GaborHojtsy: plach: thanks!
[7:14pm] plach: I'm late with some work
[7:14pm] YesCT: maybe people who can talk about the cmi thing can stay after the meeting?
[7:15pm] GaborHojtsy: I can stay!
[7:16pm] GaborHojtsy: so what do you want to talk about on http://drupal.org/node/1648930 ?
[7:16pm] Druplicon: http://drupal.org/node/1648930 => Introduce configuration metadata and use for translation => Drupal core, configuration system, critical, needs review, 225 comments, 106 IRC mentions
[7:16pm] guy_schneerson left the chat room. (Quit: guy_schneerson)
[7:17pm] rvilar left the chat room. (Remote host closed the connection)
[7:18pm] teknico left the chat room. (Remote host closed the connection)
[7:18pm] YesCT: one thing,
[7:18pm] YesCT: to test it. to show that it works to address yched's point about separation of concerns...
[7:19pm] yched joined the chat room.
[7:19pm] YesCT: I think I should be able to make a module, a contrib module like, that adds something to a plugin. and see if it still works for that.
[7:20pm] YesCT: and I think I should be able to simulate adding something into core, like a core update, and show that it doesn't break my contrib module.
[7:20pm] YesCT: yched: just before you got here, I said: "to test it. to show that it works to address yched's point about separation of concerns…"
[7:21pm] GaborHojtsy: yched: hey
[7:22pm] hairqles joined the chat room.
[7:22pm] YesCT: so I have that big picture "how to test" question that I need help nailing down.
[7:22pm] GaborHojtsy: YesCT: I'm not sure we need that amount of deepness in ensuring this, human reviews should be adequate and/or we could adapt later if we find issues
[7:22pm] drupol left the chat room. (Remote host closed the connection)
[7:23pm] YesCT: with all the confusion leading up to getting you, reyero, yched and others even on the same page as to what might or might not be broken about it… I think a concrete example could releave some stress and add clarity.
[7:24pm] YesCT: I'm also thinking about what webchick is going to say when she comes into look at this.
[7:24pm] jacintocapot left the chat room. (Ping timeout: 252 seconds)
[7:24pm] GaborHojtsy: YesCT: the thing is image effects are very concrete
[7:24pm] YesCT: right, but it worked for image effects before...
[7:25pm] GaborHojtsy: YesCT: yeah, well, we cannot really simulate a change and adaptation  we WILL have plenty of change/reuse and adaptation though
[7:25pm] GaborHojtsy: YesCT: once this in in there
[7:25pm] reyero: GaborHojtsy: YesCT: btw, I was updating the issue description to explain this point,
[7:26pm] reyero: and also for all the changes introduced lately (.definition, .include, etc...)
[7:26pm] alexpott left the chat room. (Ping timeout: 264 seconds)
[7:26pm] GaborHojtsy: reyero: good
[7:26pm] GaborHojtsy: ú
[7:27pm] reyero: GaborHojtsy: the thing is the code is actually simpler now, though not sure the 'why' of the metadata format is that easy
[7:29pm] reyero: GaborHojtsy: Oh, I need to update the 'Translation API' part too
[7:30pm] amateescu left the chat room. (Quit: Leaving)
[7:30pm] GaborHojtsy: reyero: not sure the metadata is simpler
[7:30pm] GaborHojtsy: reyero: but it solves more problems
[7:31pm] reyero: GaborHojtsy: I think it is once you grasp some details, there are less files now
[7:32pm] reyero: GaborHojtsy: for most configuration objects everything will be a single file (provided components are defined properly somewhere else)
[7:32pm] GaborHojtsy: reyero: yup
[7:32pm] jacintocapot joined the chat room.
[7:33pm] YesCT: yched: are you feeling like a human review is ok on #226, or wanting to see more proof ? (I'm thinking back to our conversation in irc from before.)
[7:34pm] DesireJM left the chat room. (Quit: Computer has gone to sleep.)
[7:34pm] Haza` is now known as Haza`Aw.
[7:36pm] reyero: hey yched: I hope you like the new (.list, .include) bits, it's all your fault actually
[7:36pm] YesCT:
[7:36pm] YesCT: I'm looking at the new meta files from the latest patch.
[7:38pm] YesCT: config: http://paste2.org/p/2502371, style meta: http://paste2.org/p/2502728, effect image scale meta: http://paste2.org/p/2502731, effect meta: http://paste2.org/p/2502736
[7:40pm] YesCT: style meta: http://paste2.org/p/2502728 is direct from the config: name, label, effects. makes sense.
[7:40pm] Artusamak is now known as Artusamak_afk.
[7:40pm] yched: reyero, GaborHojtsy, YesCT: yeah, I like the new approach much better
[7:40pm] Druplicon: yched: 31 min 42 sec ago <sdboyer> tell yched could use your eyes quickly on the field-related test failures in http://drupal.org/node/1846070 - i'm introducing some new exceptions that are gumming up the works somehow
[7:41pm] yched: reyero: in #217 I was hoping for something like "get rid of the separate file for elements in lists"
[7:41pm] devincarlson left the chat room. (Ping timeout: 260 seconds)
[7:41pm] yched: reyero: I looked at your samples for image styles, but didn't look at the latest patch yet
[7:41pm] yched: reyero: will do and report
[7:42pm] reyero: yched: thanks a lot
[7:42pm] YesCT: name, data, weight, eid under effects are all taken care of. but line 4 bothers me. http://paste2.org/p/2502371#line-4
[7:45pm] reyero: YesCT: it's ugly, isn't it?  but for our purposes it's just an indexing key so nothing to worry about
[7:45pm] GaborHojtsy: yched++
[7:46pm] yched:
[7:46pm] GaborHojtsy: YesCT: it is not something we control
[7:46pm] YesCT: if there were more than one effect for medium, … http://paste2.org/p/2502782 would have it's own meta/image.effect.image_scale.yml and config
[7:48pm] YesCT: GaborHojtsy: but it's ok… just ignored in the meta data, and used as a separator of multiple .. well.
[7:49pm] Schnitzel: GaborHojtsy: short time to discuss the xjm node access stuff?
[7:50pm] GaborHojtsy: Schnitzel: sure
[7:50pm] Schnitzel: GaborHojtsy: I guess this confuses http://pastebin.com/raw.php?i=7mVntC5g
[7:50pm] YesCT: sorry, effects (config) have name, data, weight, ieid. the meta for that is described in meta/image.effect.image_scale.yml and image.effect.%.yml
[7:52pm] YesCT: no. image.effect.image_scale.yml is for the scale stuff.
[7:53pm] GaborHojtsy: Schnitzel: yeah?
[7:53pm] YesCT: i gotta get my brain to do the include.
[7:53pm] Schnitzel: $this->nodes['public_hu_private'] is set by the non language aware module public, and the language aware module sets hu to private
[7:54pm] Schnitzel: and the default language of the node is HU
[7:55pm] Schnitzel: so this would not be changed even we save every languagecode in the grants
[7:55pm] YesCT: effects is a list. the list contains: included stuff and weight and ieid
[7:57pm] YesCT: since it's name is image_scale, it includes the stuff in meta/image.effect.image_scale.yml which includes stuff and data
[7:57pm] GaborHojtsy: Schnitzel: yeah
[7:58pm] YesCT: which specifies image.effect.%.yml and that contains name and data.
[7:58pm] GaborHojtsy: Schnitzel: that is true
[7:59pm] YesCT: the data from image.effect.%.yml does not have a type, so it's a string (not translatable). but that is ignored, because that data is overriden by the data from meta/image.effect.image_scale.yml
[7:59pm] balintk left the chat room. (Quit: ["Textual IRC Client: www.textualapp.com"])
[8:00pm] YesCT: so that makes up the name, data, weight and ieid.
[8:01pm] plach left the chat room. (Ping timeout: 256 seconds)
[8:03pm] Schnitzel: GaborHojtsy: so I guess this is the "downside" of having a language aware node_access module, it could deny access to a lot of versions
[8:03pm] yched: reyero: it seems image.style.%.yml doesn't describe the 'name' property ? no metadata on that ?
[8:03pm] GaborHojtsy: Schnitzel: well, if it denies but a general module grants, it should still grant?!
[8:03pm] GaborHojtsy: Schnitzel: which is xjm's and agentrickard's point
[8:04pm] reyero: yched: that one is in image.effect.%.yml (and gets in there through includes)
[8:04pm] Jungle_Jim_ left the chat room. (Ping timeout: 252 seconds)
[8:05pm] yched: reyero: oh - ok, I keep looking then
[8:05pm] jacintocapot left the chat room. (Ping timeout: 244 seconds)
[8:05pm] Schnitzel: GaborHojtsy: that's not the case node_access_test module only created grants if the node is private
[8:05pm] YesCT: reyero: in http://paste2.org/p/2502731
[8:06pm] Schnitzel: GaborHojtsy: if it is set to public it does not create any grants, so the result of hook_node_access_records() is empty
[8:06pm] YesCT: why is the include at the beggining?
[8:06pm] YesCT: is this that associative array thing again?
[8:06pm] YesCT: seems like it should be between line 3 and 4
[8:07pm] GaborHojtsy: Schnitzel: well, it would need to set grants 1 1 1 1 1
[8:07pm] YesCT: oh, wait. scale is a kind of effect1
[8:07pm] GaborHojtsy: aaand 1
[8:07pm] GaborHojtsy: YesCT: YES
[8:07pm] YesCT: effect!
[8:07pm] reyero: YesCT: something like the metadata for that one is: the generic for image.effect + the specific of image.effect.image_scale
[8:07pm] Schnitzel: GaborHojtsy: mhh I guess this is not implemented, because the creator thought, well if I don't return anything core will create the 1 1 1 1 1 itself
[8:08pm] YesCT: effects in general have name and data.
[8:08pm] YesCT: scale overrides the data.
[8:08pm] GaborHojtsy: Schnitzel: yeah
[8:08pm] GaborHojtsy: Schnitzel: but that is NOT what should happen in core
[8:09pm] reyero: YesCT: at least they should have a name, which is the one we use to know 'which plugin it is', the changes should be in the data mostly for different effects
[8:09pm] 21WAAAAGX joined the chat room.
[8:09pm] GaborHojtsy: Schnitzel: if you do not return anything, then you said "I pass" for the question not "I grant" or "I revoke"
[8:09pm] yched: reyero: so the thing is 'name' and 'data' are really how the ImageStyle ConfigEntity choses to name its entries
[8:09pm] GaborHojtsy: Schnitzel: so if the intention is to grant, then it should return info that it grants
[8:09pm] YesCT: no. image effects have name and data.
[8:09pm] YesCT: the image effect: scale overrides the data
[8:09pm] yched: reyero: they would belong in image.style.% rather than image.effect.*
[8:10pm] Schnitzel: GaborHojtsy: mhh I guess that's the question of the node_access module
[8:10pm] reyero: yched: that's kind of undefined atm, I think, I'd love to have some reusable components example in core
[8:11pm] reyero: yched: however my idea is the array is passed to the plugin, so there should be at least some reusable names in there
[8:11pm] asrob joined the chat room.
[8:11pm] reyero: yched: unless only the data is passed, which I don't know, let me check the image style code
[8:11pm] YesCT: the image style effect adds weight and ieid to whatever generic stuff image effects have.
[8:12pm] Schnitzel: GaborHojtsy: so it should be like this http://pastebin.com/raw.php?i=PnS9iy2U instead of currently http://pastebin.com/raw.php?i=7mVntC5g
[8:12pm] yched: reyero: well, 'data' for instance is a *really* bad choice - image effects don't have 'data', they have settings
[8:12pm] yched: reyero: it so happens that the current CMI format for image styles choses 'data'
[8:12pm] GaborHojtsy: Schnitzel: yeah so i think what xjm and agentrickard said is that if only the default langcode is saved then although the module intended to grant ALL languages probably (because it ignored language), it only granted for fallback
[8:13pm] YesCT: it's their settings data?
[8:13pm] yched: reyero: so 'data' in image.effect.* really hurts the eyes - that's an example of something imposed by the surrounding system
[8:13pm] reyero: yched: um, you are right
[8:13pm] yched: reyero: and there may be several surrounding systems, so they can't impose anything
[8:13pm] Schnitzel: GaborHojtsy: okay, will check, will have Dinner now first
[8:14pm] reyero: yched: though now (i hope) we only need to change the metadata to fix that
[8:15pm] GaborHojtsy: Schnitzel: thanks!
[8:15pm] YesCT: data comes right out of http://paste2.org/p/2502371 core/modules/image/config/image.style.medium.yml
[8:16pm] fago left the chat room. (Ping timeout: 248 seconds)
[8:16pm] attrib left the chat room. (Remote host closed the connection)
[8:16pm] YesCT: so not from this patch.
[8:16pm] yched: reyero: I hope too ?  not fully familiar with what the constraints of the new syntax are
[8:18pm] GaborHojtsy: bad, do not have logs from the first 24 minutes of the meeting  YesCT, maybe you do?
[8:18pm] YesCT: reyero: I think I'm following the way the includes work. and the data typing and in general.
[8:18pm] YesCT: GaborHojtsy: yeah.
[8:18pm] GaborHojtsy: YesCT: can you paste bin that?
[8:18pm] yched: reyero: if, like, really not possible, I guess I could live with 'data' being renamed 'settings', and remain in image.effect.*
[8:18pm] YesCT: reyero: why no .definition at the beginning of core/modules/image/meta/image.style.%.yml http://paste2.org/p/2502728 ?
[8:19pm] yched: reyero: but that would mean changing the image style CMI files too
[8:19pm] YesCT: GaborHojtsy: what time to what time about?
[8:19pm] reyero: yched: something like this, http://paste2.org/p/2502884
[8:19pm] yched: reyero: I mean that last point should be done anyway ('data' -> 'settings' in img styles CMI files)
[8:19pm] reyero: yched: there's a (small) problem though, in the include we are using a key of an outer level
[8:19pm] GaborHojtsy: YesCT: beginning of meeting to 25 in
[8:19pm] GaborHojtsy: 25min
[8:20pm] yched: reyero: ...but doinf it in a separate patch would be better
[8:20pm] yched: reyero: reading
[8:20pm] q0rban left the chat room. (Ping timeout: 245 seconds)
[8:20pm] yched: reyero: I love that
[8:21pm] jessehs joined the chat room.
[8:21pm] yched: reyero: is that a problem ? we're including a file based on a property that's defined in the file where the 'include' lives, sounds legit ?
[8:21pm] YesCT: reyero: http://paste2.org/p/2502736 gives data "Data" which could be "Settings"
[8:21pm] jessehs left the chat room. (Read error: Connection reset by peer)
[8:21pm] jessehs joined the chat room.
[8:21pm] reyero: YesCT: Oh, yes, forgot to tell you, I was about adding label to that but then I realized other metadata files don't have a main label, so we should add it to all / none
[8:21pm] YesCT: GaborHojtsy: oh, right your time is different than mine! timezones! curse you. just one minute.
[8:22pm] yched: reyero: although, your sample has two .include: 'image.effect.[name]' lines ?
[8:22pm] reyero: yched: only in how the variable replacement works atm, I'll need to fix it so values are carried on from to contained elements, minor implementation detail though
[8:24pm] YesCT: GaborHojtsy: http://paste2.org/p/2502902
[8:24pm] reyero: yched: right, the first one should be gone
[8:25pm] yched: reyero: ok, makes sense then
[8:25pm] yched: reyero: well, if implementation is doable, that looks great
[8:25pm] GaborHojtsy: YesCT: thanks, fixed the timezone in the text
[8:27pm] • YesCT likes it when yched says "that looks great"
[8:28pm] yched: YesCT: heh, I feel like a PITA :P
[8:28pm] GaborHojtsy: yched++
[8:28pm] YesCT: are you kidding?! you've been great.
[8:29pm] • GaborHojtsy will cut log here