[6:01pm] GaborHojtsy: heyho, meeting time :)
[6:01pm] GaborHojtsy: who is here?
[6:01pm] jhodgdon: here for a few minutes
[6:01pm] GaborHojtsy: jhodgdon: wanna start then?
[6:01pm] jhodgdon: ok
[6:01pm] jhodgdon: I was on a road trip for most of the last week so I didn't work on anything.
[6:02pm] jhodgdon: What I plan to do in the next week is https://www.drupal.org/node/2217569
[6:02pm] Druplicon: https://www.drupal.org/node/2217569 => Fields row plugin: Translation is non-uniform for base fields, Field UI fields, links; no way to choose "this row's language" [#2217569] => 43 comments, 16 IRC mentions
[6:02pm] jhodgdon: and we could still use feedback on https://www.drupal.org/node/2357995
[6:02pm] jhodgdon: that's it!
[6:02pm] Druplicon: https://www.drupal.org/node/2357995 => De-obfuscate entity row language rendering settings in views [#2357995] => 11 comments, 7 IRC mentions
[6:02pm] franSeva: \o
[6:02pm] naveenvalecha joined the chat room.
[6:02pm] GaborHojtsy: jhodgdon: yeah we did not get feedback on the later one...
[6:03pm] jhodgdon: I noticed. :)
[6:03pm] GaborHojtsy: I think martinFrances said would review https://www.drupal.org/node/2357995? :)
[6:03pm] Druplicon: https://www.drupal.org/node/2357995 => De-obfuscate entity row language rendering settings in views [#2357995] => 11 comments, 8 IRC mentions
[6:03pm] GaborHojtsy: jhodgdon++
[6:04pm] GaborHojtsy: attrib, franSeva, martinFrances, penyaskito, plach, Schnitzel, webflo1, YesCT: hi!
[6:04pm] YesCT: hi
[6:04pm] Druplicon: privet
[6:04pm] plach: hey
[6:04pm] Druplicon: privet
[6:04pm] Druplicon: plach: 16 hours 48 min ago <franSeva> tell plach I have a doubt about your review related with obtain 'langcode' through getKey('langcode')
[6:04pm] Druplicon: plach: 16 hours 45 min ago <franSeva> tell plach I forgot the url https://www.drupal.org/node/2230637#comment-9290545
[6:05pm] franSeva: hi!
[6:05pm] YesCT: GaborHojtsy: thought you might have run into internet trouble.
[6:06pm] GaborHojtsy: jhodgdon: also provided longer feedback to hyou on https://www.drupal.org/node/2358923#comment-9292761
[6:06pm] Druplicon: https://www.drupal.org/node/2358923 => Config translation module cannot deal with different base path [#2358923] => 8 comments, 3 IRC mentions
[6:06pm] jhodgdon: GaborHojtsy: k
[6:06pm] GaborHojtsy: franSeva: wanna go next?
[6:06pm] franSeva: GaborHojtsy, sure
[6:06pm] franSeva: franSeva, focus?
[6:07pm] franSeva: franSeva focus?
[6:07pm] Druplicon: franSeva focus is https://www.drupal.org/node/2230637 &&  && READ THIS ISSUE RELATED WITH LANGUAGE_SHOW FLAG https://www.drupal.org/node/2355909  && https://www.drupal.org/node/1879930  --> redo changes  && https://www.drupal.org/node/2364863
[6:07pm] franSeva: yeah
[6:07pm] jhodgdon: GaborHojtsy: consider me enlightened. Summary: more of a mess than I even suspected. :)
[6:07pm] franSeva: GaborHojtsy, basically I've been working in Language widget https://www.drupal.org/node/2230637
[6:07pm] jhodgdon: ok I need to run off
[6:07pm] Druplicon: https://www.drupal.org/node/2230637 => Create a Language widget [#2230637] => 62 comments, 25 IRC mentions
[6:07pm] jhodgdon: have a good meeting
[6:07pm] jhodgdon is now known as jhodgdon-afk.
[6:07pm] franSeva: GaborHojtsy, in plach  and yched reviews
[6:07pm] jhodgdon-afk: GaborHojtsy++
[6:07pm] franSeva: GaborHojtsy,and currently I have a doubt with a plach review
[6:07pm] penyaskito is now known as penyascar.
[6:08pm] plach: franSeva: atm there's no langcode key, but we have to introduce it
[6:08pm] franSeva: plach, ooki
[6:08pm] plach: I think in D7 we have it IIRC
[6:08pm] franSeva: plach, I'll check how to do it :)
[6:09pm] plach: franSeva: do you want to do that in this issue?
[6:09pm] plach: probably a dedicated issue would be better
[6:09pm] franSeva: plach, maybe good have a dedicated issue
[6:10pm] plach: yep
[6:10pm] franSeva: plach, for me there is np
[6:10pm] franSeva: GaborHojtsy, in other hand, yched propose use a hook
[6:10pm] franSeva: GaborHojtsy, hook_field_widget_form_alter
[6:11pm] plach: but still we should be prepared for that, call it pro-active coding ;)
[6:12pm] franSeva: plach, :)
[6:12pm] roderik_ left the chat room. (Remote host closed the connection)
[6:12pm] franSeva: so I think my next step in the issue will be work in hook_field_widget_form_alter but I don't  know if it is in scope
[6:13pm] das-peter left the chat room. (Ping timeout: 260 seconds)
[6:13pm] franSeva: GaborHojtsy,  plach  what do you think?
[6:13pm] GaborHojtsy: franSeva: I was honestly not following the issue too closely, looks like plach is providing you expert feedback there :)
[6:14pm] plach: franSeva: didn't yched take back that part of his review in #59
[6:14pm] plach: ?
[6:14pm] reyero joined the chat room.
[6:15pm] franSeva: plach, oouch I understood the opposite!!
[6:15pm] penyascar is now known as penyaskito.
[6:16pm] penyaskito: hi there, sorry for being late
[6:16pm] plach: altough I'm honestly not sure about that: hook_field_widget_form_alter() looked like the right place to alter the widget as there we can be sure of the array structure
[6:16pm] plach: franSeva: ^
[6:17pm] plach: maybe we could do that and add some code in the validation handler to check that the selected language code is avlid
[6:17pm] plach: that way if the widget has been changed and thus is not altered we still rpevent wrong codes from being picked up
[6:17pm] franSeva: plach, ok
[6:18pm] plach: franSeva: let's wait for yched before coding this, I'll post it on the issue
[6:18pm] franSeva: plach, ok
[6:18pm] GaborHojtsy: franSeva++
[6:18pm] plach: franSeva++
[6:18pm] roderik joined the chat room.
[6:18pm] plach: franSeva: maybe you could focus on test failures for now? :)
[6:18pm] franSeva: plach, sure
[6:18pm] plach: thanks!
[6:18pm] GaborHojtsy: franSeva: I took on fixing https://www.drupal.org/node/1879930 and have YesCT reviewing so I think that should be fine and finally land this week I hope
[6:19pm] Druplicon: https://www.drupal.org/node/1879930 => Language selectors are not showing localized to the page language [#1879930] => 147 comments, 52 IRC mentions
[6:19pm] YesCT: yep.
[6:19pm] penyaskito: jhodgdon++
[6:19pm] penyaskito: franSeva++
[6:19pm] penyaskito: plach++
[6:19pm] franSeva: GaborHojtsy, thanks
[6:19pm] franSeva: GaborHojtsy, it's been imposible attend that issue
[6:19pm] franSeva: plach++
[6:19pm] GaborHojtsy: franSeva: yeah there were lots of low level intricacies in how it worked or not worked :D
[6:20pm] GaborHojtsy: plach: ok, wanna be next while we have your attention?
[6:21pm] jsbalsera left the chat room. (Ping timeout: 260 seconds)
[6:21pm] plach: GaborHojtsy: ok
[6:22pm] plach: I've been in the US for work, so didn't have the chance to do much
[6:22pm] plach: basically I've been reviewing stuff
[6:22pm] plach: and addressed fago's review in https://www.drupal.org/node/1916790#comment-9195335
[6:22pm] Druplicon: https://www.drupal.org/node/1916790 => Convert translation metadata into regular entity fields [#1916790] => 104 comments, 16 IRC mentions
[6:22pm] plach: I'd liekt to have it back to RTBC but he didn't show up yet
[6:23pm] plach: and since I didn't address each part of his review the way he suggested to, I'm not sure it's actually RTBC
[6:23pm] plach: any feedback on https://www.drupal.org/node/1916790#comment-9266099 is welcome
[6:24pm] Druplicon: https://www.drupal.org/node/1916790 => Convert translation metadata into regular entity fields [#1916790] => 104 comments, 17 IRC mentions
[6:24pm] plach: as soon as I've a chance I'd like to work on https://www.drupal.org/node/2232477 which is semi-blocking it
[6:24pm] Druplicon: https://www.drupal.org/node/2232477 => Remove 'not null' => TRUE from field item schemas [#2232477] => 30 comments, 4 IRC mentions
[6:25pm] plach: and that's all :)
[6:25pm] YesCT: :)
[6:25pm] plach: GaborHojtsy: oh, I'm also helping berdir with https://www.drupal.org/node/2363099
[6:25pm] Druplicon: https://www.drupal.org/node/2363099 => Translating field definition descriptions results results in different schema definitions, resulting in update.php changes [#2363099] => 15 comments, 3 IRC mentions
[6:25pm] plach: your feedback there would be welcome
[6:26pm] plach: (it's critical :)
[6:28pm] GaborHojtsy: plach: oh, ok I’ll see what I can do
[6:28pm] GaborHojtsy: plach++
[6:28pm] franSeva: plach++
[6:28pm] alexpott left the chat room. (Quit: Leaving...)
[6:28pm] GaborHojtsy: in fact I think we brainstormed options for the last one with alexpott and berdir a few days back
[6:29pm] plach: GaborHojtsy: oh, ok
[6:29pm] GaborHojtsy: no bright solutions though :/
[6:29pm] plach: "I am wondering whether it would make sense to have an additional method on StringTranslationTrait, for instance StringTranslationTrait::nt($string), that would return the string as is but that would make it discoverable by potx/l10n server."
[6:29pm] GaborHojtsy: basically potx will need special rules for this
[6:29pm] plach: GaborHojtsy: ^
[6:30pm] GaborHojtsy: plach: yeah a no-op function came up a few times
[6:30pm] sebcorbin is now known as sebcorbin`away.
[6:30pm] GaborHojtsy: plach: its painful to need to slow down Drupal for potx parsing reasons
[6:30pm] plach: but... ? ;)
[6:30pm] GaborHojtsy: plach: so long as we can keep the special cases controlled we can make them parsed
[6:30pm] plach: those definitions are cached
[6:30pm] GaborHojtsy: plach: not sure if PHP optimizes no-op functions in some way, likely not
[6:31pm] GaborHojtsy: plach: yeah that is true
[6:31pm] roderik left the chat room. (Remote host closed the connection)
[6:31pm] GaborHojtsy: plach: that may be a very good argument for a nt() :D
[6:31pm] plach: I think the no-op approach is useful if used with care
[6:31pm] GaborHojtsy: ok
[6:32pm] plach: anyway, I didn't know you were aware of that issue, fine with anything you come up with ;)
[6:33pm] GaborHojtsy: plach: posted https://www.drupal.org/node/2363099#comment-9292863 quickly
[6:33pm] GaborHojtsy: plach++
[6:33pm] Druplicon: https://www.drupal.org/node/2363099 => Translating field definition descriptions results results in different schema definitions, resulting in update.php changes [#2363099] => 15 comments, 4 IRC mentions
[6:33pm] GaborHojtsy: YesCT: wanna go next?
[6:34pm] YesCT: sure.
[6:34pm] YesCT: I did a bunch of posts to get the upcoming sprints section of my new blog (that I still need to publish today) done.
[6:34pm] YesCT: sprint weekend?
[6:35pm] Druplicon:  Jan. 17-18, 2015. Add your local event! https://groups.drupal.org/node/447258 | Resources for planners: https://www.drupal.org/core-mentoring/sprint-resources | Preparation tips: http://www.comm-press.de/en/blog/preparations-global-sprint-weekend-march-9-and-10
[6:35pm] YesCT: bogota?
[6:35pm] plach: GaborHojtsy++
[6:35pm] Druplicon: DrupalCon Latin America in Bogota, 10-12 Feb https://latinamerica2015.drupal.org | EXTENDED SPRINTS 8-13 Feb. Sign up: https://docs.google.com/spreadsheet/ccc?key=0AtDYnjV5l0uydEVCVTRjYzhkXzF6N05WelRrZlAxNnc#gid=0
[6:35pm] YesCT: oh, need to put that there.
[6:35pm] YesCT: https://groups.drupal.org/node/447308
[6:35pm] Druplicon: https://groups.drupal.org/node/447308 => All the sprints at and around DrupalCon Latin America Bogotá => 0 comments, 1 IRC mention
[6:35pm] YesCT: I need to get some details filled in.
[6:36pm] YesCT: also
[6:36pm] YesCT: badcamp?
[6:36pm] Druplicon: badcamp is the Bay Area Drupal Camp http://badcamp.net/ Nov (5) 6 - 9 (10) Sign up for sprints (all the days) in https://docs.google.com/spreadsheet/ccc?key=0AtDYnjV5l0uydEJ1Mm9sZjh1Z2h6dDI2eXR2QTgwMlE#gid=0 and is also fun things in https://docs.google.com/spreadsheets/d/1uwtleCZVXbIwxp_bvhI8YGRCBeZv3VJRdkOwOikc17k/edit#gid=0
[6:36pm] YesCT: and I'm having a difficult time managing issues again.
[6:36pm] YesCT: even with some gmail tricks.
[6:37pm] YesCT: so, if anyone had work they feel is close and wants reviews... remember to ping people, or ask in #drupal-contribute (or here if attending the meeting)
[6:38pm] YesCT: I will finish a review on https://www.drupal.org/node/1879930
[6:38pm] YesCT: GaborHojtsy: about your latest change.
[6:38pm] YesCT: that is pretty cool.
[6:38pm] YesCT: to avoid the double filtering.
[6:38pm] Druplicon: https://www.drupal.org/node/1879930 => Language selectors are not showing localized to the page language [#1879930] => 147 comments, 53 IRC mentions
[6:38pm] YesCT: but maybe that logic should go in the filter method?
[6:39pm] das-peter joined the chat room.
[6:39pm] GaborHojtsy: YesCT: well, this also avoids calling the method :)
[6:39pm] GaborHojtsy: YesCT: we can do it either way
[6:39pm] YesCT: or ... is it special that state all means we can skip the filtering just in the core language manager?
[6:39pm] GaborHojtsy: YesCT: all language managers should skip the filtering
[6:39pm] YesCT: I think it is more future us proof, if it is still correct, to do it in the method.
[6:39pm] GaborHojtsy: YesCT: if STATE_ALL
[6:39pm] YesCT: then we dont have to know what code to copy and paste
[6:40pm] GaborHojtsy: YesCT: sure, please comment that on the issue so I can post an update :)
[6:40pm] YesCT: :)
[6:40pm] GaborHojtsy: I hope to close this one out so we can forget about it for good :D
[6:40pm] YesCT: yeah!
[6:40pm] penyaskito: plach++
[6:40pm] penyaskito: YesCT++
[6:40pm] YesCT: I can focus on this issue for the next 3 hours.
[6:42pm] GaborHojtsy: YesCT: perfect, thanks
[6:42pm] tstoeckler left the chat room. (Ping timeout: 240 seconds)
[6:42pm] GaborHojtsy: YesCT: for Bogota sprints, Holly responded to me on twitter that the Fri sprint will be in the venue
[6:42pm] GaborHojtsy: YesCT: cannot find the tweet now for some reason jsut wanted to relay that info
[6:42pm] YesCT: GaborHojtsy++
[6:43pm] penyaskito: GaborHojtsy: YesCT: Because it was Stephanie https://twitter.com/stephelhajj/status/525658253246885888
[6:44pm] GaborHojtsy: oh hahum
[6:44pm] roderik joined the chat room.
[6:44pm] GaborHojtsy: right
[6:44pm] GaborHojtsy: YesCT++
[6:44pm] YesCT: :)
[6:44pm] GaborHojtsy: penyaskito: hey wanna go next then? :)
[6:44pm] penyaskito: GaborHojtsy: sure
[6:44pm] penyaskito: Hi there everyone :)
[6:45pm] penyaskito: This week I worked with GaborHojtsy doing tests for session negotiation, and it was committed https://www.drupal.org/node/2359879
[6:45pm] Druplicon: https://www.drupal.org/node/2359879 => Session negotiation settings cannot actually be changed on the UI [#2359879] => 14 comments, 5 IRC mentions
[6:47pm] webflo1 left the chat room. (Quit: Leaving.)
[6:47pm] penyaskito: also worked on https://www.drupal.org/node/2355909 with help from alexpott, and got very helpful reviews from several people, plach berdir effulgentsia dawehner et al
[6:47pm] cbeier joined the chat room.
[6:47pm] Druplicon: https://www.drupal.org/node/2355909 => language.settings config is not scalable [#2355909] => 65 comments, 29 IRC mentions
[6:47pm] plach: penyaskito++
[6:47pm] penyaskito: for this week I plan to keep working on that, so we have one critical less :))
[6:47pm] GaborHojtsy: penyaskito: superb plan :)
[6:47pm] penyaskito: and also on https://www.drupal.org/node/2364171, which already has a test from GaborHojtsy
[6:48pm] Druplicon: https://www.drupal.org/node/2364171 => Enabling and configuring content language negotiation does not work at once [#2364171] => 10 comments, 2 IRC mentions
[6:48pm] penyaskito: this one is "only" major
[6:48pm] penyaskito: and that's it
[6:48pm] candela joined the chat room.
[6:48pm] franSeva: penyaskito++
[6:49pm] GaborHojtsy: penyaskito++
[6:49pm] GaborHojtsy: penyaskito: that last one is a really strange beast...
[6:50pm] GaborHojtsy: reyero: I see you arrived :) wanna go next?
[6:50pm] penyaskito: GaborHojtsy: my guts say that must be similar to alexpott solution to the failure on language.settings
[6:50pm] penyaskito: GaborHojtsy: I think Im somehow close debugging
[6:50pm] reyero: GaborHojtsy, hi
[6:50pm] GaborHojtsy: penyaskito: so it was not “that easy” then?
[6:51pm] reyero: GaborHojtsy, nothing new, re-rolling atm https://www.drupal.org/node/2298687
[6:51pm] Druplicon: https://www.drupal.org/node/2298687 => Fix interfaces implemented by Sequence/Mapping. Add a specific interface. Simplify both. [#2298687] => 40 comments, 13 IRC mentions
[6:51pm] penyaskito: GaborHojtsy: Im at core/modules/language/src/LanguageNegotiator.php, saveConfiguration(), the enabled methods are not arriving correctly, but the form has the sent data correctly
[6:53pm] penyaskito: GaborHojtsy: the test failure fixed by alexpott? was the #submit callbacks order
[6:53pm] GaborHojtsy: reyero: can you take a look at https://www.drupal.org/node/2144413? :)
[6:53pm] Druplicon: https://www.drupal.org/node/2144413 => Config translation does not support text elements with a format [#2144413] => 168 comments, 20 IRC mentions
[6:53pm] GaborHojtsy: reyero: tstoeckler was very active there
[6:54pm] reyero: GaborHojtsy, sure, I was waiting for that one :-)
[6:55pm] GaborHojtsy: reyero: that would be perfect
[6:55pm] GaborHojtsy: reyero: I would love to look at https://www.drupal.org/node/2298687 but that figure we talked about last week would help a lot :)
[6:55pm] Druplicon: https://www.drupal.org/node/2298687 => Fix interfaces implemented by Sequence/Mapping. Add a specific interface. Simplify both. [#2298687] => 40 comments, 14 IRC mentions
[6:56pm] reyero: GaborHojtsy, y, it's late... but coming..
[6:57pm] GaborHojtsy: reyero: great, thanks a lot
[6:57pm] penyaskito: reyero++
[6:57pm] roderik left the chat room. (Remote host closed the connection)
[6:58pm] GaborHojtsy: missing herom, sebcorbin and vijaycs85
[6:58pm] GaborHojtsy: anybody else I forgot to call? :)
[7:00pm] tstoeckler joined the chat room.
[7:00pm] penyaskito: tstoeckler: hey :)
[7:01pm] GaborHojtsy: tstoeckler: hey, here for the meeting?
[7:03pm] GaborHojtsy: well, no
[7:03pm] GaborHojtsy: thanks all for coming then :)
[7:04pm] GaborHojtsy: reyero++
[7:04pm] penyaskito: GaborHojtsy++
[7:04pm] franSeva: GaborHojtsy++
[7:04pm] penyaskito: GaborHojtsy++
[7:04pm] franSeva: reyero++
[7:04pm] GaborHojtsy: penyaskito++
[7:04pm] franSeva: penyaskito++
[7:04pm] franSeva: YesCT++
[7:04pm] GaborHojtsy: YesCT++
[7:04pm] GaborHojtsy: franSeva++
[7:04pm] franSeva: jhodgdon++
[7:04pm] GaborHojtsy: jhodgdon++
[7:04pm] franSeva: plach++
[7:04pm] GaborHojtsy: plach++
[7:04pm] cjoy joined the chat room.
[7:04pm] YesCT: GaborHojtsy++
[7:04pm] YesCT: franSeva++
[7:04pm] YesCT: plach++
[7:05pm] YesCT: reyero++
[7:05pm] YesCT: jhodgdon++
[7:05pm] YesCT: penyaskito++
[7:05pm] penyaskito: d8mi++
[7:05pm] penyaskito: d*mi++
[7:05pm] YesCT: d*mi++
[7:05pm] franSeva: d8mi++
[7:06pm] franSeva: d*mi++
[7:06pm] franSeva: bye!
[7:06pm] Druplicon: see you later franSeva
[7:06pm] plach: *++ ;)
[7:06pm] franSeva left the chat room. (Quit: Leaving)
[7:07pm] roderik joined the chat room.
[7:07pm] GaborHojtsy: d8mi++
[7:09pm] rvilar left the chat room. (Ping timeout: 258 seconds)
[7:10pm] attrib left the chat room. (Remote host closed the connection)
[7:12pm] rteijeiro left the chat room. (Remote host closed the connection)
[7:16pm] naveenvalecha_ joined the chat room.
[7:16pm] naveenvalecha left the chat room. (Read error: No route to host)
[7:19pm] vijaycs85 joined the chat room.