The signatures debacle

Events happening in the community are now at Drupal community events on www.drupal.org.
webchick's picture

So, my holy war ever since I started with Drupal has been to Fix signatures.

I'll try and sum this up as best I can. ;)

There are three main complaints about signatures from people with a phpBB background:

  1. Signatures don't show up on forum topics, only on forum replies.
  2. The signatures show up in the comment text box as you're creating (and editing) your reply.
  3. Signatures are not dynamic; when people update their signatures, they expect it to update on all of their old posts.

So, my goal is to make three patches to core to solve these problems:

  1. Allow turning signatures on/off per node type. If they're on, you see signatures on both nodes and their replies. - I'm not sold on this anymore, and neither is Dries. Doing a different approach now which is to make forums the exception.
  2. Take 'em out. :P Make 'em themable.
  3. Render signatures on output. Might need to put a toggle in here for this.

That's my plan. Any thoughts?

Update: http://drupal.org/node/130366 is an initial patch that attempts to solve problems 2 and 3. Reviews appreciated! Success! :D This patch will be in the forth-coming Drupal 6!

Update: http://drupal.org/node/132446 attempts to address issue 1. Reviews appreciated!

Comments

Love it

michelle's picture

I don't have the skills to help you, but I want to offer you moral support. :) I hope you get your way with this because it makes a lot more sense than what's there now. The signature module seems ok, but I'd love to have one less module on my already module heavy site.

Michelle

Aw, thanks. :D

webchick's picture

Aw, thanks. :D

One more thought

arkepp's picture

One more thought: Make it possible for each user to turn on / off whether (s)he sees the signatures of other users.

May not seem like a big deal, but in some forums people like to put big pictures and long hardware bragging lists in their signatures. It kills readability.

Second that

michelle's picture

I'm on a mommy board with some horribly huge signatures. It has that option and I've been tempted on occasion to use it.

Michelle

That sounds like a good contributed module...

webchick's picture

I'd rather to leave it simple for core.

If anyone's interested in such a thing though, it will be possible once http://drupal.org/node/130366 goes in. Reviews would be appreciated! :D

On a related note, somewhere

Toe's picture

On a related note, somewhere down the line it would be nice to be able to limit the size of signatures. Like making it no more than 3 lines, or disabling images in signatures.

Now that the DrupalCon/OSCMS

Gman's picture

Now that the DrupalCon/OSCMS summit is over, I can look at this stuff properly. Will give input on the issue page.

Dynamic signatures have landed!

webchick's picture

http://drupal.org/node/130366 was committed today, and will be in the forth-coming Drupal 6. Hooray!

Please keep an eye on http://drupal.org/node/132446, which will allow signatures to be turned on/off per node type.

Awesome!

michelle's picture

Thanks for all your hard work on this. :)

Michelle

Thanks

Mark - UK's picture

I'm from a phpbb background (http://www.auctioncut.com) and new to drupal. I certainly appreciate where your coming from webchick & your efforts, Allow members to have signatures can really encourage them to post more. I welcome any such patches.