Posted by stevebayerin on February 8, 2008 at 3:19pm
When a site admin goes to Admin>Site Configuration>Input Formats and choses the configure option for a input format, the admin lands on the view page instead and has to click configure one more time on the horizontal tabs. To avoid heavy changes, I think the Operation on Admin>Site Configuration>Input Formats could be renamed from 'Configure' into 'View Settings'
The group may not be the best place to post the above but I thought I might as well state a possible improvement than leave it for later and overlook the issue.
Comments
sounds good to me
I followed your workflow and agree it's kind of silly. So, the proposal to change it from "configure" to "view settings" or maybe "edit settings" sounds great to me. I suggest you post a patch - http://drupal.org/patch/create to the Drupal issue queue. Be sure it's for 7.x. It's too late to get string changes into 6.x.
--
Open Prediction Markets | Drupal Dashboard
knaddison blog | Morris Animal Foundation
Creating a patch would take
Creating a patch would take a bit of time for me to do so I have posted a feature request for the same in Drupal 7 in the Issue queue.
well
It does take some time to learn to make patches, but in the end it is a time saver (see Jody Hamilton's post). "It turns out the only difference between being a frightful Drupal hacker and an esteemed Drupal contributor is whether or not you submitted a patch."
Also, maybe you could update your comment to include a link to the issue?
--
Open Prediction Markets | Drupal Dashboard
knaddison blog | Morris Animal Foundation
Well here's a link to the
Well here's a link to the issue posted:
http://drupal.org/node/219584
I went into CVS (Using Tortoise CVS for Win) but there were no files for Drupal 7 ( I assume coding hasn't started because HEAD seemed to be based on 6.)
I had a look at whats in Drupal 5 and then realized I didn't know where to start so went ahead and posted a feature request for Drupal 7.
Right now it seems to me that the filter.module is what I ought to be looking at. After a few read throughs it looks like lines 319 for filter.module in drupal 5.6 could be the title I need to change.
-- $form[$format->name]['configure'] = array('#value' => l(t('configure'), 'admin/settings/filters/'. $id));
++ $form[$format->name]['configure'] = array('#value' => l(t('view configuration'), 'admin/settings/filters/'. $id));
I tested it on an a live drupal install and it works. I just need to format the patch correctly for Drupal 5 and 6, (and 7 if I can find it in CVS.)
Edit: An additional operation (edit filter) could be added to the available operations on admin/settings/filters giving a total of 3 possible operations (if re-order filters is not included):
View Configuration
Edit Filters
Delete
[scratch everything here] 2nd Edit: View Configuration isn't entirely accurate, Select Filters may be a more appropriate replacement because users actually select the filters on that page instead of only viewing them. Line 318 in filter.module for Drupal 5.6 should be
$form[$format->name]['configure'] = array('#value' => l(t('select filters'), 'admin/settings/filters/'. $id)); [/scratch everything here] Select filters is inaccurate too because the user can select the filters as well as select the user roles for which the filters are applied to.
Patches have been submitted
Patches have been submitted on http://drupal.org/node/219584 (Do I need to give the patch for each Drupal generation (5.7,6.0 RC4) a separate thread???)
Tortoise CVS for windows and its documentation on d.o sure makes things easy.
Steve, CVS HEAD is for
Steve,
CVS HEAD is for drupal 7 development, although I believe it's currently the same or very similar to the DRUPAL-6 CVS branch which was created about a week ago. Since Keith.smith has set this as a bug in d6, create patches for drupal6. Later it can also be applied and/or rerolled for other versions if required.
I have tested your patch and commented on the issue node.
Bevan/
Bevan/