Posted by webchick on August 22, 2010 at 4:58pm
We talked about at the Drupalcon CPH Core Developer Summit about needing more volunteers to handle the CVS application requests queue, and in the future the Git project release review queue.
Alan Palazzolo zzolo has offered to help mentor anyone interested in taking on this critically important role.
Please leave a comment here to get on the list, and hopefully Alan will post back with other instructions. :) The basic gist of what we currently require is at http://drupal.org/cvs-application/requirements.
Comments
Count me on!
Count me on!
SumitK
www.sumitk.net
me too
Yes, I want to help with this. While learning how to review other peoples project I want to spend time on documenting this process and for example make a checklist which developers can use to review their own code. Of course this is interwoven with codestyle documentation, coder module etc.
#nom!
Review code? This I can do. Major #noms!
Of course
I'll gladly review code for those wanting to contribute!
List me
This makes more sense than offering people co-maintainerships, which was the only way i knew to get people through the process before ;-)
benjamin, agaric
Yeah I can do that... my
Yeah I can do that... my nitpicking is top-notch. Send me a mail. ;)
I'm in
I'd love to help out
http://www.thomasturnbull.com
http://twitter.com/thomasturnbull
I’m in
I’d like to help out :)
At your service
Would be glad to help out.
help
let me check then i told you about that
Count me in.
Count me in.
I'd like to help, assuming
I'd like to help, assuming there's no requirement to have a CVS account... I promise not to approve my application. :)
Sr. Vice President | NorthPoint Digital | northpointdigital.com| 212-819-1700
I'd like to help, assuming
I'd like to help, assuming there's no requirement to have a CVS account... I promise not to approve my application. :)
Sr. Vice President | NorthPoint Digital | northpointdigital.com| 212-819-1700
How you can help
So, I dont have too much time at the moment, but want to get something up. Please feel free to come talk to me at DrupalCon CPH if you are here.
It's a fairly basic process, simply review for the following;
And as somewhat that wants to be helpful and be a mentor, here is my personal advice to the process:
--
zzolo
Themers!
Oh, also, themers would be great to have since some people apply with themes, which is awesome, but can be tough for someone like me to be a good reviewer of it. Also, I don't really know all the best resources for themers.
--
zzolo
Count me in too, I would love
Count me in too, I would love to help with this effort.
BoF!
So, if you want an introduction, I just set a BoF:
http://cph2010.drupal.org/sessions/help-drupal-grow-reviewing-cvsgit-app...
We'll probably have time for you to do your first review, too!
I hope to see you all there.
--
zzolo
I'm down too.
I'm down too.
I'm in too, great bof btw :)
I'm in too, great bof btw :)
I'm in!
I'm in!
How to review doc started
I'll do something more official when I get the docs finished and reviewed by some others. But for now, I am putting together the following documentation for potential reviewers (and as a reference), as started by the BoF mentioned above:
http://drupal.org/node/894256
Thanks all for the help!
--
zzolo
me too
I would like to help out as well if possible.
So get to work reviewing CVS applications!
So all of you who signed up.... You can start now!
There are more than 50 applications in "Needs review" in the CVS Application queue
zzolo explained what to do above.
Essentially, review some people's applications (using the criteria zzolo mentioned). All you really have to do is make sure they understand the rules, have mostly come through on the guidelines, and get them going. We're trying to keep people out who shouldn't be here, not people who should. And they don't have to be perfect.
It would be wonderful if we could get this queue down to a manageable size. And with as many of you as signed up, that should be possible.
THANKS FOR THE HELP!
I'm doing reviews since the
I'm doing reviews since the BoF of CPH :) and I'm using this resources in my reviewer toolbox :)
CVS Application requirements
Writing info files
Writing secure code
Header comment blocks
Coder module
zzolo's fantastic guide in his blog
I have a question about the process, when an application is RTBC? one reviewer is enough?
First draft of guide is done
So, I havent blogged about it yet and made it more "official", but the handbook page is pretty much done. It should be all you need to get started. Let me know if you have any suggestions or go ahead and edit directly.
How to Review CVS Applications!
I am hoping to get a checkbox on the Drupal.org profiles for something like "I reviewed CVS applications", then I would like to try to make a push with a blog post and other things about this new tutorial to ramp up participation.
http://drupal.org/node/897150
@pcambra, if you are happy with your review and think the module is ready to go, just mark as RTBC and someone will get around to approving it. If you feel your review is good enough, then we'll (most likely) back you!
Many thanks to all who have helped out.
--
zzolo
I volunteer as a beta tester
There is a module we worked on this summer that we would like to share back with the community.
Wanted to pledge this commitment: I will try (for the third time!) to get a CVS account & all the new Git stuff. I will blog about the process & give feedback as I am able.
As a CVS account burn victim, I want you all to know that I appreciate your efforts of making it easier for us to contribute.
I can't for the life of me
I can't for the life of me find if there are any notes on the little git standup from the Core Dev Summit... if anyone knows where they're posted, can you pls drop a link at: http://drupal.org/node/703116 thx!
Git/Project privileges and application process
I answered in the issue what I believe the outcome was.
dont think there are any at the moment
Hey @arianek. I don't think notes were put anywhere (at least that I know of). I don't want to point fingers, but I am pretty sure, Sam said he would put up notes. Either way, we should put up something about what was decided somewhere.
--
zzolo
Finger-pointing is fine, I'm
Finger-pointing is fine, I'm pretty sure I did forget to put up at least some notes. All I got to was the summary of the process we came to, not notes on what actually went down. I'll try my best to recreate it tomorrow.
You're missing the party
Hi Sam - the party seems to have continued without you. http://drupal.org/node/703116#comment-3659474 and then it got moved into the Great Git Migration at http://drupal.org/node/961144
Hiya zzolo :) I do recall
Hiya zzolo :) I do recall that as well... I didn't take notes during the session, so I wouldn't trust myself to remember all of the details this far along, though I do remember the gist of some of the main points...
Awesome!
Hi @gdzine. Great to hear. To get started, check this out: http://drupal.org/node/894256
Also, I am trying to start up a group here for code reviewing: http://groups.drupal.org/code-review (pending approval)
--
zzolo
New git-based process
Also, for those interested, the new Git-based process is being hashed out here: http://drupal.org/node/961144
--
zzolo
For that matter, seems like
For that matter, seems like we need a few people who can add CVS access to accounts. There are 14 RTBC'ed CVS applications waiting to have the access added:
http://drupal.org/project/issues/cvsapplications?status=14
Brian Vuyk
Senior Developer, PINGV Creative
bv@pingv.com | (315) 849-9733 | Skype: brianvuyk
I can start going through the
I can start going through the RTBCs today.
Senior Drupal Developer for Lullabot | www.davereid.net | @davereid
Actually, looks like Michelle
Actually, looks like Michelle ran through and 'fixed' them overnight. Now we are down to 6 more that were RTBC'ed today:
http://drupal.org/project/issues/cvsapplications?status=14
Brian Vuyk
Senior Developer, PINGV Creative
bv@pingv.com | (315) 849-9733 | Skype: brianvuyk
Code Review Group
Hey, on a related note, the new Code Review group got approved:
http://groups.drupal.org/code-review
I still need to spend some time making it look better and providing a better more focused interface.
Feel free to start posting questions/discussions to the group.
--
zzolo
I volunteer to review application requests
Hi,
I've already reviewed several applications that are currently in the queue. Just saw this group and would be happy to volunteer :)
Lorin
http://public-action.org/
We build online communities
count me in ....
count me in too ....
Sree
DrupalCon Chicago Code Review Sprint
Hi, I know this thread is actually for DrupalCon Copenhagen, but I am sure there are still people listening. If you are going to be at Drupal Chicago next week, I am going to organize Code Review during Sprint time. Even if you are not attending or have other obligations to sprint on, passing this around would be very helpful. Thank you.
http://chicago2011.drupal.org/forum/code-review-sprint-friday
--
zzolo
I'm on board
Did not realize there was a signup list.
Well, there isn't any signup
Well, there isn't any signup list. Here's the information: http://drupal.org/node/636570
No signup
Yeah I know, silly comment. The title of this post is "Sign up here" but it dates back to August of last year. Some things are better left unsaid.
To all who said 'Count me in' ...
The current backlog in the "Project Applications" review queue is in the order of six weeks ... we could really use another round of action on the above pledges of support right now!
There have been a few changes to the review process during the CVS to Git migration, but the gist of it is still the same. A good starting point for getting caught up on the details would be the Code Review Group on g.d.o ... hope to see you there!