Issues with Drupal 6 RC1

We encourage users to post events happening in the community to the community events group on https://www.drupal.org.
kkaefer's picture
Posted by kkaefer on December 26, 2007 at 1:57pm

Translation issues

Not translated, but string is present

  • Menu item descriptions (patch)
  • Theme descriptions (admin/build/themes)
  • Theme names
  • Module names
  • Language direction (/admin/settings/language)
  • "Navigation", "Primary links", "Secondary links" not translatable

Not translatable

  • "anonymous/authenticated user" (/admin/settings/filters/add, /admin/user/permissions)
  • "bundled, 2.0.34 compatible" (/admin/reports/status)
  • "Installing Drupal" in the installer (and the text below) (t instead of st is used)
  • "Drupal already installed" (/install.php after installation; installer.pot is not imported, but contains these strings)
  • permission names with custom node type names* (/admin/user/permissions)
  • "view" (last column on /admin/reports/dblog)
  • Region names in themes (/admin/build/blocks): "Left/Right sidebar, Footer"

Only translated on install

  • "Forums" (page title on /admin/content/forum)
  • Action descriptions (/admin/settings/actions)

Other flaws:

  • OpenID authentication contains ?destination= argument which makes "allowing forever" a pita
  • Lots of notices at /install.php?profile=default (when other languages are available)
  • Pretty module names at /admin/settings/actions, /admin/reports/dblog

* missing permission names are:

  • create page content
  • create story content
  • delete any page content
  • delete any story content
  • delete own page content
  • delete own story content
  • delete revisions
  • edit any page content
  • edit any story content
  • edit own page content
  • edit own story content

Comments

some comments

Posted by Gábor Hojtsy on December 27, 2007 at 2:16pm
Gábor Hojtsy's picture

Addressing the first set first.

* Menu item descriptions (patch)

Committed now.

* Theme descriptions (admin/build/themes)
* Theme names
* Module names

These are all in the .info files and end up in general.po in the core templates. They are there. Do you see that these translations are not used on the interface?

* Language direction (/admin/settings/language)

Just fixed in http://drupal.org/cvs?commit=93028

* "Navigation", "Primary links", "Secondary links" not translatable

These are "user provided data", and are not translatable. If you can find a place where these are created, we can make them translatable just as with the Forums vocabulary title.

Theme descriptions, Theme

Posted by kkaefer on December 27, 2007 at 2:30pm
kkaefer's picture

Theme descriptions, Theme titles and Module titles are present in the pot files, but they are not used in Drupal whatsoever.

The menu names are untranslatably hardcoded in menu_install(). They could be wrapped in st/t so that they are at least translated at install time.

the second set

Posted by Gábor Hojtsy on December 27, 2007 at 2:31pm
Gábor Hojtsy's picture
* "anonymous/authenticated user" (/admin/settings/filters/add, /admin/user/permissions)

Issue at http://drupal.org/node/18954

* "bundled, 2.0.34 compatible" (/admin/reports/status)

The word "bundled" does not seem to appear in Drupal at all. I grepped for that. This is probably grabbed from PHP itself, and therefore is not translatable(?)

* "Installing Drupal" in the installer (and the text below) (t instead of st is used)

I only found two instances of this there in the module install batch. Now fixed in http://drupal.org/cvs?commit=93030

* "Drupal already installed" (/install.php after installation; installer.pot is not imported, but contains these strings)

No way to translate, as we have no idea what language to load there. Or we can try to load the .po file for the language which is set for the site, or do a full bootstrap there (Drupal is already installed :) and translate with t() with the default language. Using the first option looks better to me. Needs a more involved patch as it seems.

* permission names with custom node type names* (/admin/user/permissions)

This is used provided data, and we cannot extract these pre-install of course. You can however translate these on the locale interface (or l10n_client module). This is impossible to fix with D6's permission system.

* "view" (last column on /admin/reports/dblog)

This is a shortcoming of the half complete watchdog English conversion. The action links are still stored as verbatim HTML text, so they are stored in the language of the page when it was reported. This should be fixed in Drupal 7, just as the other limitation of watchdog logging: that you can only use t() based strings.

* Region names in themes (/admin/build/blocks): "Left/Right sidebar, Footer"

Hm, interesting. I see non-phptemplate themes having their regions defined in .info, but the phptemplate ones reuse the default region set. Where is that defined? Both cases might need fixing. The .info region names are probably not extracted well in potx.

Thanks for fixing some of

Posted by kkaefer on December 27, 2007 at 2:49pm
kkaefer's picture

Thanks for fixing some of these issues.

I suspected that the bundled string is not from Drupal, so it's probably not possible to fix this.

I know that the permissions can't be automatically translated (btw, "delete revisions" doesn't seem to be in the pot either), but we can provide interface strings for these default content types (in default.profile?) so that they are at least translated on a standard installation. A lot of people probably don't bother changing the node type story, page or book.

The ""view" (last column on /admin/reports/dblog)" was also in English when I installed in a foreign language (that Drupal site never ran in English).

default types

Posted by Gábor Hojtsy on December 27, 2007 at 3:28pm
Gábor Hojtsy's picture

Well, _potx_find_perm_hook() includes the list of node permissions, because they are not extractable from node_perm() due to its dynamic nature. We can include the default node type permission names as well there.

The view text is always stored as l(t('view')... everywhere I was able to grep, so it is always stored localized to the page where it was displayed. (If the installer was in English, then they are from there). All later watchdog notices should store this translated. (Again, this is a shortcoming of Drupal 6 still).

* Region names in themes

Posted by Damien Tournoud on December 31, 2007 at 6:58pm
Damien Tournoud's picture

* Region names in themes (/admin/build/blocks): "Left/Right sidebar, Footer"

Hm, interesting. I see non-phptemplate themes having their regions defined in .info, but the phptemplate ones reuse the default region set. Where is that defined? Both cases might need fixing. The .info region names are probably not extracted well in potx.

I just studied this. We need three things to make region names translatable:

  1. Pass region names from system_region_list() to t() in block_admin_display_form() and template_preprocess_block_admin_display_form(). It seems that's the only two places where region names are displayed to the user (patch easy and ready).
  2. Add the parsing of region[] tags to potx_find_info_file_strings() in potx.inc (patch pending).
  3. Manually add default region names to potx (patch pending).

Anything I missed?

Damien

Damien Tournoud

Two new issues

Posted by Damien Tournoud on January 1, 2008 at 7:01pm
Damien Tournoud's picture

I created two issues for this:

  1. #205357: Translating region names (part 1), for Drupal Core changes
  2. #205360 : Translating region names (part 2), for the two potx related changes

Damien

Damien Tournoud

@Gábor the second issue

Posted by Damien Tournoud on January 4, 2008 at 4:59pm
Damien Tournoud's picture

@Gábor the second issue #205360 wouldn't care for some love :)

Thank you.

Damien

Damien Tournoud

only on install

Posted by Gábor Hojtsy on December 27, 2007 at 3:27pm
Gábor Hojtsy's picture

The stuff which is only translated on install are all "user provided text" (ie. can be modified on the UI anytime), so it is not possible to fix in D6 core. i18n module provides user provided text translation.

translating the meta-data of content types

Posted by yojoe on January 4, 2008 at 1:09pm
yojoe's picture

There are some places (pages) in Drupal 6 RC1, where the Name, Type, Description, Title Field Label and Body Field Label are not translated to the foreign language.
See my bug report http://drupal.org/node/206272 for details and sreenshots.

done

Posted by Gábor Hojtsy on January 4, 2008 at 4:19pm
Gábor Hojtsy's picture

The issue is closed already. :)