Porting webcomic.module from 4.7 to 5.x

Last updated: 29-Jan-2008 by Vyoma

To do:

1. Testing (general)
2. Testing - specific to views. There are some places that does give warnings and does not seem to work as required. It needs to be tested in this perspective and issues need to be tracked.

Done:

1. webcomic.module and webcomic_theme.inc changes done. mustafau successfully upgraded the module to 5.x.
2. Getting the 5.x code into CVS? Would be easier for people to download and code/test. I have applied the patch by mustafau and branched to DRUPAL-5. Can be found in the 5.x-1.x-dev release.
3. Views module integration turned ON.

Notes

Please add notes on stuff you want to add to this WikiPage here and I will try to organize it.

Keeping these for record

Reviewing source files for the webcomic module based on Converting 4.7.x modules to 5.x Handbook Page - I have come up with following notes.

webcomic.module review notes

1. No webcomic.info file. Need to create.
2. No webcomic_link() in webcomic.module
3. No webcomic_link_alter() in webcomic.module
4. No webcomic_primary_links() and webcomic_secondary_links() in webcomic.module
5. No use of user_mail() in webcomic.module
6. No webcomic_mail_alter() in webcomic.module
7. No use of user_mail_wrapper() in webcomic.module
8. webcomic_settings() is present in webcomic.module. This is changed during 4.7 -> 5.0. Need to implement it using webcomic_menu() callback function.
9. New hook_profile_alter(). I do not think webcomic needs to implement this.
10. message_na() not used in webcomic.module
11. New Adminsitrator layout?
12. drupal_add_css() not used in webcomic.module. Revisit?
13. No webcomic_view() and webcomic_nodeapi($op = 'view') in webcomic.module
14. webcomic_nodeapi($op = 'alter') ?
15. webcomic_node_info() in webcomic.module to be revisited.
16. webcomic_node_type() - needed?
17. Changes to node type settings form?
18. db_table_exists() - revisit webcomic.module to use it for validation?
19. webcomic_node_operations() and webcomic_user_operations() - not present in webcomic.module - use it?
20. t() calls present in webcomic.module - revisit.
21. drupal_get_form() not used in webcomic.module
22. Form building - revisit.
23. webcomic_forms() not used in webcomic.module
24. drupal_execute() ?
25. module_exist() to be changed to module_exists() in webcomics.module
26. format_plural() not used in webcomic.module
27. drupal_add_js() not used in webcomic.module
28. theme_add_link() not used in webcomic.module
29. theme('page') - revisit
30. Cache?
31. Uninstall hook not applicable to webcomic.module file
32. No use of $_POST[op] in webcomic.module
33. Sentence capitalization standard to be applied to menu items and node links
34. Use webcomic_node_access() hook to write to node_access table
35. confirm_form() not used in webcomic.module
36. #prefix and #suffix not used in webcomic.module
37. Revisit use of #options in webcomic.module
38. $node->moderate not used in webcomic.module?

webcomic.install review notes

Unintall hook may be added webcomic.install
Remaining points in the checklist is not applicable to webcomic.install

webcomic_themes.inc review notes

It does not seem like this source code would require any changes.

webcomic_views.inc review notes

There does not seem to be significant changes for the views.module. (We will know more with testing).