New gateway and slight mod for sms.module

Events happening in the community are now at Drupal community events on www.drupal.org.
aspope's picture

Hi all,

I have just finished a gateway module for Txtlocal (http://www.txtlocal.com), and would like it make it available for inclusion in the SMS Framework package. The module was written for 6.x and supports inbound and outbound messaging with all of txtlocal's extended options (specify sender, delayed send, message reference, WAP PUSH).

I had to make a slight mod to sms.module because the receiver MSISDN is important for my project. I have written it to the phpdoc header in the gateway module, but here it is:
* IMPORTANT FOR INCOMING MESSAGES: If you want to use the txtlocal receiver MSISDN
* (inNumber) then the sms_incoming() callback in sms.module must support an
* $options array as a third argument, and must pass this array on to the
* processors. The inNumber is the MSISDN number that received the SMS message.

The sms_send() function already supports $options, so I think that it would be good to include this as a change to sms_incoming(). Diff below:

46c46
< function sms_incoming($number, $message) {
---
> function sms_incoming($number, $message, $options = array()) {
48,50c48,50
<   module_invoke_all('sms_incoming', 'pre process', $number, $message);
<   module_invoke_all('sms_incoming', 'process', $number, $message);
<   module_invoke_all('sms_incoming', 'post process', $number, $message);
---
>   module_invoke_all('sms_incoming', 'pre process', $number, $message, $options);
>   module_invoke_all('sms_incoming', 'process', $number, $message, $options);
>   module_invoke_all('sms_incoming', 'post process', $number, $message, $options);

Please let me know if there is anything else I should do, or anything you want to discuss.

I also offer to extend the Clickatell gateway module to support inbound messaging, since I will be needing this for my project.

Thanks in advance!

Comments

Hey there, Thanks for your

Will White's picture

Hey there,

Thanks for your work. This is great. Can you submit this as two separate issues with patches to the SMS Framework project? One for the new gateway and one for the change to sms_incoming(). Thanks again for using the project!

Will White

--
Will White

Cheers Will. I have just

aspope's picture

Cheers Will. I have just created the issues:
http://drupal.org/node/397160
http://drupal.org/node/397184

I will get to work on the Clickatell patch very soon.
~ap

Need to Integrate gateway in SMS Framework

tiwiex's picture

Nice job aspope. i just stumbled into dfrupal a month ago. i need to integrate an sms gateway to a site i am creating. i alsready posted a topic in http://drupal.org/node/563288

Is there any way you can helo. I have done a bit of tutorial on onthisdate Can you help me please.
Thanks

SMS Gateway

textmagic's picture

It’s amazing how this module can help an SMS Gateway server do its job. I wonder about the module TextMagic uses.

SMS Framework

Group organizers

Group notifications

This group offers an RSS feed. Or subscribe to these personalized, sitewide feeds: