Posted by kscheirer on May 20, 2009 at 9:01pm
as far as I know, it's legal to remove the credit link at the bottom of the theme, and instructions for hacking the theme to do so are included on the handbook page (http://drupal.org/node/357261#credit-links).
jwolf suggested I post here instead of the issue queue for marina. The current solutions are:
- hack the theme
- use a subtheme, and rely on a very brittle string replacement
- use a display:none and say that's good enough
All of these look like bad solutions to me (#2 the least bad but the most work by far). I can see three ways to handle this:
- Leave it the way it is, and it's just hard to remove the credit links. It's not my theme, I could understand this.
- Create an admin setting to turn off the credits, this might make it too easy.
- Use a variable to store the credits, so overriding with a subtheme doesn't have to rely on exact string matches. This at least makes #2 above more reliable.
Comments
help with the guidelines for advertising links in projects
Whatever solution is found would make a great addition to the Guidelines regarding advertising and Drupal projects.
That page currently has a "todo" for how to make it easy to remove credit links in themes.
--
Growing Venture Solutions | Drupal Dashboard | Learn more about Drupal - buy a Drupal Book
knaddison blog | Morris Animal Foundation
admin setting
Putting in an admin setting would be fairly trivial both to implement and use, this is by far the easiest solution. This is why I suspect the answer is actually that's it is difficult on purpose. If that's the case I'm will happily drop the issue :)
There's no objection here
There's no objection to make this easier to administer for the end user.
Frankly, our focus is elsewhere; improving and adding rich features to the themes (e.g., fluid/fixed width, colorable, panels, RTL).
Personally, I don't think that creating a sub-theme is the best solution. However, if you submit a patch that adds an admin setting which makes available a toggle to turn on/off the credits within the theme's settings we will definitely give it serious consideration.
I agree with Greg that your approach to making this an admin setting would be a great addition to the "How can I make advertising admin-configurable?" section of the "Guidelines regarding advertising and Drupal projects".
Theme setting
Yes, there's some intentional built-in-ness here of those links from both us and Acquia, but that being said, it was always our intention to come back and add an easier way to remove or adjust the links as soon as we had the bandwidth.
The bigger hold-up was that all our themes (free and those on topnotchthemes.com) have the same template.php and theme settings files, for ease of maintenance. However, going into the 2.x releases of the Acquia themes will be a new separation of general and theme-specific settings, which will allow us to keep the consistent settings easily up to date but add/remove settings on a per-theme basis.
~~~
{ Drupal Themes from TopNotchThemes }
~~~
{ TopNotchThemes | Fusion Drupal Themes }
too hard? just too hard to find.
i really don't think adding:
#legal-notice {
display: none;
}
to the local.css is a difficult step, the only difficulty was finding that snippet of code here (i had come across it when i first was checking out the theme, then tried to come back here to find it, now that i have customized it extensively for my own purposes)
actually, i would have liked to have been able to change the line, so that i could have indicated that i customized it, but still give you guys props for the original underlying work, something like "original theme acquia marina by acquia/TNT/whatever – made cooler by eyeui" but that i could not find instructions for how to do, and frankly i just don't have the time. so, no props. sorry.
Look for this in template.php
You can find this by searching for "Acquia" or "TopNotchThemes" without the quotes.
if (drupal_is_front_page()) {$vars['closure'] .= '<div id="legal-notice">Theme provided by <a href="http://www.acquia.com">Acquia, Inc.</a> under GPL license from TopNotchThemes <a href="http://www.topnotchthemes.com">Drupal themes</a></div>';
}
}
Just change what you don't like inside the div.
Also, you might be able to remove the closure variable in the bottom of the Page.tpl.php. Not sure whatelse will be affected by doing this.
Don't do that
You don't want to remove $closure. It's used by more than the theme.
Also, if this code is in a preprocess, you'll want to make your own preprocess function in your subtheme that changes the variable rather than changing the code in the root theme.
Michelle
Removing Closure Variable not Good
Removing the closure variable is no a good idea. I got a little curious about it so, I did a little goggling on it Found it here: http://drupal.org/node/11812. So do not remove it
You only options are to change the text of the dive and change it to what you wan, or use CSS to make it not display.
Just wanted to add that...
Just wanted to add that... actually, it's not really hard at all. I would never suggest "removing" them totally, but instead, just modify to your liking, as someone said. Finding where it is at is very simple. TNT didn't "hide" it. I'm using it and found it very easily by just opening template.php and searching for "legal". It was a piece of cake to mod... took like 2 minutes.
Props to TNT for making such an awesome theme!
Chris
Edith the template.tpl page
You can fix this by edit the template.tpl page..