Refactoring done

mm nice done arkepp, also good to hear that its time to work on a 6.x release :)

one question:

you say this: "If you update the avatar through phpBB then it is not copied to phpBB, but the user will get a warning about this."

dont you mean copied to drupal? :unsure:

I updated to this new version.
My admin user works.
I created a new user and I got this error going to forum or forum/user page:

SQL ERROR [ mysql4 ]
You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'WHERE user_id = 1010' at line 3 [1064]

Edit: I got back to the previous version of the module, but i got the same error. It was a problem related to phpbb3 forum, non to the module. I solved deleting all phpbb tables and installing the forum again.

Hi Arkepp, i just want to say i ported this version to drupal 6 with the help of SpectralDart :), but its only working frome the phpbb side cause of some code change in youre new version..., here is the code for updating the UID table:

and i had to change the check for exsting user ID's but i did that with the help of SpectralDart

the new code for that check:

for the users that want the D6 version just send me an e-mail but using the module for drupal 6 isn on youre own risk

Ok, I've made the fixes necessary in order to support Drupal 6. Here is one of the things that has been giving me a big headache :

function _phpbb_knows_uid needed to be changed.. That was not a problem except that I needed to change a few things because Drupal 6 no longer supports db_num_rows. So I started by doing this :

$result = db_result($query);

if(!empty($db_result))
{
    $result = db_fetch_array($query);
    return $result;
}
else
{
    return FALSE;   
}

db_fetch_array can be used when a query includes more than one column, in this case with Arkepp's query we have : $query = "SELECT username, user_pass_convert FROM {$phpbbcfg['db_users']} "." WHERE user_id = $uid";

So you would think that doing the above works. Nope. For some reason db_fetch_array returns NOTHING! I tested the query before saying this and I get 2 columns. Anyways, so I had to modify things to look like this :

global $phpbbcfg;

$phpbb_users = $phpbbcfg['db_users'];
$data =  "SELECT username FROM " . $phpbb_users . " WHERE user_id = " . $uid;
$query = db_query($data) or die('Query failed: ' . db_error() . " \n" . $data . "\n");
$db_result = db_result($query);

if(!empty($db_result))
{
    return $db_result;
}
else
{
    return FALSE;   
}

In essence, I am asking for one column and db_result should be used when there is only one field. The purpose of function _phpbb_knows_uid is only to check if the user is un the phpBB's database so, is the table element user_pass_convert really necessary? I didn't see anywhere in the case where it was being used. But Arkepp, if you planned for using it one day for something then I'll need to code an extra function for that one.

For those who are experts with Drupal 6 code, maybe you can answer me why db_fetch_array didn't work? db_fetch_object didn't work either......

So thats it. So far so good. Like Arkepp said before, the only thing not supported ar pictures yet. I am not familiar with phpBB's avatar stuff so I'll have to take a look into it.

Cheers

Hi everyone,

I'll be submitted by first draft to Arkepp tonight. Lots of work and bug fixes have been made in order to support Drupal 6. Although I'll be spending a few hours more testing to make sure everything is ship shape, I am confident that you can start testings of you own. It should only be a matter of days. If I have time, I hope to check the picture problem.

Cheers