We need to start data collecting about the code review process so that we can make more informed decisions. See zzolo's post for more context.
One thing we can all do to ease data collection, as well as speed up reviews, is apply appropriate tags and components to issues. Issues have "module" and "theme" components. Beyond that, here's a set of standard tags everyone should use, based on a suggestion by greggles:
- "PAReview: Security" -- security issue found during review.
- "PAReview: LICENSE.txt" -- LICENSE.txt file found during review (shouldn't be there).
- "PAReview: GPL issue" -- non-GPL code found during review (shouldn't be there).
- "PAReview: Ubercart" -- project relates to Ubercart, often helps to have review from someone more familiar with Ubercart.
- "PAReview: CiviCRM" -- project relates to CiviCRM, often helps to have review from someone more familiar with CiviCRM.
Comments
Improve Data Collection Solution
Data collection to support the Code Review process would greatly be improved by establishing the system outlined here https://drupal.org/node/1140208 Secure Code Review Wiki - Centralized Database of Drupal Code Exploits
Freedom Isn't Free