Another question on a review

Events happening in the community are now at Drupal community events on www.drupal.org.
barnettech's picture

I'm reviewing http://drupal.org/node/1379794#comment-5482518 and I went to install it and see that the applicant is really just extending the LinkedIn module http://drupal.org/project/linkedin Do we want to encourage the applicant to work with the maintainers of the LinkedIn module? The applicant is adding these 2 features:

Displays 'Latest Discussions' Posts in a Block for the specified Group
Displays 'Most Popular Discussions' Posts in a Block for the specified Group

I once submitted a module for a facebook wall (prior to @icecreamyou updating the facebook statuses module this past summer at Acquia), and a reviewer suggested @icecreamyou and I work together rather than have me submit a separate module because I didn't like the Facebook Statuses module last June. Now the facebook statuses module is awesome and I abandoned my effort and worked with @icecreamyou a bit with feedback, etc.

Should http://drupal.org/node/1379794#comment-5482518 be allowed to be a separate module, or should this applicant just be encouraged to join forces with the existing maintainer of the LinkedIn module. Sorry to repeat myself, just trying to be clear on what I see the potential conflict being.

Anyhow I don't want to do the wrong thing here so thought to ask.

thanks.

Comments

It's worth suggesting ...

jthorson's picture

Given the community mantra for collaboration over competition, it would be a good idea for the applicant to at least discuss the features with the original module creator, and see if they would be interested in the additional features via a patch.

However, I wouldn't go any further than a simple suggestion in this case, as the applicant's module is actually a plugin for the existing module, as opposed to a replacement ... So in a sense, they're already collaborating.

thanks

barnettech's picture

thanks, sounds good.

Code review for security advisory coverage applications

Group organizers

Group notifications

This group offers an RSS feed. Or subscribe to these personalized, sitewide feeds: