Mentoring and reviews of user cubeinspire

Good work so far!

One important aspect of reviewing is finding security issues. As you may know we use the "PAReview: security" tag to track modules that are exploitable in some way. It would be cool if you could also explicitly list review comments where you identified security issues, if you found some so far. That would boost your reputation!

As we are training you as admin it might be a good idea if you could also take a look at RTBC applications. Just review them as normal and add the "PAReview: admin mentoring" tag (I just invented it here :-) if everything is fine, or put them back to "needs work" if you find application blockers.

http://drupal.org/node/1117208#comment-6678548

I really wanted to set this module as ready when i saw it on the list (6 weeks as RTBC).
I've expent quite a lot of time analysing the code and checking what it does... beside an access problem that was mentioned and not solved there is from my point of view a module duplication issue (all the rest was quite acceptable... )

Those two modules are doing basically the same but the oldest provides an administration interface (the sandbox one uses hardcoded paths).

http://drupal.org/node/1117208#comment-6678548
http://drupal.org/project/tvi

I set it as needs work.

Did I did the correct thing on this case ?
What is the best thing to do when the PA does exactly the same as an already an existent module ?

Thanks !

duplicated

http://drupal.org/node/1125818