Mentoring and reviews of user anwar_max

You are viewing a wiki page. You are welcome to join the group and then edit it. Be bold!

Posted by anwar_max on November 16, 2012 at 4:28am
Last updated by anwar_max on Sun, 2012-12-30 07:37

Hi !

This page is used to keep track of anwar_max's reviews and help in the project application queue. We will use this page as reference to his work and to help him become a code review administrator at some point. Please add any advice to you might have in the comments.

Manual reviews

tablebooker:
http://drupal.org/node/1854328#comment-6799656
http://drupal.org/node/1854328#comment-6814106
http://drupal.org/node/1854328#comment-6814260

Vocabulary image:
http://drupal.org/node/1637566#comment-6799778
http://drupal.org/node/1637566#comment-6814196

Branding site name:
http://drupal.org/node/1856202#comment-6800648
http://drupal.org/node/1856202#comment-6814226

Fapi IMage Field:
http://drupal.org/node/1859944#comment-6818460

Image Link Formatter:
http://drupal.org/node/1837170#comment-6825552

AutoUpload:
http://drupal.org/node/1872526#comment-6870438
http://drupal.org/node/1872526#comment-6875620
http://drupal.org/node/1872526#comment-6885464

Christmas Lights:
http://drupal.org/node/1871392#comment-6870478
http://drupal.org/node/1871392#comment-6872018

Views Node Edit:
http://drupal.org/node/1872452#comment-6870636

Pretty Pagination:
http://drupal.org/node/1871644#comment-6870690
http://drupal.org/node/1871644#comment-6875750

Media Video:
http://drupal.org/node/1679932#comment-6872048

Pay2Pay payment gateway module:
http://drupal.org/node/1873786#comment-6875650

Range field:
http://drupal.org/node/1848868#comment-6875714

Youtube Video Uploader:
http://drupal.org/node/1874650#comment-6885948

Domain TAC:
http://drupal.org/node/1876482#comment-6886886

DX Cache:
http://drupal.org/node/1865018#comment-6886952

XML Display:
http://drupal.org/node/1323784#comment-6886964

Security issues

tablebooker:
http://drupal.org/node/1854328#comment-6814106

Vocabulary image:
http://drupal.org/node/1637566#comment-6814196

Fapi IMage Field:
http://drupal.org/node/1859944#comment-6818460

Block Inject:
http://drupal.org/node/1861942#comment-6885992

Comments

Welcome!

Posted by klausi on November 17, 2012 at 12:08pm

One important aspect of reviewing is finding security issues. As you may know we use the "PAReview: security" tag to track modules that are exploitable in some way. It would be cool if you could also explicitly list review comments where you identified security issues, if you found some so far. That would boost your reputation!

As we are training you as admin it might be a good idea if you could also take a look at RTBC applications. Just review them as normal and add the "PAReview: admin mentoring" tag if everything is fine, or put them back to "needs work" if you find application blockers.

Need your suggestions

Posted by anwar_max on December 7, 2012 at 4:50pm

Hi Kalusi,

I need you suggestion on this comment http://drupal.org/node/1859944#comment-6820710

I think greggles already

Posted by klausi on December 15, 2012 at 11:53am

I think greggles already answered that already in the thread: http://drupal.org/node/1859944#comment-6822390

Feel free to ask again if you need more info.

And I would recommend to not copy the full review checklist template to a review comment. Just mention the points where a project does something wrong or what is relevant.