Posted by juliangb on May 1, 2013 at 7:44pm
Given the increased pace of development on Project Management, and the speed with which we're approaching official releases, I think it may be helpful to put down on paper the things that I'm using to review patches.
Hopefully by sharing this publicly, it will help us have an efficient queue.
Parts of a review:
- Automated tests pass (shown as green on the issue)
- Coder & Coder Tough Love tests pass (no warnings, including minor)
- The patch looks sensible - from a read-through
- The patch seems to work / doesn't seem to break anything - from trying it out
I don't want this to be red tape, but to help us get good patches in more quickly.
Feel free to review even just one of these aspects!
However, please only mark RTBC if all have been satisfied (doesn't have to be by the same person).
These aren't set in stone. Comment if you think we can do something differently.
Thoughts?
Comments
On #2, to make this easier
On #2, to make this easier for all contributors, I've opened up the coder functionality on the Project Management for Drupal 7 demo site.
You can use:
http://drupal-7.project-management-module.org/admin/config/development/c...
...for testing patches
and
http://drupal-7.project-management-module.org/admin/config/development/c...
...for seeing the latest status of Project Management.
Hope this helps.