Posted by kscheirer on December 2, 2013 at 9:49pm
A common submission seems to be adding Addressfield support for a particular country. They tend to be very small modules, often failing the "Code Too Short" check recently removed.
The question is, do we accept these as modules or suggest a patch instead. I think Mac_Weber put it best in https://drupal.org/comment/7802523#comment-7802523 where he argues for a patch to the existing Addressfield module. I'm in favor of patches as well, but our response, whatever it is, should be consistently applied.
Related addressfield applications:
- Address Field Nigeria Closed (won't fix)
- Addressfield BE Needs review
- Address Field Taiwan Closed (won't fix)
- Address Field Portugal Closed (won't fix)
- AddressField CO Needs work
- China address field Closed (fixed)
- Address Field JP Needs review
- Address field Indonesia Needs review
Comments
I think we should get input
I think we should get input from the Addressfield maintainers here what they want us to do.
Should new countries be provided as patches against Addressfield core and will they get accpeted? Or should people publish their own separate contributed modules with the addressfield integration for that country?
I've been handling patches as
I've been handling patches as they come in; there's obviously only so much we can do by way of testing these and committing them over time. It's also hard sometimes to determine the consensus for any given country.
If the module is doing more than just determining the address format for a country, I can see it existing as a standalone module. If all it's doing is changing the order of form elements or adding states to the dropdown, we can add that as a patch to the core module.
Ok, so we will propose that
Ok, so we will propose that applicants first try to submit patches against addressfield. If that is not possible or does not work out for whatever reason than they can get back to us and we will continue with the applications.
Proposed comment for those modules:
New status: postponed (maintainer needs more info)
After a recent discussion with one of the addressfield maintainers we would like to ask you to submit this as patch against the core addressfield module instead. Module duplication and fragmentation is a huge problem on drupal.org and we prefer collaboration over competition.
If your patch is accepted please close this project application and feel free to come back to us whenever you have a new project to promote.
If your patch is rejected for whatever reason please revert the status of this project application and add a section to the issue summary where you explain why this could not go into addressfield core directly. And a link to the issue in the addressfield issue queue where that was discussed would be nice in the issue summary.
I took this and updated a
I took this and updated a project app: https://drupal.org/node/2089425#comment-8272935
Brady
@fastglassllc
@derailedonline