Posted by pankajsachdeva on March 2, 2016 at 6:58am
Last updated by pankajsachdeva on Thu, 2016-03-17 07:44
Last updated by pankajsachdeva on Thu, 2016-03-17 07:44
This wiki page is created to keep track of pankajsachdeva's manual reviews of projects in the project application queue. As a reviewer, I hope to get more advice from more experienced reviewers. Please use the comment field to add your advice, corrections, and observations.
Reviews List:
- Autosave Webform
- Auto Block Scheduler
- Webform User Options
- Global Logout
- Select Registration Roles
- Static Content Manager
- Imagefield Zoom
- Unpublished 404
- Iframe Resizer
- Stackla
- Nexmo SMS Gateway
- Change Login Url
- Slack Receive
- Metatag Replace
- Guser
- Currency Exchanger
- Chatlio
- Freebil
- Date Group
- Language Proficiency
- Taxonomy UI Improvements
- Locker
- Triculin
- Contentout
- Facebook Instant Articles
- Currency Taxonomy
- Simple tweets
- Video Embed Ustream
- Aspam
- Required On Publish
- Context Hide Field
Comments
Hi Pankaj, thanks for
Hi Pankaj,
thanks for starting this!
I saw that you are not a git vetted user yet. So the first step would be for you to got through the project application process yourself. Do you have any project you are currently working on?
Thanks for reply
Thanks for the reply @klausi.
Recently I started on my project and soon I will create a sandbox project and will put it into the issue queue.
Meanwhile, Can you please review my Wiki page that what I am doing right/wrong and how to improve my reviewing process.
It will be great.
I'm probably busy helping
I'm probably busy helping others that are already git vetted users, but maybe someone else can take a look at your reviews here?
Few quick comments. Under
Few quick comments.
Under current policy, the only things we push applications back to Needs Work for are security problems, licensing issues, and third-party code. Licensing and third-party code are pretty easy to identify, so focus on security issues.
Perfect compliance with pareview shouldn't block an application, and in some cases will show false positives (eg, views plugins).
My suggestion would be to read reviews from active admins and see what they focus on for constructive criticism, and what they block on. Just remember if you are looking at an older review, that under the old policy we would block for duplication and really bad API problems, but we no longer do that. Also find issues tagged with security problems, and see if you can spot them. The main culprits in project apps are
Thanks for nice feedback!
Hi mpdonadio,
Thanks for reviewing and giving the nice feedback.
I am looking at the security reviews done by GIT Admins to learn more and reviewed the project applications in case of security.
I will try to find the Security issues in the projects.
Once again thanks for review. In future, please provide me these types of suggestions so that I can improve my reviewing process.