Saudi Identity Field (Enhancements) Drupal Saudi Sprint #4

Posted by samaphp on November 27, 2020 at 8:31pm

Organizers:

3ssom

raedkhurayji

samaphp

Event type:

Sprint

https://www.meetup.com/drupal-sa/events/274822338/

This sprint to continue developing this module:
https://www.drupal.org/project/saudi_identity_field

And to review the module's issue queue.

Please login or register to sign up for this Event.

Comments

The challenges that we are

Posted by samaphp on November 28, 2020 at 3:02pm

The challenges that we are trying to solve for this sprint is:

1- Fix hook_help() it’s not working for some reason.
2- Remove the FieldForammter since I believe we don’t need it.
3- Clean up a bit SaudiIdentityDefaultWidget.php there are some functions that we don’t need.
4- replace the t() with dependency injection of $this->t() instead.
5- We need to address all of the @TODO’s in our extended classes.(Major efforts)
6- I don’t think we need hook_field_formatter_info_alter() in .module file.
7- Find a proper way to catch every deprecated code in D8 so the module will be compatible with D9 when we add it to info.
8- add the version to info.
9- Make sure schema is supporting multiple values when we fix the multiple values in field settings.

Thanks for @3ssom for listing all these points on Slack

After review all the sprint

Posted by samaphp on November 28, 2020 at 4:01pm

After review all the sprint points we realized some of these items is done. Which is these points:
1- Fix hook_help() it’s not working for some reason. [DONE]
2- Remove the FieldForammter since I believe we don’t need it. [DONE]
3- Clean up a bit SaudiIdentityDefaultWidget.php there are some functions that we don’t need. [DONE]
7- Find a proper way to catch every deprecated code in D8 so the module will be compatible with D9 when we add it to info. (DONE)
8- add the version to info. (DONE)

And these points still needs work:
4- replace the t() with dependency injection of $this->t() instead. (NEEDS-WORK) @abdulaziz1zaid
5- We need to address all of the @TODO’s in our extended classes. (Major efforts) (NEEDS-WORK) @saud
6- I don’t think we need hook_field_formatter_info_alter() in .module file. (NEEDS-WORK) @abdulaziz1zaid
9- Make sure schema is supporting multiple values when we fix the multiple values in field settings. (NEEDS-WORK) @3ssom