Reviewers

.

.

As some of you know, I've recently taken over maintenance of Inline and Image Assist, and initiated the Wysiwyg project. That was not only caused by personal interest, but also to take the necessary steps to realize the long awaited Inline API. You might ask yourself, what those three modules have in common or to do with each other at all: They deal with user input, allow to embed complex contents into a content, and provide an interactive GUI for that. If you already had the chance to work with them, you already know that there is a rather hidden, non-obvious hard-dependency between them.

Although I'd really like to discuss both topics (Inline and Wysiwyg support) separately, the gained experience on these topics enforces us to discuss them concurrently. The following mockup hopefully explains why: (see attachment to view in full size)

The past two-three weeks I've spent a lot of time in the Drupal 6 issue queue. This involved a mixture of reviewing patches I really wanted to see get into Drupal 6, writing or re-rolling some small patches for small bugs and typos, and trying to clear the issue queue as much as I could down to a manageable size. I commented on something like 160 issues in seven days, and read through many more.

http://drupal.org/node/147143 demands your review. Code freeze has happened, but i'm still tempted to get this in, and hopefully it will. The patch is nothing that's stuck anywhere. That is, we should be ready for the RTBC state, as soon as there are a few more detailed reviews. Even usability reviews are welcomed!

Details about changes

• Active/Preferred(Redirect to) alias per system path. So that all your aliases can redirect to the preferred one.
• Search Engine Optimization! Google hates multiple urls with same content, this one of course is a ++ to SEO in Drupal.
• A whole new intuitive path alias editing interface. Easy to grasp at first glance!
• Total multi-language support for aliases. Language tabs appears, whenever you are editing an alias. A screen shot says it all: http://drupal.org/files/issues/URL aliases | Drupal_1181082809921.png
• Fixes several glitches in path module/system.

Screen shot

The issue is at: http://drupal.org/node/20295

It's the most awaited one after flat forums(coming soon!), and posting this one so that we can move on to flat forum one asap! Now, for this one, imagine you want polls to appear in your forums, this patch gets any content type in there, and likewise the possibilities to push any content into forums by choosing related category. Hopefully this much makes enough sense what the patch does. Will also post a port for Drupal 5.x, as requested by Michelle.

Issue link again: http://drupal.org/node/20295

For Drupal 6 to be able to come out with some fundamental multilanguage support changes, reviews of some modifications and improvements are needed. There is not much time left until the code freeze, but we have a list of important issues and some possibly nice additions for you to look at. Lot of the groundwork material we developed is already in Drupal 6, which makes it possible to provide some cool user facing functionality. Now it is a good time to review the suggested changes, propose corrections and help Drupal 6 to rock in the multilanguage world.

What's already in Drupal 6? A new language subsystem which supports multiple text groups to store translations in (additionaly to the built in interface translation text group available before). There is built in support for language dependent paths and domains, right-to-left written text, with some of the themes already capable of displaying RTL pages out of the box (more to come). Interface translations are automatically imported from the file system when you install Drupal or you enable modules and themes. Posts on the site can have language associated with them, and there is a simple content translation module built into Drupal.

What is left to do? Well, the following:

Translating site settings
http://drupal.org/node/155381 - The absolute minimum to support site settings translations with a contributed module

Translating content types, user profile fields, etc.
http://drupal.org/node/155047 - Minimal object translation wrapper for content type, profile, aggregator, etc. translation

Themes still missing right-to-left display support
http://drupal.org/node/148084 - Pushbutton RTL styles
... - Garland and Minnelli RTL styles

More visible language support
http://drupal.org/node/154151 - Language-aware search

Usability improvements
http://drupal.org/node/52990 - Redoing the locale module translation web interface (see http://groups.drupal.org/node/3916)
... - Define and implement Drupal 6 translation packaging format, redesign interface translation workflow (this is done as part of Google SoC 2007)

Would be nice for multilanguage features, but probably not going to happen in Drupal 6
http://drupal.org/node/147041 or http://drupal.org/node/146033 - Two different approaches for built-in site settings translation
http://drupal.org/node/141461 - Translating any objects in Drupal (it has a good UI, but the performance is not acceptable yet)
http://drupal.org/node/141419 - Rework profile categories (has many advantages, for one being able to translate categories)
http://drupal.org/node/145164#comment-250759 - Refactor variable defaults
... - Eliminate t() from $link parameter of watchdog() calls

We have posted a patch to support object translation of certain Drupal objects (content types, user profile fields and categories, site settings, and so on) to multiple human languages. While we have clear concepts and very good ideas for the user interface (which we though before that would not be easy), performance-wise we are at crossroads. We would welcome beginner as well as expert reviewers to come and share their performance ideas about Drupal object translation, so Drupal 6 can include a mature translation infrastructure, advancing ahead of the competition. ;) We need your input!

"Introduce dynamic object translation API (optimize this!)" http://drupal.org/node/141461

Check out the current Patch Spotlight here

This is a great project for everyone to get involved in - you will be a part of the team working on core drupal, you'll learn about the goodies coming in the next version of drupal and gain instant karma - without needing to know any code! We are highlighting specific core patches that need to be tested before they can be accepted into core. This is a crucial step for actually moving the development of Drupal forward since much code has been written but it isn't going anywhere if it hasn't been tested.

There are a number of links to resources available on the Patch Spotlight page. Feel free to ask questions either in the Drupal Dojo or Reviewers group pages or in the #drupal-dojo IRC channel.

add1sun started this at http://drupal.org/node/109114 with an excellent proposal for organizing the patch docs in the d.o handbooks (see below). now that the patch spotlight is underway, i'd like to propose a more thorough restructuring of the patch-related docs, building on what add1sun laid out. i know we normally don't use "top-level" path aliases, and prefer to prefix with "/handbook", but in this case http://drupal.org/patch is already pointing to a node buried deep in the patch-related docs. so, we should take advantage of that, and build a path (and book) structure on top of that which makes sense. in some cases (e.g. http://drupal.org/patch/review) we're already doing that. let's finish the job.

Hey folks, I've got another video out, Applying Patches to Drupal Core - there is .mp4 and .mov and a torrent for the .mp4. This one is just as quick and dirty as the last one - it is 12 minutes. It shows you how to use the command line to apply, test and reverse patches for Drupal core. This is a great way to be part of core development even if you know nothing about code. The developers are writing the patches but they need many eyes to test them and see if they really work in a wide variety of use cases.

Hey guys,

I could really use a few reviews on some issues that are lagging. I have seven issues set to CNR at http://drupal.org/project/issues?states=8&assigned=chriskennedy right now.

In particular I'm interested to hear if there are any suggestions for these two UI-related patches:
1. Custom date-time formats
2. Links to jump to previous/next new comment

Thanks,
Chris

Hi,

Could someone please look at http://drupal.org/node/29706 and see if it's pgsql compliant? How do the CONCAT, MD5 and SUBSTRING functions behave on PostgreSQL?

Thanks,
Johan Forngren

Drupal 5.x is so close that we can almost smell it!

Here is a list with all patches against Drupal core marked "code needs review" and tagged with any 5.x version (beta, rc, dev). Currently it is three sides long, which IMO is far to long. Can we try to bring it down to two pages? That is a realistic goal and will increase the stability of 5.x and release some pressure of developers. Thank you.

http://drupal.org/project/issues?projects=3060&versions=96923,103420,100...

http://drupal.org/node/92630 - THIS one is the biggest usability issue I've come across and we have a great simple fix, just needs some momentum behind it and needs it fast! It's got Steven's stamp of approval but needs some more voices.

http://drupal.org/node/104763 - Define page and story in default.profile. This patch also changes page's workflow to not promote to front page and have comments disabled.

Filters aren't being applied to RSS feeds: http://drupal.org/node/103371

I have participated or commented on a few issues that need a review, most of which are very minor changes. I'll trade reviews one-for-one with anyone who's interested. Here is the list of issues.

Here are my top ones:

1. Automatically enable clean URLs during install
2. Core uninstalls shall clean up node and node_type table
3. Accurate error messages for install and bootstrap
4. E_ALL compliance during installation

Not sure of the correct/preferred layout of a review request, so I'll just cross post from the dev mailing list.

I've just committed a beta version of the ChipIn (see http://www.chipin.com) module to contrib/modules/chipin (http://drupal.org/project/chipin). I was looking for some peer review of the module. I'll gladly return the favor, it's just nice to have another set of eyes look things over for usability, security, etc. So if you have a module/patch you'd like me to go over in return, let me know. I think it's pretty cool to have the donation thermometer to see how much we still need for each fundraising drive and ChipIn.com is pretty well done.