Posted by bryan.cribbs on March 3, 2012 at 6:21am
I'm frustrated that I can't track your 2.0.2 release from the git sources, since only master is published.
I'm seeing these problems on HEAD and also on the released files.
On HEAD, BARRACUDA.sh.txt, line 2259 and line 2260 are identical:
run_apt_update_again
run_apt_update_again
Similarly, line 2285 and line 2286 are identical:
MIRROR=bash ffmirror.sh.txt < apt-list-ubuntu.txt
MIRROR=bash ffmirror.sh.txt < apt-list-ubuntu.txt
When I review the script, I see other apparent oddities along these lines.
Can you explain why these lines are duplicated in this way? I don't mean to be offensive, but this seems sloppy (perhaps there is a good reason you needed to do it that way, but I'm not seeing it).
Comments
The duplicate
The duplicate
run_apt_update_againis by design to fight with some edge cases people experienced in the past, when running it only once didn't complete some updates for some reasons, like network issue etc. It has the purpose to improve UX and to avoid breaking the entire install or upgrade process, which is running non-interactively by design.The duplicate
bash ffmirror.sh.txtis by design to make sure that the result is not affected by any DNS issue, so we run it first to warm the local pdnsd cache and then again to discover the fastest mirror.As a side note: is there a name for this attitude to name something as "sloppy" before receiving an answer to questions posted? I think that it is an offensive ignorance.
Maybe the name is
Maybe the name is "presumptuous", on my part?
I did not mean to be (I'm sorry my question sounded rude). But it might be helpful to put a comment in the code noting that the repeat is intentional, just because it looks like a mistake if one doesn't know why it's repeated.