Posted by rajiv.singh on July 13, 2012 at 4:12am
Hi Friends,
I have contributed a module for NAB. here is the project page link:
http://drupal.org/sandbox/phpsrajiv/1682028
Please review and let us know your feedback.
Thank you,
Rajiv
National Australian Bank Payment Gateway for ubercart
Group categories
Location
- Australia wide (1003)
Comments
you would want to put some description ...
Hello Rajiv,
Appreciate your efforts for this contribution.
I am sure you would want to put some description on your project page first.
Cheers
Sushil H.
probably should colaborate
probably should colaborate with http://drupal.org/project/uc_nab_transact
Pretty sure rcross has a port of that for D7 too
yep
Yep, for commerce.
http://drupal.org/project/commerce_nab_transact
--Ryan
Ryan Cross
Drupal Development Services
ProjectPier project management and collaboration software
Your module was a life saver
Your module was a life saver on a very tight budget few months ago. Thanks for contrib Ryan.
Hi Rajiv, Module looks good,,
Hi Rajiv,
Module looks good,, haven't tried though.
Below are a few small things that you could consider doing.
1) Everything is in the master branch now. Crate a 7.x branch. You could put all stuff in 7.x leaving the master branch almost empty
2) License.txt is not needed
3) Those $Id: lines are no more needed
3) Run the module against "coder" review,. gives a list of formatting issues that you can fix
4) The project and datestamp in .info file would not be needed
5) You could also consider moving the admin-only settings form to a separate inc file
Best
Tanay
--
Tanay Sai
Bangalore
skype: tanay.co.in
@rajiv: Please share the
@rajiv: Please share the project application link.
It would be better if Tanay can move his review there.
http://goo.gl/icjPn
Duplicate/fork of project
This sandbox has not had a project application issue made for it on the queue, but if it did, it would not be accepted. It is a duplicate project, and not original work demonstrating the abilities of the author.
The sandbox is an exact copy of http://drupal.org/project/uc_nab_transact release 6.x-1.0 with what appear to be partially applied patches from http://drupal.org/node/1259422 ; the issue that led me to this post as I just posted an updated set of patches for the module.
http://drupalcode.org/sandbox/phpsrajiv/1682028.git/blob/381c40e:/uc_nab...
The project maintainer of uc_nab_transact is looking for a co-maintainer, and this would be the best path for rajiv to follow if he wished to contribute to this module.