Posted by marvil07 on August 18, 2009 at 4:54am
Here the last 3-weeks WU :-)
Now the details.
vcsapi
oop branch:
FIXES
- Some minor changes/fixes (See indent, fix account cache loader, use item::fetchItemRevisionId() correctly, fix Item::pregMatch() calls, fix Item class is{File,Directory,Deleted}() calls, oop to Item::getHistory(), various fixes, move back Item::fetchCommitOperations() to a module function)
OO-ification
- split loaders from account class to a new class VersioncontrolAccountCache and from operation class to VersioncontrolOperationCache class, in the same way that VersioncontrolRepositoryCache works
- Re-structure repository urls behaviour:
- make repo urls a VersioncontrolRepositoryUrlHandler class, where versioncontrol_get_url_* functions was converted to its methods(oop them)
- move repo urls to repo::data['versioncontrol']['url_handler']. This will avoid having an independent urls cache and removes urls table.
- remove all notion of the default url backend(jpetso and me could not find a good reason to maintain url backend as interchangable, so now we define only one type for url handler an use it directly)
- improve documentation: round 1 and round 2 (update lots of comments, document interfaces, update fakevcs module to oop way, move contents of hook_account to VersioncontrolFakeAccount class and OOP_TODO)
- move [backend]get_selected_label* to methods: convert [versioncontrol_backend]_get_selected_label_from_operation() and [versioncontrol_backend]_get_selected_label_from_other_item() to methods, Operation::getSelectedLabel() and Item::getSelectedLabelFromItem(), and make them abstract. In this way we make explicit to the language the "mandatory condition" of these to implementations and only interact with backends(not a hook to all modules).
- New interfaces
Also, rebase autoload and oop-dbtng branches to let them apply on top of actual oop branch.
git backend
master branch: one minor fix
oop branch:
- apply the same fix above
- sync with vc api
Also rebase autoload branch to let it apply on top of actual oop branch.
