BUG? the In Place Editor does not use the latest jquery and jquery ui upgrade

Events happening in the community are now at Drupal community events on www.drupal.org.
RobKoberg's picture

Hi,

When a page loads that has the in place editor, the old jquery ui file names are used and they try to draw those old named files from modules/jquery_ui/jquery.ui/ui/minified e.g. ui.sortable.min.js rather than jquery.ui.sortable.js

Comments

Panels just calls this: <?

merlinofchaos's picture

Panels just calls this:

<?
jquery_ui_add(array('ui.draggable', 'ui.droppable', 'ui.sortable'));
?>

This is precisely what the jquery_ui module instructs us to do:

http://drupalcode.org/viewvc/drupal/contributions/modules/jquery_ui/READ...

OK, I see. However, I dropped

RobKoberg's picture

OK, I see. However, I dropped in jquery-ui-1.8.4, which has prepended 'jquery.' to the file name. Easily fixable, but seems like a bug.

OK, I see. However, I dropped

RobKoberg's picture

OK, I see. However, I dropped in jquery-ui-1.8.4, which has prepended 'jquery.' to the file name. Easily fixable, but seems like a bug.

At the moment we only support

merlinofchaos's picture

At the moment we only support jquery 1.6 which is what jquery_ui supports.

err, jquery ui 1.6

merlinofchaos's picture

err, jquery ui 1.6

FWIW, I changed the file

RobKoberg's picture

FWIW, I changed the file names for jquery ui files and removed the 'jquery.'. So in my jquery ui 1.8.4, there are the original files and a copy of each minus the 'jquery.' (simple enough script)

Everything seems to work fine so far.

So, this sounds like a jquery_ui bug? or feature request? 1.6 is really old.

(I am new to Drupal)

best,
-Rob

Hi Rob, I had a similar

nickgs's picture

Hi Rob,

I had a similar problem. Changing the module to use the new file naming convention was pretty simple. I made a patch but it seems you can't attached files to groups discussions. In any event, it is two lines in the module. There is one reference to ui.core and one to effects.core simply changing this to jquery.ui.core and jquery.effects.core respectively did the trick.

You now want to use the module a little differently. Your jquery_ui_add() calls will now look like this:

jquery_ui_add(array('jquery.ui.widget','jquery.ui.mouse','jquery.ui.draggable', 'jquery.ui.droppable', 'jquery.ui.sortable', 'jquery.ui.accordion'));

The order matters here. The jquery.ui.widget is the base for many of the UI components and should be added first.

I am using jQuery UI 1.8.4 with jQuery 1.3.2 deployed via the jQuery Update module.

If you want the patch let me know.

Have fun!

Nick

Panels

Group organizers

Group notifications

This group offers an RSS feed. Or subscribe to these personalized, sitewide feeds: