I noticed som ewarning messages when I ran update.php after updating OpenPublish from OpenPublish-2.2-Build285 to OpenPublish-2.3-Build441. I don't believe the warning message is anything to worry about, but I thought I should document it here in case anyone else sees it and wonders what is going on.
The warning messages I got were:
- user warning: Duplicate column name 'export_key' query: ALTER TABLE noderelationships_settings ADD `export_key` VARCHAR(64) NOT NULL DEFAULT '' in /Users/sheldonrampton/Sites/rampton/openpublish/includes/database.mysql-common.inc on line 307.
- warning: array_merge() [function.array-merge]: Argument #2 is not an array in /Users/sheldonrampton/Sites/rampton/openpublish/update.php on line 174.
- warning: Invalid argument supplied for foreach() in /Users/sheldonrampton/Sites/rampton/openpublish/update.php on line 338.
I believe the array_merge and "invalid argument" warnings were both caused by the failure of the ALTER TABLE query in the first warning message.
The warning occurs when update.php attempts to run Update #6004 to the noderelationships module. It appears that the warning message is happening because both OpenPublish-2.2-Build285 and OpenPublish-2.3-Build441 have patches to the noderelationships module which create some inconsistency.
In the non-patched version of noderelationships that was included with OpenPublish-2.2, the most recent update in noderelationships.install was Update #6002. OpenPublish-2.2 shipped with a PATCHED version of noderelationships.install that added its own Update#6003 which created the 'export_key' column.
In the non-patched version of noderelationships that was included with OpenPublish-2.3, an Update #6003 has been added which does NOT create the 'export_key' column. OpenPublish-2.3 therefore has a patched version of noderelationships.install that adds an Update#6004 to create the 'export_key' column. The result, therefore, is that Update#6004 in OpenPublish-2.3 attempts to create a column in that was already created in the version of Update#6003 that shipped with OpenPublish-2.2.
Since the column already exists, the failure to create it during update.php should not be a problem. It's just a warning message that I think can be safely ignored.