New i18n Coder Review

Doug and I are working on a new internationalization review for coder. The following checks are in the D6 dev version already (thanks to Doug!):

• The $text argument to l() should be enclosed within t() so that it is translatable.
• The $text argument to l() should be enclosed within st() so that it is translatable from within the install. (install files only)
• Use get_t() or st() instead of t() in !hook_install(), hook_uninstall() and hook_update_N() (install files only)
• The FAPI #title should be enclosed within t() so that it is translatable.
• The $message argument to form_error() should be enclosed within t() so that it is translatable.
• The 'title' option should be enclosed within t() so that it is translatable. (in hook_links() functions)
• The $message argument to drupal_set_message() should be enclosed within t() so that it is translatable.
• The $title argument to drupal_set_title() should be enclosed within t() so that it is translatable.
• The $message argument to watchdog() should NOT be enclosed within t(), so that it can be properly translated at display time.
• Menu item titles and descriptions should NOT be enclosed within t()
• The $string argument to t() should not begin or end with a space.

The following ones will be added soon hopefully:

• #312510 - check for t() in format_plural()
• #311530 - incorrect usage of t() !placeholders
• #311516 - leading/trailing spaces checks for format_plural(), watchdog(), etc
• #311477 - check for \' within translatable strings

However, there's probably a lot more we could add. So if you know of any additional checks that could be done, please let us know by opening a feature request against the coder module. I'd be also be interested to hear your feedback and comments on other things we can do to help improve matters.

Also for those of you who aren't aware, if you enable both the coder and potx modules on your site, additional "Interface text translatability" reviews are available to run with coder.

Cheers,
Stella