Posted by arrow on September 27, 2011 at 1:20am
Hi everyone... I have a question about patch etiquette and I figured I'd start by asking you guys first...
If somebody creates a patch for a module, and I'd like to add some functionality to the functionality added by that patch, what is the best approach? Should I create a patch that requires you apply the other patch before applying mine, or should I build a patch that includes all the changes and submit it to the same issue? Or something else? I'm sure there's some sort of proper way to go about this, I just don't know what it is.
Thanks!
Comments
It depends. If the patch is
It depends. If the patch is still in a needs review status then I would update the current patch.
If there has been los of activity on the issue and it looks like the patch is about to be committed then I would call the other patch a requirement. Be sure to keep an eye on the patch and reroll your patch once the original on is committed.
Hope this help!
Cheers,
Neil
Neil Hastings
http://twitter.com/indytechcook