The project application review queue is the place to welcome new Drupal contributors that want to become project maintainers on drupal.org. That queue is always full and we always need help to review projects, so we are planning a joint review sprint to approve users and provide feedback. Code sprints have proven to be an effective tool for productivity on a certain topic, so we want to get together to have some fun and help each other.
The sprint will take place virtually in IRC #drupal-codereview and in Google Hangouts, starting on Friday 16th of August.
The goal of the sprint is to gather as many code review administrators as possible for approval of RTBC project applications, as well as new contributors and other volunteer reviewers that can discuss projects under review and provide feedback. Everybody welcome!
We have some confirmed special guests for this sprint:
- chx - opinionated long term contributor and Drupal development specialist, as well as security team member that can spot problems in code immediately
- patrickd - puppet master of ventral.org and simplytest.me (our most frequently used automated review tools), project application review nanny
- kscheirer - hyperactive git administrator with a sense for sanity, powered by Top Shelf modules
- sreynen - initiator of Project Review Wednesday and drupal.org webmaster
- cweagans - git administrator featuring 8 kinds of awesome, 1 invisible to the naked eye
- mlncn - multi-talented Drupal evangelist, book author and git administrator
- greggles - security team lead with a history of amazing project application reviews
- klausi - regular project application reviewer, creator of the pedantic coder sniffer, discoverer of countless security problems in project applications
Ideas for activities during the sprint:
- Coordination in IRC who reviews what, Q&A with applicants and reviewers
- Google Hangouts with screen sharing to demonstrate how a code review admin performs a review
- Security issue scoreboard, who can find the most security vulnerabilities in project applications during the sprint
- status and discussion of our plans to improve the project application process
- Your idea here
TODO:
- Contact other code review admins and persuade them to take part in the sprint :-)
- Get other community members involved in the project application review process and the sprint
- Collect ideas and community feedback about the structure and activities of the sprint
- Define a twitter hashtag we want to use for this sprint
This is going to be a great event and I'm looking forward to it! I invite you to join, just let us know if you are planning to attend!
Comments
I should probably put my
I should probably put my money where my mouth is and show up. I'll see if I can make it. :)
Great, don't forget to sign
Great, don't forget to sign up to get a reminder about the event. Looking forward to meet you!
Good to hear from you!
Hey fuzzy -- it has been awhile. Did you go to Drupalcon Portland? Are you going to Prague? You have important things to say (IMHO). Maybe I'll join this thing if you are.
Thanks for the support. :)
Thanks for the support. :) Since I'm from Norway, Portland was a bit far. But I am coming to Prague, and my opinions are coming with me. ;)
Looking forward to
Looking forward to it.
Now...what to try to focus on during the sprint.
And...to brush up on the process since so many things are automated now!
knaddison blog | Morris Animal Foundation
Sprint focus
I want to get the RTBC applications down to zero, then clear up as many as possible from the "needs review" state. Having an empty queue again would be a nice accomplishment :-)
And I want to spend time chatting and idea sharing about code reviews and the future.
Signed up to get the
Signed up to get the reminder, but it'll depend on reality whether I make it and for how long. Me being in a wacky time-zone an all.
Can we
clean out some old/angry issues?
Members page - https://drupal.org/node/1237070
TAP CMS - https://drupal.org/node/1594624
Perhaps the owners of
Perhaps the owners of applications should have been notified, so they could've cleared out time for this period to work on their applications as well. Since I'm guessing a lot of applications that needs more work will just receive their review and then sit there until the author respond.
Dealing with Anger Management
Uh, that would probably be me.
I would have been content to let sleeping dogs lie were it not for my latest effort to become a Drupal contributor.
I actually review a lot of code, but all recent efforts have been directed at contributed modules - those modules that are not subject to any kind of review process. If the modules don't work as described (which is far more often that any Drupalista would care to admit) but they have the potential to be useful to me, then I do my best to get them to work.
I recently volunteered to become a co-maintainer of the Vote Up/Down module. There are 4 sub-modules in this project. The vud_node module for D7 has never worked properly like it did in D6 -- 2½ years after the release of D7.
I sumitted a series of patches along with a wholesale replacement of VUD that did not impact any of the other sub-modules. It was RTBC'd by 2 members, and support was expressed by 5 others to promote me to co-maintiner status.
Then the project maintainer did a code review. Apparently purity of code and doing things the Drupal Way is far more important than if the module actually works or not.
Another considerate member did a search for available sandbox namespaces and encouraged me to establish a sandbox project that I could submit as a project application.
But I have walked down that road before. I know I will be challenged on the collaboration over competition ethos of Drupal. And there will be more questions about why I am not doing things the Drupal way. It will be another dip into the Baptism by Fire tank that has become the Drupal code review process -- the process that is only applied to those who hope to become contributors. And it will probably take a few months.
Drupal core (6,7 & 8) is a pretty amazing product. But a lot of the contributed modules (if I can paraphase Steve Jobs) are just shit. There is no code review or even a means of expressing your dissatisfaction with a module that does not work other than through the issue queue. And we have all seen the creative queue management techniques used (postponed, worked as designed. cannot duplicate) used to minimize the perception of problems.
I'm an atheist. It's not easy to admit to others (especially Mom) that you have lost faith in God and why. It is just as hard to admit here that you are losing faith in Drupal and why. But I keep trying.
Thanks for improving the
Thanks for improving the modules out there! Please also note that there are many contributed modules that are well maintained, well written and I enjoy relying on them.
To be clear: we encourage collaboration between contributors, but if that fails it is perfectly fine to fork a project and develop it on your own. Just state that on your application and your project page and nobody will complain.
And you cannot expect or demand that other people solve all your problems - at some point we all have to step up and take responsibility for a module that we want to see in a good state. Yes, the world can be hard: not all people work for free for you, what a surprise!
And you can complete a project application within days or weeks with the review bonus program - just make sure that you respond to reviewers in a timely fashion and set the correct status.
OK Klausi
I usually in agreement with much of what you have to say but in this case I'm making an exception to your penultimate paragraph.
I may not be as smart as you Klausi, but I am not the helpless fool that you make me out to be. I help others when I can and I'm not in any position to make any demands on anyone, unlike some here.
So, let's see? All I have to do is setup a sandbox of a duplicate module, along with maybe a history and a motivation page in additional to the usual project page. This is because, face it -- there will be questions to answer, Nobody will complain? Ha ha Klausi, that's funny. I didn't know that Germans could do sarcasm.
Oh yeah, one last requirement, participatation in the review bonus program. Maybe do 3 or 4 random reviews of tiny little modules submitted by newbies who hope that their module is small and innocent enough to pass review quickly?
It all can be accomplished within days or weeks you say?
<sarcasm>Oh Yeah! I'll jump right on it!</sarcasm>
Now let's talk about expecting and demanding others to solve your problems.
Hoorah!
I see an empty RTBC Queue!
Good job done by all!
Move on to the Needs review list I guess..
No really, if you select the
No really, if you select the "needs review" ones:
https://drupal.org/project/issues/projectapplications?text=&status=8&pri...
I get 1 full page of work still to do :)