What's your idea?
Code review is an essential part of the contribution process. At the moment we have a sub-standard tool for doing this, which is not easily accessible to everyone (requires a user script installed to the browser). This would greatly improve code quality.
Currently, a javascript Browser plugin, Dreditor provides some of this functionality, but at a very basic level.
Open source tools that could be used include Phabricator http://phabricator.org/#differential
Github pull requests provide this capability.
What are the benefits?
Better user experience for core and contrib developers. Tools available to more people, no need to install additional script. Easier code review.
What are the risks?
How can we measure the impact of this idea? (metrics)
Who directly benefits from / will use this improvement? (target audiences)
Core and contrib developers
Comments
i think quite some of the
i think quite some of the dreditor functionality would be fixed by
Move Git repositories to Github .
Review Board
My partner, who works at a commercial software company developing C/Java/Perl code, uses an open-source code review tool called Review board. Every time he sees me reviewing a patch in the drupal.org issue queue he bangs his head in consternation and says we should be using Review Board. The main killer features:
- See the changes visually - you can do this now at the command line if you know what you're doing with diff, but would be nice to see automatically on line and this is about all moving to GitHub would buy us.
- Comment on particular changes and have a discussion about them. The comments are shown along with the changes. Killer!!!!
http://www.reviewboard.org/
Take a look at the screen shot... I think that is what we should adopt.
Drupal programmer - http://poplarware.com
Drupal author - http://shop.oreilly.com/product/0636920034612.do
Drupal contributor - https://www.drupal.org/u/jhodgdon
Gerrit
Did anybody tried https://code.google.com/p/gerrit/ with drupal. I really like fisheye (https://www.atlassian.com/software/fisheye/overview), but i am looking for an open source alternative.