Reviews and Mentoring for visabhishek

We encourage users to post events happening in the community to the community events group on https://www.drupal.org.
You are viewing a wiki page. You are welcome to join the group and then edit it. Be bold!
Posted by visabhishek on September 11, 2016 at 11:07am
Last updated by visabhishek on Fri, 2017-01-13 06:56

This wiki page is created to keep track of visabhishek's Project application reviews as suggested by klausi . As a reviewer I hope to get more advice from more experienced reviewers. Please use the comment field to add your advice, corrections, and observations.

Some projects have multiple reviews.

Security Issues:

  1. [D7] Follow Unfollow
  2. [D7] Course Admin
  3. [D7] Exam Spider
  4. [D7] PHP Code In Views
  5. [D7] Commerce Amazon MWS
  6. [D7] E-MAILiT Share Buttons
  7. [D7] TypeIt
  8. [D7] Simple Node Importer
  9. [D7] Instagram Scrape Feed
  10. [D7] Parameter Message
  11. [D7] Taxonomy Comment
  12. [D7] Staging Widget
  13. [D7] Webform Attributes
  14. [D7] ALXS Matrix

Reviews List:

  1. [D7] passwordwidgets
  2. [D7] Deactivate Account
  3. [D7] Emmet
  4. [D7] Google Drive Docs Viewer
  5. [D7] Bootstrap Login Authenticate
  6. [D7] BMI Add Ons
  7. [D8] unique_field_ajax
  8. [D7] Dblog Quick filter
  9. [D8] Social Auth Google
  10. [D7] Push Notifications Web
  11. [D7] Reading Progress Bar
  12. [D7] Mockingfish A/B Testing and Heatmap Tool
  13. [D7] Entity Unique
  14. [D7] Availability Calendar Rules
  15. [D7] Vocabulary Validation
  16. [D7] profile_picture_plus
  17. [D7] User Access Timeslot
  18. [D7] Webform Replay
  19. [D7] Membership Entity Expiration Notice
  20. [D7] Yesmail Integration
  21. [D8] Superslides Fullscreen Caption Slider
  22. [D7] FullContact
  23. [D8] Maintenance Notifications
  24. [D7] Simplelogin
  25. [D7] SCM Music Player
  26. [D8] Google CSE
  27. [D7] CSRF Module
  28. [D7] Context menu item visibility
  29. [D7] REVE Chat - Live Chat Software
  30. [D7] Webform Redmine
  31. [D8] Hide Path
  32. [D7] Nodequeue Auto Rotate
  33. [D7] webClinicPro
  34. [D7] Commerce Amazon MWS

Comments

Thanks for starting this and

Posted by klausi on September 22, 2016 at 9:37am
klausi's picture

Thanks for starting this and all your help! Extra bonus points for security issues that you find, please list them separately above so that we can also track those.

I noticed that you post the

Posted by klausi on September 22, 2016 at 9:42am
klausi's picture

I noticed that you post the project application review template to issues, although some other reviewer has posted the template already on that issue. Posting the template multiple times is annoying and does not provide any new information to applicants. You should leave out all points of the template that have already been mentioned by other users and that the applicant follows correctly already. Can you go back to your review comments and edit them so that only the relevant sections of the template remain?

Thanks klausi. I will recheck

Posted by visabhishek on September 23, 2016 at 11:05am
visabhishek's picture

Thanks klausi. I will recheck my review comments and update if template already posted by other reviewer.

Security issue reported

Posted by visabhishek on October 11, 2016 at 6:44am
visabhishek's picture

Hi ,
I have included some sucurity review links in this page.

Hope i will get some more advice from git administrators.

Thanks
visabhishek

Thanks klausi for Assignment

Posted by visabhishek on October 23, 2016 at 2:20pm
visabhishek's picture

Thanks klausi for Assignment https://www.drupal.org/node/2642870#comment-11741957
[D7] Commerce Amazon MWS

I have added your points in my learnings, So that i can use in next project review.

Thanks klausi for Assignment

Posted by visabhishek on October 25, 2016 at 6:37am
visabhishek's picture

Thanks klausi for Assignment https://www.drupal.org/node/2667164#comment-11744390
[D7] E-MAILiT Share Buttons

Hi klausi, I have added some

Posted by visabhishek on January 10, 2017 at 5:55pm
visabhishek's picture

Hi klausi,

I have added some more Security reviews. Please check once and guide me for the next step.

Thanks
Abhishek

One more security review for

Posted by visabhishek on January 11, 2017 at 5:54pm
visabhishek's picture

One more security review for [D7] Webform Attributes

Added one more security

Posted by visabhishek on January 13, 2017 at 6:56am
visabhishek's picture

Added one more security review [D7] ALXS Matrix

All looking good, thanks a

Posted by klausi on January 13, 2017 at 12:44pm
klausi's picture

All looking good, thanks a lot!

I think you are ready now to be promoted to git admin on drupal.org. Before we can do that you need to set up 2FA for your drupal.org account: https://www.drupal.org/drupalorg/docs/user-accounts/setting-up-two-facto...

Let me know once that is done then we can open the webmaster issue to promote you.

Thanks Klausi, I will do my

Posted by visabhishek on January 13, 2017 at 3:55pm
visabhishek's picture

Thanks Klausi,

I will do my very best to surpass your expectations and will continue my learning and hope day by day you will see improvements.

I completed all configration for set up 2FA of my account on drupal.org. Please let me know if any other settings are required.

Cool, I opened the webmaster

Posted by klausi on January 13, 2017 at 4:37pm
klausi's picture

Cool, I opened the webmaster issue to promote you: https://www.drupal.org/node/2843384

Please comment there that you would like to help out as git admin.

Other git admins: please comment with a +1 on that issue or raise any concerns that you might have.

Thanks!

And you have been approved,

Posted by klausi on January 13, 2017 at 4:47pm
klausi's picture

And you have been approved, congratulations!

Here are instructions on how to use your new powers: https://www.drupal.org/node/1125818

I added you to the list of git admins at https://groups.drupal.org/node/142454

If you have any questions feel free to ask here or on IRC in #drupal-codereview

Thanks klausi, I will read

Posted by visabhishek on January 13, 2017 at 5:28pm
visabhishek's picture

Thanks klausi,

I will read the instructions properly and use the powers carefully.
Once again thanks.

I have looked into the

Posted by naveenvalecha on January 13, 2017 at 4:53pm
naveenvalecha's picture

I have looked into the security reviews done and all looked good.There are few minor that will help in improving the review:
1) Use the project review template in reviews that will cover all of the things if anyone has not used the template before.
2) Add the git commit head before the start of the manual review.
3) In some of the reviews, there was only security review and it did not include the manual review.It's fine to review it two times as you're comfortable, but it's good to cover all items one time.

Rest looks good to me.

// Naveen

Naveen Valecha
https://www.valechatech.net

Hi naveenvalecha, Thanks for

Posted by visabhishek on January 13, 2017 at 5:31pm
visabhishek's picture

Hi naveenvalecha,

Thanks for your points, I will follow the same in my next reviews.

Congratulations Abhishek on

Posted by naveenvalecha on January 13, 2017 at 5:03pm
naveenvalecha's picture

Congratulations Abhishek on your promotion https://www.drupal.org/node/2843384

Naveen Valecha
https://www.valechatech.net

Thanks Naveen Valecha.

Posted by visabhishek on January 13, 2017 at 5:32pm
visabhishek's picture

Thanks Naveen Valecha.