Reviews and Mentoring for heykarthikwithu

In order to join this group, you must login or register a new account. After you have successfully done so, you will need to request membership again.
You are viewing a wiki page. You are welcome to join the group and then edit it. Be bold!

Posted by heykarthikwithu on March 11, 2016 at 6:35am
Last updated by heykarthikwithu on Mon, 2016-10-03 11:20

This wiki page is created to keep track of heykarthikwithu's Project application reviews for him to get advice and mentored by Git administrators and anyone else who might have suggestions, advices, etc.

I would like to thank team and everyone else for their effort in reviewing applications. Drupal always had clean, secure and fast code compared to other projects; Core and contrib alike. I realized project applications play a major role in vetting and reviewing new projects, so I wanted do what I can.

A list of security issues I could find in the candidate modules:

Reviews

Following are the reviews I've made, manually entered, and are in the order of the issue's age (oldest first). I excluded some reviews that I didn't add helpful/constructive reviews.

Comments

Thanks Karthik for

Posted by naveenvalecha on March 19, 2016 at 7:32pm

Thanks Karthik for starting.Nice reviews, I believe you would also encourage & help others guys to review the project applications and help to reduce the backlog project applications that are under review https://www.drupal.org/project/issues/projectapplications?text=&status=8...

Thanks for following review template https://groups.drupal.org/node/427683 There are couple of also good templates available that are helpful in reviews , https://groups.drupal.org/node/184389

By @mpdonadio from my mentoring:

The main application blockers are security problems, licensing issues, and third-party code. The fourth are "major API problems". To quote @klausi from my mentoring:

Project application reviews are basically sanity checks, so while providing all details what can be improved is very valuable we have to consider what issues are really blocking approval. If we are confident that the people basically know what they are doing then we should not hold them back. With the exception of security issues and licensing issues.

I personally set applications to needs work if the API usage is so painfully wrong or the spaghetti code issues just keep piling up. Fortunately people fix all the things from pareview.sh, so at least we don't have to complain about coding standards anymore.

Naveen Valecha
https://www.valechatech.net