This group's purpose is discuss, document, and rally around the code review process for new contributors as well as code reviews for existing modules (outside of the security team), and to help people become (better) code reviewers.
This is not a place to ask someone to review your application.
Code Reviewers
We should highlight all the great people that have done reviews. This is a wiki page to do that. Please note that there is also a I reviewed Project applications checkbox in your Drupal.org profile.
| Reviewer | Example of awesome reviews | Community comments |
|---|---|---|
| zzolo | http://drupal.org/node/723372 |
Module Approval Process is Too Slow
We have many individuals waiting to be reviewed, and few reviewers. This gives us a backlog of applications awaiting review, which makes both reviewers and applicants unhappy. So how can we improve this?
Read more
Code Review Sprint at DrupalCon Chicago 2011?
As I updated all the CVS applications tonight (with some great help), I couldn't help but think that its still so unwieldy. So, I was thinking about maybe organizing a code review sprint at DrupalCon Chicago next week focused on the new Full Project applications.
It would be super cool to get applicants and reviewers paired up in person.
So, I am wondering if anyone has any thoughts or suggestions, especially on logistics. Also, my bandwidth is pretty low so maybe someone is willing to help out on this.
Read moreIssues requesting Peer Review
All issues requesting peer review use the peer-review tag (with a dash, like this group). People can also optionally focus the review they are looking for with tags such as code-review, ux-review, etc.
Read moreCombine Peer Review and Code Review groups
I noticed that the Peer Review group is being revitalized and the mission expandedand there is a movement for a more structured peer review of modules program, which is awesome.
Read moreContributed Module Code Reviews
Code review of existing contributed modules is frequently cited as a means to improving the quality of existing contributed modules. However, the task of performing a code review falls somewhere between documentation, writing and reviewing patches, reviewing CVS applications, and creating new modules.
This is a proposal to elevate the visibility of module review, and make it easier for newcomers to perform module reviews.
Read more
Code review outside of the repository access application process
I'm writing that new developers can ask for a code review quite apart from the application review process, but i don't have much i can tell them except ask in IRC and (suggested by beejeebus ask in a g.d.o group on a topic related to your module.
Should we try to create a clearinghouse?
A "code review requested" tag for issues– or projects?
Any other places that exist or ideas for what should or should not be created?
Read moreHow do we get more people to review code?
So, the whole purpose of this group is to create discussion, document, rally around getting more people involved in reviewing new contributors applications.
In Copenhagen, @webchick gave a talk about how this process is pretty negative to most people applying. And, with @webchick's help, we were able to get a BoF going and some short-term, new interest around reviewing application. I even spent a fair amount of time documenting how to review code.
Read more