This group's purpose is discuss, document, and rally around the code review process for new contributors as well as code reviews for existing modules (outside of the security team), and to help people become (better) code reviewers.
This is not a place to ask someone to review your application.
Not a a serious applicant?
Think we have some kind of problem here: http://drupal.org/node/1388210
For me it seems like this is a company, and not a person, also, there are a reviewer in that issue, that have done nothing else on d.o. than to approve this application (and the code is not there yet), also, another application http://drupal.org/node/1424990) got comments from another new user, that jut seems to advertise the same company as in http://drupal.org/node/1388210.
Read more
Denver Project Application Sprint Brainstorming session - Time to start planning
We'll be holding a 'Project Applications' sprint during DrupalCon Denver, and I wanted to start a topic to discuss potential items of focus.
Read more
Third party API's or Native Jquery API?
Hi,
Here i would like to know which is the best approach to create a module , with third party JQUERY libraries or native (Own written) JQUERY API?
Personally i am voting for Native JQUERY APIs, instead of downloading the other third parties JQUERY libraries.?
Read moreHow much should we demand of the applicants?
Regarding: http://drupal.org/node/1387232#comment-5574060.
Sometimes I feel that we demand to much of the applicants. That we are to picky, and we make it really difficult for having users access to create full projects. Many of the modules that already is out there have a lots of issues with their code, but we together help to improve it with patches and fixes. We can not demand that every sandbox project should meet standards that the most of the modules does not do that are already out there.
Read moreBug squad feature
This feature module is firstly aimed to members of the squad so that the quickly can setup a new, or start fresh, site to be able to for example work on patches or other issues for the media project.
This application: http://drupal.org/node/1429034
I see the need for the bug squad to have this, but I do not see the reason why it should be a full project on drupal.org...
Read moreProject Apps State of the Union
This post reflects my personal opinion and observations regarding Drupal’s Project Application Process, and developments in this space over the past 12 months; with an analysis of the current state (relative to the process mission and goals) and recommendations moving forward.
Tl;dr: Don’t beat up applicants with repeated PAReview scans. For coding standards, the reviewers job is to ‘identify and educate’, not ‘enforce’. When it comes to security and licensing, THEN you can play the role of ‘bouncer’.
Process Mission
Read moreRefactoring of other Drupal 6 module which is not on d.o
How do we do with this kind of application: http://drupal.org/node/1426462
As it says it is built upon another module (for D6, this is D7), but it is not on drupal.org. So how do we handle the collaboration issue in this case?
Shared accounts?
Just a question, regarding this: http://drupal.org/node/1050072 -is shared accounts allowed on d.o?
Read moreToo short?
This project http://drupal.org/node/1419816 is a little bit short I think, it has five functions, but has not so much code in them. I think it is too short for full git access. What do others think here?
Read more
question about a code review for the admins here
I recently did a review of a new module applicant http://drupal.org/node/1379794#comment-5514576 and found that the linkedin module that this person's module depends on doesn't use the library api and the Oauth.php library that it includes isn't namespaced and I cannot even load up this persons module or the module that it depends on (the LinkedIn Module) -- I get lots of "can't load a class twice" type of errors. I don't know if the fact that the module this person is depending has this flaw should hold up his application?
Read moreGetting code sniffer to work in eclipse with .module, .inc, and .info files
Hello,
I have Drupal Code Sniffer working in Vim, and now in Eclipse (which is my preferred IDE), and it applies the Drupal Coding Standards and reports errors with a little red "x" on the side. But in Eclipse it is only working with .php files I have .module and .info files showing up with php syntax highlighting, but can't seem to get codesniffer to run against them. Any advice or a link to a tutorial would be fabulous.
Thank you.
Read moreAnother question on a review
I'm reviewing http://drupal.org/node/1379794#comment-5482518 and I went to install it and see that the applicant is really just extending the LinkedIn module http://drupal.org/project/linkedin Do we want to encourage the applicant to work with the maintainers of the LinkedIn module? The applicant is adding these 2 features:
Displays 'Latest Discussions' Posts in a Block for the specified Group
Displays 'Most Popular Discussions' Posts in a Block for the specified Group
Question about doing a code review
Simple question:
If I'm doing a code review and go to http://drupal.org/sandbox/chhavik/1379612 for instance. The repository viewer has changed and I no longer find it as intuitive. So I follow the directions on http://drupal.org/sandbox/chhavik/1379612 and do: git clone http://git.drupal.org/sandbox/chhavik/1379612.git linkedin_group_posts but then can just see the master branch. That seems normal, but then I do git branch and I can only see *master
Encouraging applicants to review other projects
I spent quite some time on the project application issue queue in the last months and enjoyed my work on the automated review scripts (pareview.sh and drupalcs). It was a happy day when we reached zero "needs review" applications in November, but I'm a bit frustrated that we are back at 113 issues needing review now. A handful of people is putting quite some effort into the queue, but this is not sustainable and we are at a point where the queue will get out of control again -- soon.
Read moreApplicants with Multiple Applications
So I discovered yet another multiple application applicant today, and attempted to link him to the 'only open one application' text on the 'Full Project Application' pages.
To my surprise, that particular text does not exist. Let's get it added!
And as an unrelated item, I should be posting this as a todo in a 'Project Application Process' issue queue, not on g.d.o! :)
Read more"Lost" Contributors
We should define a tag for "Lost contributor due to frustration with the review process" ... http://drupal.org/node/1175346 as an example.
Read moreHow shall we handle non-typical/highly advanced applications?
Jumped to the bottom of the queue today, and found http://drupal.org/node/1335872 sitting there.
Reviewing this particular application would likely require knowledge and/or experience with Aegir, ldap, drush, and Apache authentication configurations. I can provide a review and comments based on the code structure and coding standards ... but I suspect that our current base of reviewers does not have the depth of knowledge or experience to be able to flag it as 'secure' or not; and I know that I don't feel 100% comfortable reviewing a non-typical project of this complexity.
Read moreNew 'Project Applications' d.o development environment
I requested a development site for Project Application related development at http://drupal.org/node/1367370 ... if you've got access to stagingvm, the build is called project_apps.
I've also opened a sandbox project for a drupalorg_projectapps module, which can be found here.
Read more
How to seach text from .txt file
i need this help on drupal.
i have a text file and file name is C:\wamp\www\mysite\sites\default\files\abc.txt. in this file is;
aaaaa bbb
ccccc ddd
eeeee fffff
if i type aaaa in the search box and hits enter means the output should come with the node containing the word aaaa and this this text document also.
This will be shown in search output
is there any module available for that?
thanks.
Read moreHow much code do we need to approve a user?
The project application review process is done only once per applicant, so we need to make sure that they provide us with enough self-written code that we can review. Otherwise we cannot really judge their skills and understanding of Drupal.
Read more