drupal code review

A plan for incentivizing code review of every project, not just new ones, after the project applications revamp is open for suggestions and feedback.

In particular, deputizing kattekrab— or proposing another person or another approach.

https://www.drupal.org/node/2736981 => Give kattekrab the power to give people the power to approve project applications

But i'm three hours into a stint of just approving RTBC projects (and not yet halfway done?), which should never be our backlog, and after Damien McKenna made a huge dent in that queue yesterday.

Some steps of current review process:

1. Users are creating sandbox for their new projects and get reviews from other community members.
2. Other reviewers give him instructions and some guidelines related to code/Security etc.
3. After too many reviews and changes in his code, Project finally gets approved, which upgrades his permission to create a full project.

So my question here is

Why we are giving access to users to create full project without any code review?

If anyone have permission to review drupal module then please review my drupal sandbox module.

Sandbox project link :- https://www.drupal.org/sandbox/karan/2246897

Module description :-

Using this module you can able to view the node author informations.

How to use this module :-

Install node authore module and profile 2 module.
Go to config page and click on Node Author link.
Select profile and its fields.
Go to block page and add node author block on any region. When you open and content related author value will be display in node author block.
Module version : 7.x - 1.x

Hi,

I've spent several days working on my first module and have found the code standards review to be incredibly difficult.

First of all - let me say that I completely agree with strict code standards - and it's vital that new modules stick to these standards in all ways.

My module was written for D6.

As you guys may all be fully signed up module maintainers it might be an idea for me to outline the steps I've worked through recently so you get an idea of the problems for people publishing new modules.

Obviously installed coder and coder_tough_love.

If you have already got a theme(s) listed as a full project on Drupal.org then you will be aware of the process of having to have your first project 'reviewed and tested by the community' before being granted access to create new full projects.

The people who review and devote time need a big thanks as they enable to D.O. community and resources to grow, so thanks!

The goals of my project are:

1. to develop additional reviews in the Secure Code Review module
2. to improve the reporting of results from the module
3. to provide Drush commands to invoke the reviews

I'm writing that new developers can ask for a code review quite apart from the application review process, but i don't have much i can tell them except ask in IRC and (suggested by beejeebus ask in a g.d.o group on a topic related to your module.

Should we try to create a clearinghouse?

A "code review requested" tag for issues– or projects?

Any other places that exist or ideas for what should or should not be created?

While searching for how to integrate drupal with a "light" webserver called Hiawatha, I find this comment intriguing:

http://www.hiawatha-webserver.org/forum/topic/222

In one of the comments, Hugo Leisink says that he doesn't recommend drupal because of the "ugly" code.
He says "On a simple page that showed a list of 15 items, Drupal needed more that 400 database queries."

I know drupal does these queries so it can do logging and for other status information, but I think you can disable these logging features.