I miss one WU again(:-( mainly because of final deadlines in my courses last week), but here are the news for both weeks.
It's divided in 3 sections: tests, stable branch and oop branch.
tests
Like jpetso comment on my last WU, we plan to make tests for the versioncontrol api.
The tests were implemented on the actual stable branch of versioncontrol module, and then ported in the oop branch(well, at the start I was not doing it, but after talking on irc jpetso makes me realize it's the right way :D).
Now we have the following tests(checking the messages and DB values) on top of a mock backend module(versioncontrol_test):
- repository add/edit/delete functional tests on both branches
- start of repository unit testing on oop branch
- versioncontrol_account_status functional testing on workflow proposed by jpetso(on the same comment refered lines above)
Here I'm using Drupal 7 way for testing mails(using adrupalGetMails()method and implementingdrupal_mail_wrapper())
stable branch
Some little fixing commits to stable branch(and ported on oop too):
oop branch
- some more oo-ification to commitlog and its dependencies(1, 2)
- tests make me notice repo update was not working on oop branch, so I fixed it after it
- let add account status on repo add work
- port the three new jpetso commits(new data column for repos, data column usable by other modules and Fix the Commit Restrictions setting) on stable branch to oop (see 67874e, ec394c, 376d35)
- fix: return account menu wildcard loader to module file(point 1 in sdboyer suggestions
:D) - replace all
versioncontrol_get_repository()/versioncontrol_get_repositories()calls by his oop version - account: let user page work
