Reviewers

This group should probably have more organizers. See documentation on this recommendation.

A major pain in the butt for many developers is that their patches never gets reviewed (me included), therefore this group was created. It's purpose is to help people to make reviews, to coordinate reviewers, share experience and a place for review exchanges (i.e. I'll review your patch if you review mine).

Useful links;
http://drupal.org/node/10261 - The revision process

http://drupal.org/node/10262 - Criteria for evaluating proposed changes
http://drupal.org/node/318 - Coding standards
http://drupal.org/patch/review - Tips for reviewing patches
http://drupal.org/node/60108 - HOWTO: Apply patches
http://drupal.org/node/79237 - HOWTO: Benchmark Drupal code
http://drupal.org/patch-bingo - Play patch bingo, and do it often
http://drupal.org/patch/spotlight - The patch spotlight

And of course http://drupal.org/handbooks in general.

Hashing in pgsql

Posted by forngren on January 28, 2007 at 2:54pm

Hi,

Could someone please look at http://drupal.org/node/29706 and see if it's pgsql compliant? How do the CONCAT, MD5 and SUBSTRING functions behave on PostgreSQL?

Thanks,
Johan Forngren

Attention reviewers!

Posted by forngren on January 5, 2007 at 3:52pm

Drupal 5.x is so close that we can almost smell it!

Here is a list with all patches against Drupal core marked "code needs review" and tagged with any 5.x version (beta, rc, dev). Currently it is three sides long, which IMO is far to long. Can we try to bring it down to two pages? That is a realistic goal and will increase the stability of 5.x and release some pressure of developers. Thank you.

http://drupal.org/project/issues?projects=3060&versions=96923,103420,100...

Two important issues to trade reviews (IMO)

Posted by RobRoy on December 28, 2006 at 6:36pm

http://drupal.org/node/92630 - THIS one is the biggest usability issue I've come across and we have a great simple fix, just needs some momentum behind it and needs it fast! It's got Steven's stamp of approval but needs some more voices.

http://drupal.org/node/104763 - Define page and story in default.profile. This patch also changes page's workflow to not promote to front page and have comments disabled.

Real simple patch for RC1

Posted by drewish on December 28, 2006 at 12:02am

Filters aren't being applied to RSS feeds: http://drupal.org/node/103371

Trading issues to review

Posted by ChrisKennedy on December 7, 2006 at 6:56am

I have participated or commented on a few issues that need a review, most of which are very minor changes. I'll trade reviews one-for-one with anyone who's interested. Here is the list of issues.

Here are my top ones:

Request for the review the ChipIn module

Posted by RobRoy on August 28, 2006 at 10:24pm

Not sure of the correct/preferred layout of a review request, so I'll just cross post from the dev mailing list.

I've just committed a beta version of the ChipIn (see http://www.chipin.com) module to contrib/modules/chipin (http://drupal.org/project/chipin). I was looking for some peer review of the module. I'll gladly return the favor, it's just nice to have another set of eyes look things over for usability, security, etc. So if you have a module/patch you'd like me to go over in return, let me know. I think it's pretty cool to have the donation thermometer to see how much we still need for each fundraising drive and ChipIn.com is pretty well done.

Subscribe with RSS