Posted by davidhernandez on January 9, 2015 at 6:51pm
Start:
2015-01-17 (All day) - 2015-01-18 (All day) America/New_York Organizers:
Event type:
Sprint
See https://groups.drupal.org/node/454073
We are holding a virtual sprint during the Drupal Global Sprint weekend, January 17-18. See https://groups.drupal.org/node/447258
The goal of this sprint is to work on project application reviews, particularly helping the Git admins reduce the current RTBC backlog.
Please signup if you are interested in participating. Collaboration for the sprint will happen in the #drupal-codereview IRC channel.
Comments
I am available on IRC channel
I am available on IRC channel via #drupal-codereview.
Pushpinder Rana
For those that have not done
For those that have not done reviews before, here are some places to start:
1 - IRC, #drupal-codereview. Help and discussions here.
2 - The homepage of the code review g.d.o group. https://groups.drupal.org/code-review
3 - Instructions for reviewers, to get a general sense of the workflow. https://www.drupal.org/node/894256
For everyone:
We can sprint using a smaller set of checks. Essentially:
1 - Check for licensing issues.
2 - See that the applicant knows how to use the Drupal API.
3 - Do a security review.
The idea is to approve the application unless you find a good reason to block it. These projects are considered "in development" so they can have bugs. Things can be fixed in their own issue queue after they've been approved. We mostly just want to make we sure don't give the ability to create full releases for a project with security issues.
If a module displays errors, has performance problems, typos, ugly 'if' statements, that's ok as long as there are no security problems. If the person used the Drupal API correctly everywhere, but made a mistake in one place, that's ok. Leave a comment recommending these things be fixed, but you don't need to block the application.