OG updated and notifications changed

We encourage users to post events happening in the community to the community events group on https://www.drupal.org.
moshe weitzman's picture

I upgraded to latest OG and switched to its Notifications module integration. Please report oddness here. Thanks.

A few days I upgraded signup and modr8 modules. FYI.

Comments

Nice

Senpai's picture

Thanks for that. We'll keep an eye out for oddness.
______________________________
Senpai  ~ Want a better WorkHabit? ~


Joel Farris | my 'certified to rock' score
Transparatech
http://transparatech.com
619.717.2805

Thanks! I'll take any chance

christefano's picture

Thanks! I'll take any chance I get to use the Update Scanner extension for Firefox less. Unfortunately, the outgoing notifications don't include any links to the new or updated content.

Can you update Signup to the 5.x-2.x-dev version? It has two features that would make life on groups.drupal.org much better, namely providing the signup form as a panel (#321531) and adding backend support for cck date fields (#86462).

.

Michelle's picture

I noticed that as well. Was neat getting the email but pretty useless if I can't click to go to the thread.

Michelle


See my Drupal articles and tutorials or come check out the Coulee Region

I have a question in to the

moshe weitzman's picture

I have a question in to the Notifications people about this. I didn't see how to add the link in the template.

The template is at

christefano's picture

The template is at admin/messaging/template/edit/notifications-event-node-comment and the [comment-url] token should work. Please add [ogname] in the subject, too.

That token is already there.

moshe weitzman's picture

That token is already there. To me, it seems that this template is not in use. I just gave you admin rights. Feel free to make changes to templates as you see fit.

Apparently, there is no

moshe weitzman's picture

Apparently, there is no changing the digest template. Jose expects that to be available later this week. Surprised this did not come up on other sites. I might change existing subscriptions to not be digested. I bet some want it, some don't.

I know that noone wants linkless emails - thats will be fixed one way or another this week.

Hmm, you're right. The

christefano's picture

Hmm, you're right. The digest templates are much more limited.

We didn't have digests before and I'd rather use the highly granular notifications that Notifications offers. People can still approximate a digest mode by only subscribing to the groups or content types they want and then configuring their notification intervals to daily or weekly.

If we go ahead with this then I can update the templates with the appropriate tokens. It's a significant departure from digest mode, though, so I won't make those changes yet (although you've greenlighted me to do that -- thanks!) unless I hear it's okay.

I don't see a dependency

moshe weitzman's picture

I don't see a dependency here. Just improve the non digest templates. Those are already being sent to people who select immediate. They may or may not get sent to more people, but thats immaterial.

I am also seeing some duplicate notifications. Am working with Jose on that.

new and improved

christefano's picture

It's taken me a little while to understand how Notifications decides which type of notification message to send. I enabled node update notifications and improved the other notification types (after all, the axiom is "if it's new it's not improved; if it's improved it's not new").

The tokens are a bit buggy, though. With wiki pages in mind, I enabled node update notifications to include the username of the editing user and noticed that [user-name-raw] doesn't work here when it does on my test site. Any idea what that's about? It may be fixed by updating Token (which is a good idea before updating Date).

user-name or author-name?

greggles's picture

Are you trying to get the current user or the node author?

[author-name]
Node author's user name

vs.

[user-name]
The name of the currently logged in user.

Does Token support getting

bonobo's picture

Does Token support getting the username of a user revising a node? While I've seen this for comments and, (obviously) for node authors, I haven't seen it for users revising nodes.

That would be great functionality.


FunnyMonkey
Tools for Teachers

sure

greggles's picture

Most of the time that's the currently logged in user, so that's the [user-name] token.

I don't know about a token for "this node revision" - thinking about it more, it probably doesn't do that.

Hmm, that's how I thought it

christefano's picture

Hmm, that's how I thought it was working. I was testing my own posts, of course, so I was getting false positives.

I'll submit a patch to Token that adds support for the revision's author.

patch submitted

christefano's picture

Node update notifications are turned off for now (at least until Notifications can be configured to send update notifications for specific content types, like wiki pages and events), but I did submit a patch at http://drupal.org/node/331238

Ditto. I find the

ebrittwebb's picture

Ditto. I find the notifications becoming increasingly frustrating without any links. I would rather have the emails, the old way, until you can include links in the notifications emails.

Erik Britt-Webb
drupal@ebrittwebb.com

Also

Michelle's picture

I went looking thru the notifications options and I don't see any option to not subcribe to things. Can we please make this opt in only?

Edit: For anyone else looking for this, it's an option in your edit account page. You need to uncheck the box.

Michelle


See my Drupal articles and tutorials or come check out the Coulee Region

opt in

yoroy's picture

I was not using notifications at all, started to recieve some yesterday to posts I recently commented in. Does that mean notifcations are indeed on by default? I actually found out about notifications by this, and I like it, now I can pick some groups and threads I really want to keep updated on. But make it opt-in please.

.

Michelle's picture

By default, it subscribes you to threads you comment on. You can go into your edit account page and uncheck that box to stop it. You can also uncheck the threads that you already were subscribed to.

I don't know if this checkbox can be off by default. I use subscriptions, not notifications, on my site.

Michelle


See my Drupal articles and tutorials or come check out the Coulee Region

Event confirmations

apperceptions's picture

Not sure if this is similar or related issue, but I just got an event confirm that looks like template vars are not getting filled in. Here is the email message:

Thanks Markus Sandy for signing up for our event. You will be reminded 1 day before the event.

LA Drupal December 2008 meeting - TWO weeks early!!!!
[Untimed]

%info

This is terrible

merlinofchaos's picture

First, it completely changed my notification settings. I used to recieve each message individually, with proper List-ID headers so my filters could do the right thing, and it used threading.

THen, suddenly, I'm receiving daily digests with titles of comments...AND NO LINKS.

So after a few days I get around to finding my notifications settings, and I get it to at least send me individual messages.

But it no longer has list-ids, so my filters are broken. And it just sends teasers; i used to read the fill message this way.

This change makes gdo basically useless to me now. I had all of my subscriptions nicely set up so that my mail reader gave me all the data and I got new notifications. Digest without links is worse than no mail at all, and losing the mail header information is a giant step backward.

Here is an example of the missing data:

Message-Id: <10780-56019@groups.drupal.org>
In-Reply-To: <10780-0@groups.drupal.org>
List-Id: Content Construction Kit (CCK) <http://groups.drupal.org/content-construction-kit-cck>
List-Unsubscribe: <http://groups.drupal.org/og/manage/732>
List-Owner: merlinofchaos <http://groups.drupal.org/user/169>
List-Archive: <http://groups.drupal.org/content-construction-kit-cck>

So until this is fixed, gdo is basically useless to me, since my workflow for using it has been completely disrupted and can't be repaired.

Thanks for the bug report,

moshe weitzman's picture

Thanks for the bug report, even if it is cranky mail. I'm glad you enjoyed my nice headers.

We are fixing the lack of links very soon, and the headers may or may not get fixed. I'll talk to it with Jose and other Notifications developers. With this change, some stuff got much better, and some worse. Please be patient, and we'll improve stuff soon.

Posting seems slower

mike stewart's picture

Posting seems slower since this weekend when you installed. takes 30sec+ after I hit submit to post now... perhaps unrelated but thought I'd mention since I haven't seen anyone else mention.

--
mike stewart { twitter: @MediaDoneRight | IRC nick: mike stewart }

.

Michelle's picture

I've had the same problem since yesterday. Never occured to me that it might be related but I suppose that makes sense since it has extra stuff to do now when you post.

Michelle


See my Drupal articles and tutorials or come check out the Coulee Region

Michelle - Are you

moshe weitzman's picture

Michelle - Are you deliberately using a Period as the Subject of your comment? It is not so helpful when seeing email notifications. If you use nop subject, one gets generated for you. Thanks.

Yes

Michelle's picture

I find Drupal's using the first few words to be annoying and so got in the habit of overriding it with a period if I couldn't think of a subject. If it bothers you, I'll try to make an effort to put an actual title on your threads but no guarantees. I've been doing this for a long time and it's pretty ingrained.

Michelle


See my Drupal articles and tutorials or come check out the Coulee Region

I just deployed a fix for

moshe weitzman's picture

I just deployed a fix for this. Jose optimized a couple queries for us.

What's the popup from?

Michelle's picture

I asked this on IRC but I guess you weren't around. I've been begging for notifications/subscriptions to add a popup like that for some time. I looked at the commit messages for noti but don't see anything. Is that custom for g.d.o? If so, could you share it? I hate the link bar filling method currently used. A popup is so much nicer.

Michelle


See my Drupal articles and tutorials or come check out the Coulee Region

Subscriptions popup

gustav's picture

Like Michelle, I too would be interested in the code for the subscriptions popup.

Yes, I third that

halfiranian's picture

Yes, I third that request.

Also, what's the difference between checking "all posts in a group" and checking the box above (with no accompanying text) which selects all the checkboxes?

Could this account for duplicate emails?

No notifications since oct 31

apperceptions's picture

Hi,

I was receiving notifications regularly from a few dozen groups until Oct 31st. Since then, I have only received two notifications related to a specific comment I posted. Looks like I lost all my regular group email notifications. Is there a quick way to reset this or do I have to set each one individually using user/UID/notifications/group? Any help appreciated and thanks for g.d.o.!

--

Markus Sandy
http://apperceive.com
http://ourmedia.org

I noticed the same problem

kyle_mathews's picture

I noticed the same problem when I upgraded to notifications on my OG site. It seems og_notification doesn't transfer group subscriptions into notification when added. I wrote a script which copies OG groups subscriptions to notification subscriptions. I can post it if there's interest.
Kyle Mathews

Kyle Mathews

Transferring og subscriptions to notification subscriptions

gustav's picture

Ah, now I realise why I have been getting so few notifications from gdo in recent weeks! I had no idea this was due to the switch to the notifications framework. I wonder how many other users have been missing their gdo notifications.

Kyle, such a script to automatically copy OG group subscriptions to notification subscriptions would be useful.

Here's the script. It's

kyle_mathews's picture

Here's the script. It's meant to be run from the root directory of your install on the command line (if that's not obvious).

<?php
  
// running Drupal's bootstrap on the command line causes a few notices, so suppress notices for a moment
   #error_reporting(E_ERROR | E_PARSE);

   // bootstrap Drupal
  
require_once('includes/bootstrap.inc');
  
drupal_bootstrap(DRUPAL_BOOTSTRAP_FULL);

  
// turn error reporting back to normal
   #error_reporting(E_ALL);

$usersIDs = db_query("SELECT uid FROM {users} WHERE uid != 0");

while (
$uid = db_fetch_array($usersIDs)) {
 
// load $user
 
$user = user_load(array('uid' => $uid['uid']));
  print
'user id '. $user->uid .'\n';

 
$GLOBALS['user'] = $user;

 
$result2 = db_query("select nid from {og_uid} where uid = %d and nid not in (select f.value from {notifica
tions} n join {notifications_fields} f where n.sid = f.sid and n.type = 'group' and n.uid = %d)"
, $user->uid
, $user->uid);

    while(
$data = db_fetch_array($result2)) {
      echo
"group id being added as subscription: ". $data['nid']. '\n\n';
     
$subscription = array();
     
$subscription['uid'] = $user->uid;
     
$subscription['type'] = 'group';
     
$subscription['event_type'] = 'node';
     
$subscription['fields'] = array('group' => $data['nid']);

     
notifications_save_subscription($subscription);

    }
}
?>

Kyle Mathews

Kyle Mathews

Maintenance

Group organizers

Group categories

Group notifications

This group offers an RSS feed. Or subscribe to these personalized, sitewide feeds: