My first patch to core....

Events happening in the community are now at Drupal community events on www.drupal.org.
Anonymous's picture

I noticed that this sort of error crops up a lot. Anyway, I got the preg_match warning myself the other day after upgrading a site.

After stepping through the code, I discovered that the profile module was passing select options as arrays (instead of the select text) into check_plain(). That seems like bug to me, so I submitted a patch to the profile module to send the selected option as text instead of an array.

I'd really appreciate feedback if this really was a problem and an appropriate fix. If not, someone set me straight :-) Thanks.

Comments

might get more attention if...

matt v.'s picture

In my experience, you'll get more attention on a core issue, if you create a patch for Head first. Once it's committed, it can then be back ported to the official release version. Also, writing tests to demonstrate the bug and that your patch fixes it, should also help it get attention. That said, it can still take a while.

Good ideas

FilmKnurd's picture

Thanks for the ideas. Where can I learn how to write the test? I am unfamiliar with the testing tools used with Drupal.

To answer my own question